[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2021-06-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2839

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2021-06-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #5 from Xisco Faulí  ---
(In reply to Gerald Pfeifer from comment #4)
> This was fixed by the commits related to bug#118458.
> 
> Verified with
> 
> Version: 7.2.0.0.alpha1+ / LibreOffice Community
> Build ID: b6a30a9db00f92eec7387a577321d65d47ff4af5
> CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3
> Locale: en-US (en_US.UTF-8); UI: en-US
> TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
> 2021-06-08_21:15:20

Indeed, fixed by 

https://cgit.freedesktop.org/libreoffice/core/commit/?id=486a11ad6fdae1714200229462b69f328be06b5a

thorMike Kaganski  2021-06-05 00:19:06
+0300
committer   Mike Kaganski  2021-06-08
14:51:57 +0200
commit  486a11ad6fdae1714200229462b69f328be06b5a (patch)
tree592469c652c8919cc1e864d20ea10f5d5b8b167a
parent  d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5 (diff)
editengine-columns: PPTX support (tdf#118458)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2021-06-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Gerald Pfeifer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Gerald Pfeifer  ---
This was fixed by the commits related to bug#118458.

Verified with

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: b6a30a9db00f92eec7387a577321d65d47ff4af5
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-06-08_21:15:20

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2021-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Justin L  changed:

   What|Removed |Added

   Assignee|jl...@mail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2021-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #3 from Justin L  ---
simple solution is
- sal_Int32 nColumnSize = mvTableGrid.size();
+ sal_Int32 nColumnSize = std::min(tableRow.getTableCells().size(),
mvTableGrid.size());

However, my guess is that using mvTableGrid.size() is wrong.

I wanted to make a minimized test, but round-tripping this file in Word 2010
"fixes" the problem. (I see that is also noted in bug 115209 where they also
attempted a minimized file with attachment 153755.)

So then should we also mark this as "NOTOURBUG"? I assume this comes from slide
6 since I get debug output with tableproperties.cxx:149: ::pushToPropSet
rows[6] columns[1] grid[3]

However, since a bandaid fix is simple, I'll propose
http://gerrit.libreoffice.org/c/core/+/109438 and suggest that bug 133015
probably needs to be revisited and get a better fix than using grid size.

Since our unique document's size is very large, I'm not including a unit test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2021-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

--- Comment #2 from Justin L  ---
Simple solution is
- sal_Int32 nColumnSize = mvTableGrid.size();
+td::min(tableRow.getTableCells().size(), mvTableGrid.size());

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

2020-09-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3015
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression
 CC||gulsah.k...@collabora.com,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=99dff69b561a8fe2d9437e6aa67a9581af41

author  Gülşah Köse  2020-08-10 10:04:51 +0300
committer   Gülşah Köse  2020-08-10 23:51:39
+0200
commit  99dff69b561a8fe2d9437e6aa67a9581af41 (patch)
tree11baa67101340214ba81f75253ac30b88cb66d84
parent  386add495b3d8b7816a521bb28c5f48fc243bc99 (diff)
tdf#133015 Fix table position during import multicol textbox.

Bisected with: bibisect-linux64-7.1

Adding Cc: to Gülşah Köse

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs