[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3163 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 --- Comment #7 from Mike Kaganski --- (In reply to László Németh from comment #6) > Using the recent word-level track changes it's easy to fix the bad title > casing > of the title case algorithm by reverting the bad capitalization of some words > with a few clicks (see the fix for NatNum12 Heh. I didn't realize that this was a regression - or did I misunderstand? I don't quite see which fix do you refer to specifically - it would be better if you pointed to a commit, rather than to release notes that point to a bug with multiple commit notifications :) But regarding to "it's easy to fix the bad title casing ... with a few clicks" - that is so wrong! See bug 152340. It easily overflows the undo stack, so in addition to not being able to "easily fix", one looses ability to undo something they did a few operations ago. No, please don't. It is plain wrong. When one wants to change something, they just type over, and it all still is one big change, that simply includes some unchanged words. Just as UPPERCASE does. See how it includes parts that are already uppercase, even when they are at the very start/end of the selection. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 --- Comment #6 from László Németh --- (In reply to Mike Kaganski from comment #5) > I would think that modifying the title case function to prepare a full > selection/per-paragraph text, and replacing as a whole, to produce results > similar to what UPPERCASE gives, would make the hack unneeded here? Because > disabling redlining when user needs it is ... wrong? Hi, Mike! Great idea! There is a trade-off within the different implementations, keeping the old tracked changes, portion formatting etc., so it's not an easy task, and the result could be worse easily. Using the recent word-level track changes it's easy to fix the bad title casing of the title case algorithm by reverting the bad capitalization of some words with a few clicks (see the fix for NatNum12: https://wiki.documentfoundation.org/ReleaseNotes/7.5#Default_.E2.80.9Cspell_out.E2.80.9D_number_and_currency_formats). So I suggest to combine or extend the recent solution, i.e. apply your fix only at formatting too many paragraphs (if it's possible without losing other formatting or data), when redlining is disabled now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2340 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 --- Comment #5 from Mike Kaganski --- I would think that modifying the title case function to prepare a full selection/per-paragraph text, and replacing as a whole, to produce results similar to what UPPERCASE gives, would make the hack unneeded here? Because disabling redlining when user needs it is ... wrong? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 Commit Notification changed: What|Removed |Added Whiteboard|target:7.2.0|target:7.2.0 target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 --- Comment #4 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b438a4502d2b388012b0744374e86d1ff0543e8d tdf#140731: sw: move UItest to CppUnittest It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 --- Comment #3 from Commit Notification --- Balazs Santha committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e9f9e2315ba5a4f10ac0d3a6a6a6cca711d49b6f sw: test fix of tdf#140731 (freezing with track changes) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 László Németh changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Assignee|santha.bal...@simonyi.bme.h |libreoffice-b...@lists.free |u |desktop.org --- Comment #2 from László Németh --- Commit description: tdf#140731: sw transliteration: avoid too many redlines As a workaround for the performance regression from commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9 (tdf#109266 sw change tracking: track transliteration), switch off redlining to avoid ~freezing, if a single transliteration could result too many (>~500) redlines. A single transliteration creates n redlines for n paragraphs of the selected text, except in the case of transliterating to title case, where it creates n redlines for n words. It's very easy to freeze Writer, because Writer's slowing down with n redlines is described by an O(n²) (quadratic) time complexity. Eg. in an experiment, title casing ~660 words was 6 sec, but ~3000 words was 85 sec, regarding to creating 660 vs 3000 redlines. Note: this is a partial revert of commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9, if the selection contains more than 500 paragraphs (or in the case transliterating to title case, ~500 words). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140731] EDITING Capitalize Every Word operation slow with large file and enabled change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=140731 Balázs Sántha changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |santha.bal...@simonyi.bme.h |desktop.org |u Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
