[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 Matej Kivader changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #9 from Commit Notification --- bykivi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/68b225bfbf51391b517dd483181e40e4a4c3fe31 tdf#141195:fix button text color with default background color It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #8 from Matej Kivader --- (In reply to Matej Kivader from comment #6) > I added a new version of the patch. > For me it looks like commit bellow from Thorsten could be simplified with no > visible adverse effects. > During debugging I hit (and fix) another UX bug. If Background color is > chosen, highlight of the button do nothing. So I fixed also this. > In attachment is a test file (Macro->Edit Macros - module Standard->Dialog1. Commit from Thorsten: https://git.libreoffice.org/core/commit/84b2849512bdb19597739d9515dd55e2d3ba9504 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #7 from Matej Kivader --- Created attachment 171039 --> https://bugs.documentfoundation.org/attachment.cgi?id=171039=edit Test file to see buttons behavior -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #6 from Matej Kivader --- I added a new version of the patch. For me it looks like commit bellow from Thorsten could be simplified with no visible adverse effects. During debugging I hit (and fix) another UX bug. If Background color is chosen, highlight of the button do nothing. So I fixed also this. In attachment is a test file (Macro->Edit Macros - module Standard->Dialog1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #5 from Matej Kivader --- (In reply to Buovjaga from comment #4) > (In reply to Matej Kivader from comment #3) > > Hello Xisco, > > Pushed to gerrit > > https://gerrit.libreoffice.org/c/core/+/112989 > > I confirm this fixes it for me. Note for testers: the button to press is > "Preview Dialog". > > Btw. in the commit message of your patch you have an unnecessary line with > "w" > > Version: 7.2.0.0.alpha0+ / LibreOffice Community > Build ID: 18cc01b63996f81b284e3bc827d1be7f3da8983a > CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: kf5 > Locale: fi-FI (fi_FI.UTF-8); UI: en-US > Calc: threaded Sorry for that(In reply to Buovjaga from comment #4) > (In reply to Matej Kivader from comment #3) > > Hello Xisco, > > Pushed to gerrit > > https://gerrit.libreoffice.org/c/core/+/112989 > > I confirm this fixes it for me. Note for testers: the button to press is > "Preview Dialog". > > Btw. in the commit message of your patch you have an unnecessary line with > "w" > > Version: 7.2.0.0.alpha0+ / LibreOffice Community > Build ID: 18cc01b63996f81b284e3bc827d1be7f3da8983a > CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: kf5 > Locale: fi-FI (fi_FI.UTF-8); UI: en-US > Calc: threaded Hi, sorry for that "w" ... VIM goes crazy on fresh cygwin installation. Amended. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 Buovjaga changed: What|Removed |Added Blocks||97233 CC||ilmari.lauhakangas@libreoff ||ice.org OS|Windows (All) |All Status|UNCONFIRMED |NEW Severity|normal |minor Ever confirmed|0 |1 --- Comment #4 from Buovjaga --- (In reply to Matej Kivader from comment #3) > Hello Xisco, > Pushed to gerrit > https://gerrit.libreoffice.org/c/core/+/112989 I confirm this fixes it for me. Note for testers: the button to press is "Preview Dialog". Btw. in the commit message of your patch you have an unnecessary line with "w" Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 18cc01b63996f81b284e3bc827d1be7f3da8983a CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: kf5 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97233 [Bug 97233] [META] Dialog Designer bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #3 from Matej Kivader --- (In reply to Xisco Faulí from comment #2) > Hello Matej, > Thanks for reporting this issue. > Please, read > https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch on how to > submit patches to gerrit, the platform used to review them Hello Xisco, Pushed to gerrit https://gerrit.libreoffice.org/c/core/+/112989 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Hello Matej, Thanks for reporting this issue. Please, read https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch on how to submit patches to gerrit, the platform used to review them -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195 --- Comment #1 from Matej Kivader --- Created attachment 170654 --> https://bugs.documentfoundation.org/attachment.cgi?id=170654=edit Proposed patch fot the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
