[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Telesto changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #27 from Telesto --- @Regina Any opinion on comment 26? (In reply to stefan_lange...@t-online.de from comment #26) > I also think this bug is worn-out. But because there are several problems I > am not sure if a new bug should be reported or better a proposal for > enhancement: > - In the ODF Standard V 1.3 there is no image property "Keep aspect ratio". > Even if in LibreOffice an individual KeepRatio value for image objects is > introduced this setting cannot be saved as image property in a odf document. > - Propably it would be better when the "KeepRatio" setting is used only once > as it is done in properties dialog for frames. > - The other question is how this setting is set initially or as default. > IMHO this can be done by the "KeepRatio" value from Settings.xml, and this > value could be set by a new Options value instead to take it from a Picture > properties dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #26 from stefan_lange...@t-online.de --- (In reply to Telesto from comment #25) > I think a fresh bug report is needed. The problems have mutated/evolved over > time so the initial bug report doesn't match comment 0 > > (In reply to stefan_lange...@t-online.de from comment #9) > > As far I have seen until now and just tested newly the setting "Keep ratio" > > from the Image properties dialog is used for all images (!) of a document, > > means one sets this value once on or off and this setting is used for all > > images. > > True, and undesired in my opinion. You enable something like this for each > image individually. It surely shouldn't behave as a global setting. You open > a image specific dialog and 'keep ratio' is applied for all images in > document.. > > Note: The same behaviour is also observed in draw > > If Keep Ratio should be toggled on or off by default another question and be > saved for each image independently (if you ask me) and frame for that matter > > > Furthermore this setting is saved in the odt subdocument > > "Settings.xml" as config item, e.g. > config:name="KeepRatio" config:type="boolean">true. > > So the value is kept when the document is closed and opened again. > > Not OK, should be a image specific setting. Which is my personal preference. > Or nothing should be saved at all > > > On the other hand the properties dialog e.g. for frames looking nearly - or > > completely (?) - like the properties dialog for images also contains the > > setting "Keep ratio" but when it is set on it is valid only for this one > > call of the dialog. It is lost at the next dialog call for this frame or > > other frames and it is also not used for images. > > Vice versa the "Keep ratio" value set for images is not used for frames. > > Not storing the keep ratio checkbox is at least coherent. > > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 5682e1d4145c26fc8021879df0543d5aeacf9c83 > CPU threads: 8; OS: macOS 13.4.1; UI render: Skia/Raster; VCL: osx > Locale: nl-NL (nl_NL.UTF-8); UI: en-US > Calc: threaded I also think this bug is worn-out. But because there are several problems I am not sure if a new bug should be reported or better a proposal for enhancement: - In the ODF Standard V 1.3 there is no image property "Keep aspect ratio". Even if in LibreOffice an individual KeepRatio value for image objects is introduced this setting cannot be saved as image property in a odf document. - Propably it would be better when the "KeepRatio" setting is used only once as it is done in properties dialog for frames. - The other question is how this setting is set initially or as default. IMHO this can be done by the "KeepRatio" value from Settings.xml, and this value could be set by a new Options value instead to take it from a Picture properties dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #25 from Telesto --- I think a fresh bug report is needed. The problems have mutated/evolved over time so the initial bug report doesn't match comment 0 (In reply to stefan_lange...@t-online.de from comment #9) > As far I have seen until now and just tested newly the setting "Keep ratio" > from the Image properties dialog is used for all images (!) of a document, > means one sets this value once on or off and this setting is used for all > images. True, and undesired in my opinion. You enable something like this for each image individually. It surely shouldn't behave as a global setting. You open a image specific dialog and 'keep ratio' is applied for all images in document.. Note: The same behaviour is also observed in draw If Keep Ratio should be toggled on or off by default another question and be saved for each image independently (if you ask me) and frame for that matter > Furthermore this setting is saved in the odt subdocument > "Settings.xml" as config item, e.g. config:name="KeepRatio" config:type="boolean">true. > So the value is kept when the document is closed and opened again. Not OK, should be a image specific setting. Which is my personal preference. Or nothing should be saved at all > On the other hand the properties dialog e.g. for frames looking nearly - or > completely (?) - like the properties dialog for images also contains the > setting "Keep ratio" but when it is set on it is valid only for this one > call of the dialog. It is lost at the next dialog call for this frame or > other frames and it is also not used for images. > Vice versa the "Keep ratio" value set for images is not used for frames. Not storing the keep ratio checkbox is at least coherent. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5682e1d4145c26fc8021879df0543d5aeacf9c83 CPU threads: 8; OS: macOS 13.4.1; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Heiko Tietze changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Heiko Tietze changed: What|Removed |Added Keywords|difficultyMedium, easyHack | Assignee|heiko.tietze@documentfounda |libreoffice-b...@lists.free |tion.org|desktop.org Hardware|x86-64 (AMD64) |All Summary|Improve UI in Image|Undo/redo for |Properties Dialog for the |checking/unchecking |locked state|KeepRatio in Image ||Properties Dialog not ||properly handled OS|Windows (All) |All Status|ASSIGNED|NEW --- Comment #24 from Heiko Tietze --- (In reply to Telesto from comment #23) > It can be pretty confusing and/or utterly astonishing for a bug reporter if > the bug suddenly being about something different or focussing on a very > narrow element of the original report Created bug 158531 and vote for WF here. (In reply to stefan_lange...@t-online.de from comment #22) > ...saved as an entry in the odf subdocument "Settings.xml". We shouldn't save this option then. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=80 ||281 --- Comment #11 from Heiko Tietze --- The UI-only feature could be visualized differently to ordinary controls. What I have in mind is a icon-only button showing a lock symbol (different icons when toggled on/off) and "connector lines" to the respective controls. Width [ ] -| [ ] Relative...[x] Height [] -| Since the "connector lines might be not drawable easily we could just indicate this with an image or on-the-fly created angle. Easy hackable, if accepted. See also bug 80281 - FORMATTING: "Keep aspect ratio" checkbox of images or photos not always honoured concludes to switch the option on by default. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #10 from Miklos Vajna --- SwViewOption::IsKeepRatio() is what I had in mind for the view-level option (this is similar to e.g. "show non-printable characters"). And then we also have SwFormatFrameSize::QueryValue() for the document model, where a magic 255% percent for the width or height means "just keep the ratio according to the other axis". Given that we have a single "keep ratio" on the UI, this is confusing, I would say. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #9 from stefan_lange...@t-online.de --- When in Comment_7 is written "The UI is a bit messy here ..." I think ths is true. But I am not sure if the information in Comment_7 is completely true. I have seen the same (or nearly the same) properties dialog is used for different object types (images, frames, ???) but especially the "Keep ratio" setting is handled different. As far I have seen until now and just tested newly the setting "Keep ratio" from the Image properties dialog is used for all images (!) of a document, means one sets this value once on or off and this setting is used for all images. Furthermore this setting is saved in the odt subdocument "Settings.xml" as config item, e.g. true. So the value is kept when the document is closed and opened again. On the other hand the properties dialog e.g. for frames looking nearly - or completely (?) - like the properties dialog for images also contains the setting "Keep ratio" but when it is set on it is valid only for this one call of the dialog. It is lost at the next dialog call for this frame or other frames and it is also not used for images. Vice versa the "Keep ratio" value set for images is not used for frames. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Buovjaga changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #8 from Buovjaga --- (In reply to Miklos Vajna from comment #7) > The UI is a bit messy here, I fear. On one hand, "keep ratio" can be a > special value for width or height in case the other axis has a fixed value. > > On the other hand, this "keep ratio" can be a view option, so if you enabled > it for one image, there is some effort to enable it for an other image as > well, if you adjust the width or height. > > You see how "keep ratio" can mean two different things. :-) One is a > UI-level option, the other is something that is stored in the document model > for an image. > > The linked commit mentions the "80% shows up as 237%" problem, we certainly > don't want to return to the old state. But in case somebody wants to improve > the UI here so it's less confusing, that would make sense. UX team: could that "somebody" be you?! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #7 from Miklos Vajna --- The UI is a bit messy here, I fear. On one hand, "keep ratio" can be a special value for width or height in case the other axis has a fixed value. On the other hand, this "keep ratio" can be a view option, so if you enabled it for one image, there is some effort to enable it for an other image as well, if you adjust the width or height. You see how "keep ratio" can mean two different things. :-) One is a UI-level option, the other is something that is stored in the document model for an image. The linked commit mentions the "80% shows up as 237%" problem, we certainly don't want to return to the old state. But in case somebody wants to improve the UI here so it's less confusing, that would make sense. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org, ||vmik...@collabora.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=58 ||623 --- Comment #6 from Buovjaga --- Let's ask Miklos what he thinks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #5 from Kira Tubo --- *** Bug 154162 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #4 from stefan_lange...@t-online.de --- I have bibisected to find the change from "old" behavior as described in the bug description to the "new" behavior as described in Comment 3: e18b47dbd75cec720d7f486a44b8a235625a5856 is the first bad commit commit e18b47dbd75cec720d7f486a44b8a235625a5856 Author: Norbert Thiebaud Date: Thu Mar 17 11:22:13 2022 -0700 source sha:9e8712ed6f9fb5dbd971e352a5709bd45fadc74f source sha:9e8712ed6f9fb5dbd971e352a5709bd45fadc74f instdir/program/cuilo.dll | Bin 4620800 -> 4621312 bytes instdir/program/setup.ini | 2 +- instdir/program/swlo.dll| Bin 17019392 -> 17019904 bytes instdir/program/version.ini | 2 +- 4 files changed, 2 insertions(+), 2 deletions(-) The "old" behavior was in the bisect tests exactly as described in the bug description except the detail "Height value is set to Width value (10,00 cm) - problem as described in Bug 143321". This effect propably didn't occur because Bug 143633 was already fixed in LO 7.2.1 on 2021-08-25 15:10:09 UTC. IMHO it makes no sense to bibisect for the start of the "old" behavior because it is obsolete. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 --- Comment #3 from stefan_lange...@t-online.de --- After the last change (buzea.bog...@libreoffice.org, 2023-05-12 15:57:40 UTC) I have tested with current and coming soon versions of LibreOffice if the bug still exists: Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded and Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6f1534940ac12ff8e46f4782e18cfb6cf585da39 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded I have tested as decribed in the bug description (open "Test_Bildgröße_V2_keep_ratio_off.odt" and check "KeepRatio" in the picture properties dialog). Result with both LO versions: The behavior has changed completely: - the Undo arrow remains unchanged (gray) - the Save icon remains unchanged (no red point is added) - When I click on the Save icon (without the red point!) the changed document is saved correctly: New entry "KeepRatio" is added to ods subdocument "settings.xml" and at the next open of the document "KeepRatio" appears checked. - But when I try to close the document without save no question appears "Document changed, save?" and the document is closed without to save the change. Because of the changed behavior I am not sure if the bug shall remain opened (status "New") or if it should be closed (what reason?) and a new bug should be reported. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 BogdanB changed: What|Removed |Added Blocks||105948 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl Keywords||bibisectRequest, ||implementationError Version|7.2.0.0.beta1+ |4.0.0.3 release --- Comment #2 from Telesto --- Also in 6.2 and in Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL also in Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 and in Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89) no undo in 3.5.7.2 Adding bibisectrequest for the implementation of undo. Suspecting an implementationError -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties Dialog not properly handled
https://bugs.documentfoundation.org/show_bug.cgi?id=143340 Telesto changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Telesto --- Confirm Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4e0a7df2dfa10bc52d5dbda34f43e0bc0df22ae7 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
