[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec ( steps in comment 10 )
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Thorsten Behrens (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec ( steps in comment 10 )
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Telesto changed: What|Removed |Added Blocks||133092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec ( steps in comment 10 )
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #11 from johnks --- i confirm this is present for me Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Flatpak Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec ( steps in comment 10 )
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Xisco Faulí changed: What|Removed |Added Summary|Impress: Crash when slide |Impress: Crash when slide |transition = 0sec |transition = 0sec ( steps ||in comment 10 ) Version|7.1.4.2 release |5.2 all versions --- Comment #10 from Xisco Faulí --- Also reproducible in Version: 5.2.0.0.alpha1+ Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e CPU Threads: 4; OS Version: Linux 5.7; UI Render: default; Locale: en-US (en_US.UTF-8) Steps to reproduce: 1. Open Impress 2. Go to Slide Transition in the sidebar 3. Change duration to 0 seconds 4. Select Bars transition -> Crash -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Crash report or||["slideshow::internal::Rand crash signature||omWipe::operator()(double)" ||] See Also||https://crashreport.libreof ||fice.org/stats/signature/sl ||ideshow::internal::RandomWi ||pe::operator()(double) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615
Julien Nabet changed:
What|Removed |Added
CC|serval2...@yahoo.fr |
--- Comment #9 from Julien Nabet ---
I tried this:
diff --git
a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
index 9e23fc2c76c8..a90f93994f76 100644
--- a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
+++ b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
@@ -46,7 +46,7 @@ namespace slideshow::internal
double SimpleContinuousActivityBase::calcTimeLag() const
{
ActivityBase::calcTimeLag();
-if (! isActive())
+if (! isActive() || !mnMinSimpleDuration)
return 0.0;
// retrieve locally elapsed time
@@ -107,7 +107,7 @@ namespace slideshow::internal
bool SimpleContinuousActivityBase::perform()
{
// call base class, for start() calls and end handling
-if( !ActivityBase::perform() )
+if( !ActivityBase::perform() || !mnMinSimpleDuration )
return false; // done, we're ended
Setting 0 first time was ok then I increased to 1 then decreased again to 0, it
hanged.
It seems more complicated than I thought.
uncc myself, I can't help here.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #8 from Miklos Vajna --- slideshow/source/engine/activities/simplecontinuousactivitybase.cxx:49 and slideshow/source/engine/activities/simplecontinuousactivitybase.cxx:93 already returns 0 in the error code, my suggestion is to do the same before the div-by-zero would happen. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #7 from Julien Nabet --- (In reply to Miklos Vajna from comment #6) > The function already returns 0 in various other error cases, you could > probably do the same just before the div by 0 would happen. Unless Thorsten > has a better suggestion. :-) Have you got an example of these other locations? Indeed, I git grepped in slideshow dir "mnMinDuration" and "mnMinSimpleDuration", I don't see any examples to prevent from a division by 0. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #6 from Miklos Vajna --- The function already returns 0 in various other error cases, you could probably do the same just before the div by 0 would happen. Unless Thorsten has a better suggestion. :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Aron Budea changed: What|Removed |Added Blocks||103444, 103704 CC||ba...@caesar.elte.hu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103444 [Bug 103444] [META] Slide transition deck/tab of the sidebar https://bugs.documentfoundation.org/show_bug.cgi?id=103704 [Bug 103704] [META] Slide transition bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Julien Nabet changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Julien Nabet changed: What|Removed |Added OS|Windows (All) |Linux (All) Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Julien Nabet changed: What|Removed |Added CC||nagy.tib...@nisz.hu, ||t...@libreoffice.org, ||vmik...@collabora.com --- Comment #5 from Julien Nabet --- Miklos/Thorsten/Tibor (I don't know if one of you know slideshow part, I just used git history): The pb is when choosing 0, "mnMinSimpleDuration" has value 0 but is used at locations like: 68 nCurrElapsedTime / mnMinSimpleDuration ); 118 double nT( nCurrElapsedTime / mnMinSimpleDuration ); in slideshow/source/engine/activities/simplecontinuousactivitybase.cxx See https://opengrok.libreoffice.org/xref/core/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx?r=c82efb61#68 Now, I wonder if it really makes sense to choose 0 and if we shouldn't put minimum at 1. I read https://www.w3.org/TR/SMIL/smil-timing.html#q3 since code references SMIL but it's not very clear: "dur Specifies the simple duration. The attribute value may be any of the following: Clock-value Specifies the length of the simple duration, measured in element active time. Value must be greater than 0." <- so can't be 0 "The min/max attributes provide the author with a way to control the lower and upper bound of the element active duration. min Specifies the minimum value of the active duration. The attribute value may be either of the following: Clock-value Specifies the length of the minimum value of the active duration, measured in element active time. Value must be greater than or equal to 0. "media" Specifies the minimum value of the active duration as the intrinsic media duration. This is only valid for elements that define media. If there is any error in the argument value syntax for min, the attribute will be ignored (as though it were not specified). The default value for min is "0". This does not constrain the active duration at all." so can be 0. What do you think? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 BogdanB changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||buzea.bog...@libreoffice.or ||g --- Comment #4 from BogdanB --- Confirm with Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Created attachment 173966 --> https://bugs.documentfoundation.org/attachment.cgi?id=173966=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I got a crash but at a different location. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #2 from BDF --- CRASH REPORT NOTE: The crash report was uploaded to https://crashreport.libreoffice.org/stats/crash_details/ad9c6cbc-04da-42a2-bde2-1b3294494641 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #1 from BDF --- Created attachment 173957 --> https://bugs.documentfoundation.org/attachment.cgi?id=173957=edit LO Impress - bug 143615 - crash with slide transition at 0sec To crash Impress, select transition Lines (de: Balken) or Resolve (de: Auflösen) and set the duration to 0 sec. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
