[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2022-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from NISZ LibreOffice Team  ---
Verified in:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8f0ce842dffe229d31bd9841ac6e999da1ae976d
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

--- Comment #6 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1edaee2f03bce0efa409c592919458658d0aa751

tdf#146244 sw: fix Undo of accepting table row insertion

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

László Németh  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6145

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

László Németh  changed:

   What|Removed |Added

 Blocks|143004  |143002


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143002
[Bug 143002] [META] Tracked Changes of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=143004
[Bug 143004] LibreOffice shows ~2px on second monitor if maximized on first
monitor
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

László Németh  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=60
   ||382
 Blocks|143003  |143004


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143003
[Bug 143003] [META] Tracked Changes of ordered and unordered lists
https://bugs.documentfoundation.org/show_bug.cgi?id=143004
[Bug 143004] LibreOffice shows ~2px on second monitor if maximized on first
monitor
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

--- Comment #5 from László Németh  ---
tdf#146244 sw: update HasTextChangesOnly in modified rows

It's not forbidden to write in rows deleted or
inserted with change tracking, also Accept/Reject
only part of the text changes here. Improve to
handle these in SwTableLine::UpdateTextChangesOnly()
by keeping property HasTextChangesOnly = false
(tracked row change) only if

1) there is an insert redline, which is the oldest redline in
   the row (tracked row insertion) or

2) there is a delete redline, which is the newest redline in
   the row, and no text outside of redlines, and no insert
   redline in the row, i.e. whole text content is deleted
   (tracked row deletion).

Also update HasTextChangesOnly table row property at accepting
SwRangeRedlines in changed table rows.

And follow-up bug fix commits of this:
commit bc206f7fd3b4a9e843c81f39dcd2faeeff9c785a
"cid#1495785 silence Unchecked return value" and
commit 213173edc5e47bb6da11f9a301f4dca71854a48c
"sw: fix crash with commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

--- Comment #4 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/02b8bcf06c431ea4694d9fe13d6aa59100c79c05

tdf#146244 sw: update HasTextChangesOnly in modified rows

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0
   ||target:7.3.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

--- Comment #3 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8c028b7e41e3d350d0e67005b16faf0159cc5c12

tdf#146244 sw: update HasTextChangesOnly in modified rows

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

--- Comment #2 from NISZ LibreOffice Team  ---
Created attachment 176952
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176952=edit
Example file from Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 176951
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176951=edit
Screenshot of the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146244] FILEEDIT ODT Writing in a deleted table row doesn't update the tracked changes, e.g. removing the row change (keeping that in the export, too)

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146244

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Blocks||143003
 CC||nem...@numbertext.org,
   ||varga.bala...@nisz.hu
   Keywords||filter:odt


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143003
[Bug 143003] [META] Tracked Changes of ordered and unordered lists
-- 
You are receiving this mail because:
You are the assignee for the bug.