[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #14 from Mike Kaganski  ---
(In reply to Mike Kaganski from comment #13)
> and that means, for empty character, ...

Sorry, a typo: should be "and that means, for empty paragraph"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #13 from Mike Kaganski  ---
(In reply to Dieter from comment #12)
> > and that implied for empty paragraphs to move when pressing enter
> > in that empty paragraph.
> 
> But why is this a necessary behaviour?

It is not "necessary"; it is just how anchor to character is defined (the
anchor is a special invisible "character" that is inserted *before* the
anchored-to actual character); and that means, for empty character, that the
inserted anchor is *before* ... what? it's before the paragraph end, which
serves the anchoring point in this case. So when you put a cursor into an empty
paragraph, it is *after* paragraph start, and *before* paragraph end; when you
press Enter, you logically insert a "paragraph end - paragraph start" pair in
the place where your cursor is, moving the existing old paragraph end to the
following new paragraph; and since that moved paragraph end is the anchoring
point, the anchored object moves accordingly.
But it is of course possible to special-case it as much as wanted ... just some
clear unambiguous and non-confusing specification of expected behavior is
needed.

> But I'm not a developer and I don't
> have to understand in detail. I just can't imagine, that a user expects,
> that new paragraphs are inserted above an image, if he presses enter in a
> paragraph below that image.

This is illogical. You are talking about the image being "above" paragraphs -
and here you mix the anchoring with the orthogonal positioning; an image
anchored to this character may be above or below, may have a fixed position on
page, etc. This is not relevant to the discussion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #12 from Dieter  ---
I understand, that initial bug report is misleading. So, to be more precise:

Steps to Reproduce:
1. Create a Writer Document and change style of first paragraph to "Heading 1"
(not necessary, but makes more visible what's happening"
2. Insert an image. Anchor of image is "To Character" (Although it is not clear
to me, what character is in an empty paragraph)
3. Set cursor to first paragraph.
4. Press Enter key several times.

Actual Results:
Anchor "To Chracter" is part of the new paragraph (still don't know what
character) and image moves down.

Expected Results:
Anchor "To Character" should be still part of same paragraph (I assume, that -
at least in normal text - a character is always part of a paragraph).

(In reply to Mike Kaganski from comment #6)
> The behavior of
> to-character-anchored objects is actually to move *with its character*
> position,

No problem with that

> and that implied for empty paragraphs to move when pressing enter
> in that empty paragraph.

But why is this a necessary behaviour? But I'm not a developer and I don't have
to understand in detail. I just can't imagine, that a user expects, that new
paragraphs are inserted above an image, if he presses enter in a paragraph
below that image.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #11 from Aron Budea  ---
(In reply to Dieter from comment #8)
> Perhaps my initial comment was not well formulated, but I've never talked
> about anchor "To Paragraph". It's of course anchor "To Character", but
> character is obviously part of a paragraph.
You specifically mentioned paragraph in comment 4: "paragraph doesn't move, but
anchor changes to new paragraph". The anchor doesn't change to the new
paragraph, the anchor moves with the caret, just like a character after the
anchor would move to the new paragraph if you hit Enter with the caret before
it.

Also, if you set the anchor to To Character manually between steps 2 and 3 from
the description, the behavior is the same in LO 3.3.0. Therefore this isn't a
regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #10 from Dieter  ---
(In reply to Aron Budea from comment #7)
> Dieter, the image isn't anchored to a paragraph, but to character, as Mike
> has explained it. If you want to extend the description to include adjusting
> to To Paragraph anchoring, this is a duplicate of bug 146443.

Perhaps my initial comment was not well formulated, but I've never talked about
anchor "To Paragraph". It's of course anchor "To Character", but character is
obviously part of a paragraph.


So I still think, that - from a user perspektive - it's an unexpected result.
At least for the reason of consistency, you should get same result with an
empty paragraph and a paragraph containing one character.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #9 from Dieter  ---
(In reply to Aron Budea from comment #7)
> Dieter, the image isn't anchored to a paragraph, but to character, as Mike
> has explained it. If you want to extend the description to include adjusting
> to To Paragraph anchoring, this is a duplicate of bug 146443.

Perhaps my initial comment was not well formulated, but I've never talked about
anchor "To Paragraph". It's of course anchor "To Character", but character is
obviously part of a paragraph.


So I still think, that - from a user perspektive - it's an unexpected result.
At least for the reason of consistency, you should get same result with an
empty paragraph and a paragraph containing one character.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2948

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #8 from Dieter  ---
(In reply to Aron Budea from comment #7)
> Dieter, the image isn't anchored to a paragraph, but to character, as Mike
> has explained it. If you want to extend the description to include adjusting
> to To Paragraph anchoring, this is a duplicate of bug 146443.

Perhaps my initial comment was not well formulated, but I've never talked about
anchor "To Paragraph". It's of course anchor "To Character", but character is
obviously part of a paragraph.


So I still think, that - from a user perspektive - it's an unexpected result.
At least for the reason of consistency, you should get same result with an
empty paragraph and a paragraph containing one character.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2022-01-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #7 from Aron Budea  ---
(In reply to Mike Kaganski from comment #6)
> Also excuse for the not completely correct phrase above. The behavior of
> to-character-anchored objects is actually to move *with its character*
> position, and that implied for empty paragraphs to move when pressing enter
> in that empty paragraph.
> 
> That doesn't change things much, just a clarification of #1.
It does, as Dieter's comments are all related to paragraphs, eg.:

> (In reply to Dieter from comment #4)
> > But problem is, that paragraph doesn't move
Dieter, the image isn't anchored to a paragraph, but to character, as Mike has
explained it. If you want to extend the description to include adjusting to To
Paragraph anchoring, this is a duplicate of bug 146443.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2021-12-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #6 from Mike Kaganski  ---
(In reply to Dieter from comment #4)
> (In reply to Mike Kaganski from comment #3)
> > That made images follow what was *always* the behavior of
> > "to character"-anchored objects, which was move with its paragraph.
> 
> But problem is, that paragraph doesn't move

Also excuse for the not completely correct phrase above. The behavior of
to-character-anchored objects is actually to move *with its character*
position, and that implied for empty paragraphs to move when pressing enter in
that empty paragraph.

That doesn't change things much, just a clarification of #1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2021-12-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

--- Comment #5 from Mike Kaganski  ---
(In reply to Dieter from comment #4)
> But problem is, that paragraph doesn't move

This is just a flaky definition of "paragraph move" concept. See bug 120469
comment 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146445] Anchor of image moves to next paragraph when type Enter key at original (empty) paragraph

2021-12-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146445

Dieter  changed:

   What|Removed |Added

Summary|Anchor of image moves to|Anchor of image moves to
   |next paragraph when type|next paragraph when type
   |Enter key at original   |Enter key at original
   |paragraph   |(empty) paragraph

--- Comment #4 from Dieter  ---
(In reply to Mike Kaganski from comment #3)
> 1. In 7.0 (and backported to 6.4), there was
> https://git.libreoffice.org/core/+/a7528cd6f17ea5c5b29e7d607e54c62de0d9e7db,
> that explicitly aimed to anchor inserted images *to character* (as opposed
> to previous "to paragraph", with an intermediate "as character" moment
> during the development phase). That made images follow what was *always* the
> behavior of "to character"-anchored objects, which was move with its
> paragraph.

Thanks for quick response and explanation. But problem is, that paragraph
doesn't move, but anchor changes to new paragraph. I think this is only a
problem in empty paragraphs (see further explanations in bug 146443 comment 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.