[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower on 1st run

2022-03-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #22 from Caolán McNamara  ---
I'll take this because I've some work done looking into it. Fundamentally the
font used for the bullet doesn't appear to have the selected symbol in it and
this is a glyph fallback case so it might not be a mainstream problem.

What font is used for the glyph fallback may differ from system to system
depending on what's available for use so we might be seeing different results.

Anyway, the commits I'll push bring it from from 8 seconds to 3 seconds to
convert this on the command line for my setup.

https://gerrit.libreoffice.org/c/core/+/130892
https://gerrit.libreoffice.org/c/core/+/130877

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower on 1st run

2022-03-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #21 from Caolán McNamara  ---
Created attachment 178619
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178619=edit
reproduce for the original problem

Checking my local FreeSerif, if the cache is enabled again for this case then
this example will render missing glyphs if the range is made italic in
additional to the current bold.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower on 1st run

2022-03-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #20 from Caolán McNamara  ---
I think we can ignore comment #17 as twaddle. Looking at it a little more, the
glyph fallback is from "Noto Sans Symbols" for codepoint 0x25aa. That font
doesn't have this bullet, fontconfig suggests that we could replace it with
"Noto Color Emoji" *but* additionally suggests we apply an extra matrix to skew
it.

Back in bug #32665 we disabled the cache for "emboldened" and this sort of
"fake italic" glyph fallback suggestions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower on 1st run

2022-02-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #19 from Timur  ---
I amend the title with "on 1sr run" because only 1st run is slow, 2nd run of
the same command is fast. 
Applies both to 7.3-oldest and 7.4-master, both for default attachment 178523
and custom attachment 178524.  
So title seems wrong from the beginning (did you run custom first and then
default without clearing from the memory or reboot?).

(Seems that 1st run was becoming more slow with newer LO, from 8 to 34 secs for
me. But I didn't check what's exported).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower on 1st run

2022-02-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Timur  changed:

   What|Removed |Added

Summary|[FILEOPEN PPTX] list with   |[FILEOPEN PPTX] list with
   |custom style is 10 times|custom style is 10 times
   |slower  |slower on 1st run

--- Comment #18 from Timur  ---
I amend the title with "on 1sr run" because only 1st run is slow, 2nd run of
the same command is fast. Applies both to 7.3-oldest and 7.4-master.  

(Seems that 1st run was becoming more slow with newer LO, from 8 to 34 secs for
me. But I didn't check what's exported).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #17 from Caolán McNamara  ---
It is possible this is the same type of problem as bug 137571 and relating also
to bug 123470 If the problem exists in trunk right now it is possible that
deploying the same fix of an ActionGuard in the right place (as used for bug
137571) could be useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #16 from Julien Nabet  ---
(In reply to Mike Kaganski from comment #15)
> (In reply to Julien Nabet from comment #14)
> 
> Thank you!
> The flamegraph shows clearly why this is Linux-specific. It spends a huge
> amount of time in fontconfig called from psp::PrintFontManager::Substitute;
> so it looks like missing font issue, caching issue, and maybe fontconfig
> performance issue at the same time. But I'm just speculating :)...

No pb! Retrieving a Flamegraph is quite easy and requires not much time so
don't hesitate to ask if it can help Of course, it's useless to systematically
retrieve a Flamegraph for all perf bugs if nobody gives it a look in the
following days/weeks since the code may have changed more or less in the
meantime. But knowing Caolán's reactivity, I suppose there'll be no pb for this
one! :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Mike Kaganski  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #15 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #14)

Thank you!
The flamegraph shows clearly why this is Linux-specific. It spends a huge
amount of time in fontconfig called from psp::PrintFontManager::Substitute; so
it looks like missing font issue, caching issue, and maybe fontconfig
performance issue at the same time. But I'm just speculating :)

Caolan: maybe you have an idea how to deal with this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #14 from Julien Nabet  ---
Created attachment 178537
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178537=edit
Flamegraph

Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated
today (02caa6e40cfa55d96befc82515b343045b5cfd7b) + gen rendering.
(file used: list-custom-100.pptx)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Xisco Faulí  changed:

   What|Removed |Added

Version|7.3.0.3 release |7.0 all versions

--- Comment #13 from Xisco Faulí  ---
it takes

real0m15,736s
user0m15,404s
sys 0m0,224s

in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 0723b41bed9bb4ad50d2993744a60177966d1a21
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

and

Version: 6.4.0.0.alpha1+
Build ID: 9bc848cf0d301aa57eabcffa101a1cf87bad6470
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; 
Locale: es-ES (es_ES.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Xisco Faulí  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #12 from Xisco Faulí  ---
@Julien, any chance you could get a perf graph here ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #11 from Pablo  ---
Tested on Ubuntu 20.04 running LibreOffice 7.3.0.3

time libreoffice --headless --convert-to odp list-100.pptx
2.712s

time libreoffice --headless --convert-to odp list-custom-100.pptx
14.603s

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #10 from Pablo  ---
Created attachment 178524
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178524=edit
List with custom style (100 slides)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #9 from Pablo  ---
Created attachment 178523
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178523=edit
List with default style (100 slides)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #8 from Xisco Faulí  ---
(In reply to Xisco Faulí from comment #5)
> (In reply to Pablo from comment #4)
> > An order of magnitude difference for converting a single slide with a simple
> > list is huge.
> > I'm converting presentations with hundreds of slides that have lists with
> > custom styles. When you multiply 2 seconds by 100 slides it adds up to
> > minutes.
> 
> Please, attach such a file then

Jut to be clear, the reason why I'm asking for the file is to check whether the
affirmations "When you multiply 2 seconds by 100 slides it adds up to minutes"
and "10 times slower" are true or not with larger files.
Besides,  when working on a performance issue, it's easier to see the
improvements when the differences are longer than just a few seconds.
So, if you have some time, could you please create the file and attach it ?
Thanks in advance

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #7 from Mike Kaganski  ---
Note: I can't see the difference in times when testing on Windows (with or
without background instance).

Without the background instance, the difference on Ubuntu is ~4.6 vs 8 s - so
the difference here is similar in absolute numbers; startup/shutdown make it
relatively less prominent.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #6 from Mike Kaganski  ---
Repro: when you have LibreOffice running on background, running these two
commands

> time libreoffice --convert-to odp list-custom.pptx
> time libreoffice --convert-to odp list.pptx

gives on my Ubuntu 20.4 ~4.9 s vs 0.39 s (using 7.3.0.3 from PPA).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Pablo  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Xisco Faulí  ---
(In reply to Pablo from comment #4)
> An order of magnitude difference for converting a single slide with a simple
> list is huge.
> I'm converting presentations with hundreds of slides that have lists with
> custom styles. When you multiply 2 seconds by 100 slides it adds up to
> minutes.

Please, attach such a file then

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Pablo  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #4 from Pablo  ---
An order of magnitude difference for converting a single slide with a simple
list is huge.
I'm converting presentations with hundreds of slides that have lists with
custom styles. When you multiply 2 seconds by 100 slides it adds up to minutes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org

--- Comment #3 from Xisco Faulí  ---
IMHO, this is not an issue. Even if it's 10 times slower, you are comparing 0.2
seconds versus 2 seconds. Where is the issue there ? 2 seconds is more than
acceptable

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #2 from Pablo  ---
Created attachment 178141
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178141=edit
List with default style

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147283] [FILEOPEN PPTX] list with custom style is 10 times slower

2022-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147283

--- Comment #1 from Pablo  ---
Created attachment 178140
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178140=edit
List with custom style

-- 
You are receiving this mail because:
You are the assignee for the bug.