[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #16 from Commit Notification --- ektagoel12 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/841ab19fb3f68dbab6295459ef11a257f0f022e8 tdf#147906 Use std::hypot for Pythagorean addition It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #15 from Commit Notification --- Leonid Ryzhov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1b44a4c558fdf597bf66c1c671248ca58e145e9e tdf#147906 Use std::hypot for Pythagorean addition It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 reviewed:2022 |target:7.4.0 reviewed:2022 |target:7.5.0|target:7.5.0 target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #14 from Commit Notification --- Bogdan B committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5b18eebc2c95321ce7e6edf10f4df81557382a48 tdf#147906 used std::hypot for Pythagorean addition It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #13 from Commit Notification --- Bogdan B committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6bf5dd8faea420aa0dbc7c429952c9868bcadb9e tdf#147906 used std::hypot for Pythagorean addition It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #12 from Commit Notification --- Bogdan B committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1e9ace4c35e4206c24ded230433915850a1f04d1 tdf#147906 used std::hypot for Pythagorean addition It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #11 from Commit Notification --- OmkarAcharekar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bcf09f9a9bde21aac1302cbead2b23822458 tdf#147906 Use std::hypot for Pythagorean addition It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #10 from Commit Notification --- Aleksa Savic committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/519dae19abddaedaf0d3d109186eeb4a08471a92 tdf#147906 Use std::hypot for Pythagorean addition It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 reviewed:2022 |target:7.4.0 reviewed:2022 ||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Hossein changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 reviewed:2022 --- Comment #9 from Hossein --- Re-evaluating the EasyHack in 2022 This issue is still relevant, as there are many places in the code that a Pythagorean addition is done, and std::hypot can be used instead. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #8 from Commit Notification --- pragat-pandya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a31aadb1ef7dfdd4ae76a15707ab51a82c95d868 tdf#147906 Use std::hypot for Pythagorean addition It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #7 from Hossein --- (In reply to Libreoffice user SSO from comment #6) > At core/filter/source/svg/svgwriter.cxx:304 "const doublefRadius = sqrt( > static_cast< double >( rObjRect.GetWidth() ) * rObjRect.GetWidth() + > rObjRect.GetHeight()*rObjRect.GetHeight() ) * 0.5;" > > Is it a candidate for changing it to: > "const double fRadius = std::hypot(rObjRect.GetWidth(), > rObjRect.GetHeight()) * 0.5" > > If yes, then why it's not letting me make a commit containing this lines of > code ? The change itself is OK, if you add ; in the end. Let's discuss this in the dev IRC. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #6 from Libreoffice user SSO --- At core/filter/source/svg/svgwriter.cxx:304 "const doublefRadius = sqrt( static_cast< double >( rObjRect.GetWidth() ) * rObjRect.GetWidth() + rObjRect.GetHeight()*rObjRect.GetHeight() ) * 0.5;" Is it a candidate for changing it to: "const double fRadius = std::hypot(rObjRect.GetWidth(), rObjRect.GetHeight()) * 0.5" If yes, then why it's not letting me make a commit containing this lines of code ? If no, Some explanations will be great :)!! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #5 from Commit Notification --- Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a2d49b680cd026c3d64683f6ee3ba97e9834a7f7 tdf#147906 change sqrt(a * a + b * b) occurences to std::hypot(a, b) It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Bartosz changed: What|Removed |Added CC||gan...@poczta.onet.pl --- Comment #4 from Bartosz --- It seems that std::hypot is much slower that square root: https://stackoverflow.com/questions/32435796/when-to-use-stdhypotx-y-over-stdsqrtxx-yy I am wondering if this change is worth implementing (possible performance drop). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #3 from Commit Notification --- offtkp committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ab9896bfda4d2ef16f3cbb373edced33f9021492 tdf#147906 change all sqrt(a * a + b * b) occurences to std::hypot(a, b) It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #2 from Commit Notification --- VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d0055ac076c61d24c505c2ffa4f99e36c97b1266 tdf#147906 Use std::hypot for Pythagorean addition It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 --- Comment #1 from Commit Notification --- Gautham Krishnan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/67fcd8f268fd04ca2012470af2257b394b77b8fc tdf#147906 used std::hypot for Pythagorean addition It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Aron Budea changed: What|Removed |Added Blocks||143781 CC||aron.bu...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition
https://bugs.documentfoundation.org/show_bug.cgi?id=147906 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
