[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #12 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/137013 will merge adjacent identical hyperlinks on save to ODF. Unfortunately, I found no easy way to get the true hyperlink boundaries at the level where ODF is exported; this means that with that change, it will be impossible to save two adjacent *but separate* identical links to ODF (they will merge on save - the opposite to what happens now). This has a nice (?) property to heal already incorrectly split hyperlinks (note that this will happen *on save*, so don't expect to see merged hyperlinks immediately opening old "broken" files in a new version with that change, when/if it gets merged). My hope is that having two adjacent fully identical hyperlinks would be highly unlikely scenario, much less frequent than having a single hyperlink consisting of differently formatted (or otherwise different internally) parts. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 --- Comment #11 from Mike Kaganski --- FTR: Opening attachment 181227 from bug 149949 in Writer gives a single hyperlink. Saving to ODT splits the hyperlink again; but saving to DOCX instead will keep a single hyperlink. It seems that the relevant DOCX changes were commits 46b6bad7db21f3743a26b328f23e5d66f8211bb8, 482cdf173eca106848672acfe4923faf4584b1a7, and f176c9ba7be7f3051a52b9f57b56124038c0cfd6. The related ODF export code is XMLTextParagraphExport::exportTextRange in xmloff/source/text/txtparae.cxx. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 --- Comment #10 from phv --- Since the bug report #149949 is a duplicate of this one, I want to bring my own experience. In my case, the comparison option is disabled and multiple character styles are previously applied to the hyperlink, resulting in a subdivision of this same link when saving. As explain in my bug report, Word manages to save the same document in odt format without subdividing the link by character style. Once saved in Word and reopened in Writer, the document still displays a single link with several character styles. Two test documents are actually attached to the above-mentioned report. While Writer behavior does not affect the functionality of the document, it is unacceptable because a unique link that appears as such when it is saved should remain so. Altering the link without notification is overriding the user's work. The readability of the links in the navigator and their management are both strongly compromised. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=14 |tion.org/show_bug.cgi?id=13 |9949|0723 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added CC||regiv...@gmail.com --- Comment #9 from Mike Kaganski --- *** Bug 112429 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added CC||nicolas.mail...@laposte.net --- Comment #8 from Mike Kaganski --- *** Bug 99912 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 --- Comment #7 from Mike Kaganski --- *** Bug 149949 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 phv changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9949 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added Status|REOPENED|NEW --- Comment #6 from Mike Kaganski --- Likely we need do join the adjacent text runs with the same link address into single hyperlink. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added CC||libreoffice@phv.email --- Comment #5 from Mike Kaganski --- *** Bug 149949 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Jordi changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 --- Comment #4 from Jordi --- (In reply to Mike Kaganski from comment #2) > Or, rather, *if* I post the *exact* steps to repro, it is not a bug. > > 0. Make sure that in Options/Writer/Comparison, "Random number ... - [x] > Store it when changing the document" is *checked*. > 1. Create a hyperlink (using Ctrl+K "Insert->Hyperlink" dialog). > 2. Save the document *and reload it*. > 3. Edit the text of the hyperlink by typing inside the text in Writer's main > window (not thorough the dialog). > => At this stage the macros show three links. > 4. Save and reload > => At this stage, Navigator also shows three links. > > The reason is that the random number (checked at step 0, and used to make > document comparison more robust and useful) creates a new property in the > inserted text run, which makes the previously single text run with hyperlink > three new runs - first without the random number, then second with the > random number, then the third without. Every separate text run is an own > hyperlink (from the code point of view). > Possible bug is that Navigator is not updated after step 3 properly. > > Possible enhancement would be to use nested text runs, instead of > non-nesting, side-by-side runs as created now. > > (In reply to Jordi from comment #0) > > Version 3 of LO doesnt have this issue, it was introduced in v4 > > It was introduced in > https://git.libreoffice.org/core/+/062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c > in 2011 (for version 3.6); then it was made optional in version 5.0 [1]. > > [1] https://wiki.documentfoundation.org/ReleaseNotes/5.0#Optional_RSIDs. Just installed latest version, Version: 7.3.2.2 (x64) / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-AU (en_AU); UI: en-GB Calc: CL with the same behaviour. Option also checked. I am fail to see how this is expected behaviour and NOT a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 --- Comment #3 from Jordi --- Mike, my clean install of 7.2.6.2 (Win10 x64), under Options/Writer/Comparison, "Random number ...", the first two options are disabled (grayed out) and the "[x] Store it when changing the document" is INDEED *checked*. So given the above, I see a bug either way. Either #1 below is a bug or #2 1) editing the text of a link in Writer's main windows shouldn't break up a link into multiple. 2) Navigator is not updated to reflect what is happening if #1 is not a bug (which it has to be; otherwise its the strangest behaviour) Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #2 from Mike Kaganski --- Or, rather, *if* I post the *exact* steps to repro, it is not a bug. 0. Make sure that in Options/Writer/Comparison, "Random number ... - [x] Store it when changing the document" is *checked*. 1. Create a hyperlink (using Ctrl+K "Insert->Hyperlink" dialog). 2. Save the document *and reload it*. 3. Edit the text of the hyperlink by typing inside the text in Writer's main window (not thorough the dialog). => At this stage the macros show three links. 4. Save and reload => At this stage, Navigator also shows three links. The reason is that the random number (checked at step 0, and used to make document comparison more robust and useful) creates a new property in the inserted text run, which makes the previously single text run with hyperlink three new runs - first without the random number, then second with the random number, then the third without. Every separate text run is an own hyperlink (from the code point of view). Possible bug is that Navigator is not updated after step 3 properly. Possible enhancement would be to use nested text runs, instead of non-nesting, side-by-side runs as created now. (In reply to Jordi from comment #0) > Version 3 of LO doesnt have this issue, it was introduced in v4 It was introduced in https://git.libreoffice.org/core/+/062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c in 2011 (for version 3.6); then it was made optional in version 5.0 [1]. [1] https://wiki.documentfoundation.org/ReleaseNotes/5.0#Optional_RSIDs. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148198] Editing single hyperlink breaks it into smaller ones
https://bugs.documentfoundation.org/show_bug.cgi?id=148198 --- Comment #1 from Mike Kaganski --- No repro using Version: 7.3.2.2 (x64) / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: -- You are receiving this mail because: You are the assignee for the bug.
