[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #4 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e4f53484d255f844169957c411dc3e872af7d3bb

tdf#148413: Drop HTML export encoding configuration; use UTF-8

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #3 from Michael Stahl (allotropia)  ---
yeah let's just use UTF-8 to export, i can't imagine why anybody would want
anything else these days

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #2 from Mike Kaganski  ---
Created attachment 179340
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179340=edit
Screenshot of the related options page.

In comment 1, #2 (officecfg.Office.Common/Filter/HTML/Export/Encoding
configuration) is defined in Options->Load/Save-?HTML Compatibility. The
workaround is to set UTF-8 there manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #1 from Mike Kaganski  ---
Relevant:

1. SwHTMLWriter::WriteStream [1], which initializes m_eDestEnc using
SvxHtmlOptions::GetTextEncoding [2];
2. officecfg.Office.Common/Filter/HTML/Export/Encoding configuration value,
which is void by default, and is not editable until commit
7c5ca44c48b05ba73defd48057a82db7dc833e0c [3];
3. Thread encoding, used in SvtSysLocale::GetBestMimeEncoding [4], which is
~always non-UTF-8 on Windows;
4. HtmlWriter::attribute [5], using fixed UTF-8 encoding, and so unsynchronized
with #1;
5. Other places that write strings (like HtmlWriterHelper::applyColor [6],
which is used in Writer's HTML filter), which also use UTF-8 unconditionally.

It seems that the best option would be to use UTF-8 unconditionally in #1, and
just drop (ignore) #2 and #3.

[1]
https://opengrok.libreoffice.org/xref/core/sw/source/filter/html/wrthtml.cxx?r=5de24375#342
[2]
https://opengrok.libreoffice.org/xref/core/svtools/source/config/htmlcfg.cxx?r=96e3a641#93
[3] https://git.libreoffice.org/core/+/7c5ca44c48b05ba73defd48057a82db7dc833e0c
[4]
https://opengrok.libreoffice.org/xref/core/unotools/source/misc/syslocale.cxx?r=55adeb1c#177
[5]
https://opengrok.libreoffice.org/xref/core/svtools/source/svhtml/HtmlWriter.cxx?r=ad1557f5#153
[6]
https://opengrok.libreoffice.org/xref/core/svtools/source/svhtml/htmlout.cxx?r=96e3a641#981

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

2022-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148413

Mike Kaganski  changed:

   What|Removed |Added

URL||https://forumooo.ru/index.p
   ||hp/topic,9106

-- 
You are receiving this mail because:
You are the assignee for the bug.