[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
Version|7.2.6.2 release |unspecified
 Resolution|--- |FIXED
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=20540
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #18 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d02962cb2ca4e691634abb1bf6ff30b9b366d2e3

tdf#148806 doc import: remove 2003 SetObjectShell(nullptr) hack

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-10-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #17 from Justin L  ---
(In reply to Justin L from comment #14)
> In LO, it fails at forms/source/misc/InterfaceContainer.cxx:119
In the working case, we have parents
uno::Reference to (frm::ODatabaseForm *)
uno::Reference to (frm::OFormsCollection *)  // ends here on RT import
uno::Reference to (SwXTextDocument *)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-10-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #16 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/acc71c3e502f23daaf2489d102dda3b00a45960a

tdf#148806 sw vba: fix GetVbaEventProcessor

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #15 from Justin L  ---
> DOC round-trip losing macros:
This never worked for the checkboxes. ActiveX checkboxes were round-tripped as
FormField's until LO 6.0's commit b45446fcb4958b13bc94e70e2d3d1940db3322e2
Author: Tamás Zolnai on Tue Aug 22 23:40:56 2017 +0200
tdf#111975: Inline checkbox control's label is not saved to DOC format

This MiserableFormFieldExportHack lives from the beginning
of the git history:
7155b11b7eac65e242aca1efaf29ffcfa28f2564

So it might be a workaround of an old issue. By now when
the checkbox is not inline, but a floating one, it is exported
as ActiveX control, which works nicely. So just remove this
workaround and let the code export also inline checkboxes
as ActiveX controls.

Did it ever work for the button? On import, the macro got wired back up in LO
5.2 with commit 1f7a31a461bb3a6fcd277ab57875405875568f8b
Author: Stephan Bergmann on Tue May 10 10:08:35 2016 +0200
Missing break in switch

which was broken 5 years earlier with
commit 4fae740db79d4e7cc97440e2bab8d1ef612d9b51
Author: Noel Power on Fri Aug 12 00:36:51 2011 -0400
Disable fake VBA events for the old-style form controls.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #14 from Justin L  ---
A proposed patch for exposing document open/close/new to VBA macros is at
http://gerrit.libreoffice.org/c/core/+/140801

DOC round-trip losing macros:
I just want to confirm that MS Word handled the round-tripped file just fine.
In LO, it fails at forms/source/misc/InterfaceContainer.cxx:119
Reference< XModel > xDoc( getXModel( static_cast< XContainer *> ( this ) ) );
if ( !xDoc.is() )
break;  // ROUND-TRIPPED file hits this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #13 from Justin L  ---
DOCX: in terms of sending DOCUMENT OPEN to VBA, all the plumbing looks to be in
place. The only problem is an exception in 
mxVbaEvents.set( ooo::vba::createVBAUnoAPIServiceWithArgs(
   mpDocShell, "com.sun.star.script.vba.VBATextEventProcessor" , aArgs )
because no hasServiceName("com.sun.star.script.vba.VBATextEventProcessor")

Somehow we need this?
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
Writer_SwVbaEventsHelper_get_implementation(
css::uno::XComponentContext* context, css::uno::Sequence
const& args)
{
return cppu::acquire(new SwVbaEventsHelper(args, context));
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #12 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8253b8d6f1efb7fc3e2928d543c21a79c2cdc13f

tdf#148806 docm: fix vba macro events without ScriptCodes

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

--- Comment #11 from Justin L  ---
Created attachment 182687
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182687=edit
formfieldMacros.docm: macro on fileOpen, checkbox1 click

repro 7.5+
This is a FILEOPEN problem. Round-tripping this file still works fine in Excel.

DOC format is a bit better than this. At least on initial file-open the
checkbox1 and commandButton macros are working. LO doesn't work on a RT though.

DOCX format has never worked in LO. ActiveX support first came in LO 6.0 via
bug 50097, but event-macros were never working.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148806] FILEOPEN: Event-Driven Macros don't enable in DOCM, or after round-tripping in DOC

2022-09-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148806

Justin L  changed:

   What|Removed |Added

Summary|Event-Driven Macros don't   |FILEOPEN: Event-Driven
   |save if document saved in   |Macros don't enable in
   |Microsoft format|DOCM, or after
   ||round-tripping in DOC
   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.