[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #12 from Justin L --- The issue does not at all seem to be with numbering visibility: EE_PARA_BULLETSTATE[4017], aka NumberingIsNumber which has a SfxItemKind::StaticDefault of true (and so the numbering is hidden only if there is a property specifically hiding it.) The issue is always the mismatch of Para.GetDepth() and EE_PARA_OUTLLEVEL. Functions are setting Para Depth without providing a corresponding paragraph property. When the depth is -1 (the default), then no bullet is displayed. (In reply to Justin L from comment #10) > I figured that explicitly setting OUTLLEVEL when importing a NUMBULLET would > work Well, I was correct except that when I thought I was setting the property, the helper function only set the depth. So the PPTX fix is to change the helper to also fall back to the normal method of setting a property. This involved using the REAL EE_PARA_OUTLLEVEL instead of the fake WID_NUMLEVEL. http://gerrit.libreoffice.org/c/core/+/137569 For PPT, it is more easily done. http://gerrit.libreoffice.org/c/core/+/137543 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #11 from Justin L --- Oh great. It appears the reason "zero" doesn't work is because the depth is already zero - so it doesn't create a RES_PARA_OUTLLEVEL. I think the reason it loses the property is because WID_NUMLEVEL (PROP_NumberingLevel) is not considered a bParaAttrib because it is less than EE_PARA_START, and thus is easily thrown out. This stuff is ridiculously complex. I can "fix" it by forcing a full setDepth in Outliner::SetDepth() -if ( nNewDepth == pPara->GetDepth() ) - return; -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #10 from Justin L --- Based on my debugging, I figured that explicitly setting OUTLLEVEL when importing a NUMBULLET would work (oox/source/drawingml/textparagraphproperties.cxx). I was a bit surprised that it didn't work with a zero. However, it DOES work with a higher number. Zero should not be special. Either a void or a -1 is "special". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #9 from Justin L --- I noticed that "when it worked" it required TWO undo steps to get the bullet back, while only one undo is possible now. In debugging this, I see that ODP deletes two paragraph attributes (EE_PARA_OUTLLEVEL and EE_PARA_BULLETSTATE) while PPT deletes 8 attributes (including EE_PARA_NUMBULLET and EE_PARA_BULLETSTATE) Problem likely caused by commit 88c1c1fa45b6d25694ac805be5258ee7190d6dd6 Author: Rüdiger Timm on Fri Jun 6 11:29:34 2008 + where in editeng/source/editeng/editeng.cxx on a KEY_BACKSPACE we "hide" the BULLETSTATE before starting an undo. But it also is related to Outliner::ParaAttribsChanged. For some reason the level (despite being at para depth of 0) is never specified as an OUTLLEVEL property and thus is lost in this Outliner reset. And there is also an undo-related OutlinerUndoChangeDepth - so depth really has some funkiness to it... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Justin L changed: What|Removed |Added Keywords|regression | Summary|EDITING: Undo doesn't |EDITING: Undo doesn't |restore the bullet ( PPTX ) |restore the bullet ( ||PPTX/PPT ) Version|6.1 all versions|Inherited From OOo --- Comment #8 from Justin L --- The same problem occurs with PPT - already in LO 3.5 so assuming OOo inherited. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #7 from Justin L --- Tamás' commit is too "on target" to just be coincidence, but reverting all UndoManager stuff in this file doesn't "fix" the problem. I'd guess it just exposed some other abnormality. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Justin L changed: What|Removed |Added Version|7.0 all versions|6.1 all versions --- Comment #6 from Justin L --- Interesting - it was the opposite way around in 4.2 - 5.2. ODP was fixed in 5.3 (a missing screen redraw) by commit ee33745ced5ae12f9ae7735fac16a7298ccae474 Author: Noel Grandin on Mon Oct 24 14:12:12 2016 +0200 tdf#103334 - EDITING: Undo on bullet point style I have checked the normal model and the editing model after UNDO, and all seems to be well, this is purely a rendering/lack-of-invalidation issue. Confirmed that PPTX broke in 6.1 with comment 5's commit. Prior to that, an undo chain included: -rename shape -delete outline text (Click to add Text) -delete title text (Click to add Title) ... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com Blocks||107899 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107899 [Bug 107899] [META] PPTX paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 raal changed: What|Removed |Added CC||r...@post.cz, ||zolnaitamas2...@gmail.com Keywords|bibisectRequest |bibisected, bisected --- Comment #5 from raal --- This seems to have begun at the below commit. Adding Cc: to Tamás Zolnai; Could you possibly take a look at this one? Thanks 0c16af003f631594a0b58be9d066b5f14c4fc542 is the first bad commit commit 0c16af003f631594a0b58be9d066b5f14c4fc542 Author: Jenkins Build User Date: Fri Dec 22 08:56:22 2017 +0100 source sha:02ea9bc36ab47d68940da55f5012677dfaf0a8b8 https://git.libreoffice.org/core/+/02ea9bc36ab47d68940da55f5012677dfaf0a8b8 tdf#114613: Repair function does not work after opening PPTX file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Ezinne changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||nnamani.ezi...@collabora.co ||m --- Comment #4 from Ezinne --- Reproducible in: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 5453f75a1e682992f3a725781bb563b8cc76cf1b CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Xisco Faulí changed: What|Removed |Added Keywords||bibisectRequest, regression Version|7.4.0.0 alpha0+ Master |7.0 all versions --- Comment #3 from Xisco Faulí --- At least in Version: 6.0.0.0.alpha1+ Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: es-ES (es_ES.UTF-8); Calc: group threaded the bullet is restored after two undos. Setting as regression -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Created attachment 179791 --> https://bugs.documentfoundation.org/attachment.cgi?id=179791=edit ODP sample file ( good behaviour ) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #2 from Xisco Faulí --- Reproduced in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: f1dc51468137971295393ab438b57fe5f77c1420 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
