[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2023-05-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2023-05-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

--- Comment #7 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/92fe70072d16922af41ab0fd3746172f3a58e489

tdf#148956 sw: clear nAttrStart == paraEnd hints in DOCX

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2023-05-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2023-05-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

Justin L  changed:

   What|Removed |Added

Version|4.0.0.3 release |Inherited From OOo

--- Comment #6 from Justin L  ---
Using comment 5's example, and round-tripping it in 7.6, I bibisected with the
resulting file, and observed the same behaviour all the way back to OOo 3.3.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2022-06-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

--- Comment #5 from Aron Budea  ---
Created attachment 180952
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180952&action=edit
Sample ODT #2 (see comment 5)

(In reply to Justin L from comment #4)
> No big surprise here. Heading formats are (almost by definition) numbering
> formats, and exporting numbering spams direct formatting all over the place.
> There are various places in DOCX export where style formatting needs to be
> spammed as direct formatting in order to emulate things.
If that was causing the problem here, my expectation would be that unexpected
direct formatting gets removed as well, not that it persists regardless, which
is kind of the opposite.

But anyway, here's a sample, see the second paragraph (line), formatted with a
new style derived from Text Body, and having additional direct formatting.

Steps:
- Save ODT as DOCX, and reload DOCX,
- Select the second line, and press Ctrl + M to clear direct formatting,
- Unselect, and press Enter at the end of the line,
- Type a few characters.

=> The characters have direct formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2022-06-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

--- Comment #4 from Justin L  ---
No big surprise here. Heading formats are (almost by definition) numbering
formats, and exporting numbering spams direct formatting all over the place.
There are various places in DOCX export where style formatting needs to be
spammed as direct formatting in order to emulate things.

To make this a real bug, can you reproduce with a "normal" style that is not
part of chapter numbering, or contain any numbering aspect?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2022-05-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
  Regression By||Pierre-Eric Pelloux-Prayer

--- Comment #3 from Aron Budea  ---
(In reply to Aron Budea from comment #0)
> In 4.1.0.4 and 4.3.0.4, when pressing enter after clearing formatting, the
> Next style setting isn't honored, and Heading 2 style is kept, including the
> direct formatting.
> In 4.0.0.3, when pressing enter after clearing formatting, the Next style
> setting isn't honored, and Heading 2 style is kept, but direct formatting is
> gone.
Bibisected the second change between 4.0 and 4.1 to the following two
consecutive commits (the earlier failed to build) using repo bibisect-41max.

> Let's say you want to get rid of the direct formatting in the heading:
> select the first line, and press Ctrl + M, then unselect, press Enter at the
> end of the line, and type a few characters.
A significant change with these commits is that when performing the steps
listed above (note: start with saving ODT as DOCX and reloading), when you've
moved to the end of line after clearing direct formatting, at that position the
direct formatting is still there.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8c178a50334109b34ef456ca6aa51cd3d98699ae
author  Pierre-Eric Pelloux-Prayer 
2013-01-11 14:38:12 +0100
committer   Noel Power 2013-01-14 15:50:07
+

"docx export: also export rPr in  (paragraph mark styling)"

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2c079dd2bc9a2f5aa3597a8222bde3073a04da
author  Pierre-Eric Pelloux-Prayer 
2013-01-11 14:34:04 +0100
committer   Noel Power 2013-01-14 15:51:14
+

"sax: add methods to duplicate current top marker and reapply it later"

I'd assume this bug mainly has to do with the way these paragraph mark stylings
are handled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2022-05-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
(In reply to Aron Budea from comment #0)
> In 4.0.0.3, when pressing enter after clearing formatting, the Next style
> setting isn't honored, and Heading 2 style is kept, but direct formatting is
> gone.
> In 3.6.0.4 it behaves as expected. => regression
Bibisected the first change to the following range using repo bibisect-43all:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=37b9e290d9e3d20652df0abe1a1458412f3cfe2c..c3aa1cefdc6521d34a2a32c20bae1593e1edb5ba

Possibly one of Cedric Bosdonnat's changes from bug 53175.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers

2022-05-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148956

--- Comment #1 from Aron Budea  ---
Created attachment 179956
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179956&action=edit
Original sample ODT

-- 
You are receiving this mail because:
You are the assignee for the bug.