[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 BogdanB changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9486 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #12 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/a3d1ace9e8a36820acef3b9d2a02e4b3c304d455 tdf#149485: Revert "tdf#142450 add code to store showing whitespace" It will be available in 7.4.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0 target:7.5.3 |target:7.6.0 target:7.5.3 ||target:7.4.7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0|target:7.6.0 target:7.5.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 Xisco Faulí changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #10 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b09df066497fecc66b51af9094914e46e7a87176 tdf#149485: Revert "tdf#142450 add code to store showing whitespace" It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #9 from Xisco Faulí --- (In reply to Dhiraj Holden from comment #8) > I'll see if I can take a look but I'm busy and don't have the build set up > on my computer right now. Ok, no problem. I decided to revert the patch for now so it can be backported to previous branches -> https://gerrit.libreoffice.org/c/core/+/149541 Anyway, it would be great if you could take a look at it whenever you have some time. Thanks in advance -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #8 from Dhiraj Holden --- I'll see if I can take a look but I'm busy and don't have the build set up on my computer right now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #7 from Mike Kaganski --- (In reply to Xisco Faulí from comment #6) It depends on the severity of the problem. Ideally, it would be best if it is investigated and fixed; possibly, Dhiraj Holden could take a look? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #6 from Xisco Faulí --- (In reply to Mike Kaganski from comment #5) > (In reply to Heiko Tietze from comment #4) > > I'm sorry, but as far as I can tell, this bug report is in complete > agreement with my argument there: it tells that it is *wrong* when you > define the option for one document, but it affects other documents! I told > the same, telling that we should only limit the effect of the option to one > specific document where it's configured and stored. > > So this report only tells that this idea (limiting the effect to only one > document) was not implemented correctly. Hi Mike, Do you think the commit should be reverted ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #5 from Mike Kaganski --- (In reply to Heiko Tietze from comment #4) I'm sorry, but as far as I can tell, this bug report is in complete agreement with my argument there: it tells that it is *wrong* when you define the option for one document, but it affects other documents! I told the same, telling that we should only limit the effect of the option to one specific document where it's configured and stored. So this report only tells that this idea (limiting the effect to only one document) was not implemented correctly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #4 from Heiko Tietze --- Mike's argument in bug 142450 comment 15 was to align the white space with single-page layout (to not interfere if one is on and the other off), and to save the option therefor with the document rather than on the workplace. As a compromise I could imagine we check both similar to the last position when the document was saved. Plus, we must not overwrite the default that is used for new documents; the option could become a tristate if read and changed from document. In the end it's cumbersome to save the option with the document. Perhaps Mike can change his mind. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 Stéphane Guillou (stragu) changed: What|Removed |Added CC||dhiraj.hol...@gmail.com, ||heiko.tietze@documentfounda ||tion.org, ||mikekagan...@hotmail.com, ||stephane.guillou@libreoffic ||e.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2450 Priority|medium |high Keywords||implementationError Blocks||146315 --- Comment #3 from Stéphane Guillou (stragu) --- I was about to report the same thing. This is since: commit 5b07acbf3345918f450fccf7ee243ad5bcb3fd67 author Dhiraj Holden Tue Dec 07 08:16:59 2021 -0500 committer Mike Kaganski Mon Jan 17 07:33:18 2022 +0100 tdf#142450 add code to store showing whitespace I have put in code to store the option to show whitespace. This option is stored at the document level like the other layout options. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126497 I would call it an implementation error. Now, if your preferred setting is to show whitespace (the default setting when starting with a fresh profile), it will be overwritten if you happen to open someone's document that has "show whitespace" off. Meaning all further Writer sessions will start with whitespace off. And vice-versa. So it has two consequences: - the in-document setting overwrites the user default for new documents - the in-document setting will "leak" into existing documents if they don't have that property set already (i.e. documents created before LO 7.4) In my opinion, this new feature should better differentiate between (1) the imported document property and (2) the setting changed by user action. Marking as "high" priority because it silently modifies existing documents. Heiko and Mike, adding you as you participated in the discussion. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146315 [Bug 146315] [META] Show/Hide Whitespace bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 NISZ LibreOffice Team changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords||filter:odt Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #2 from NISZ LibreOffice Team --- Created attachment 180629 --> https://bugs.documentfoundation.org/attachment.cgi?id=180629=edit Comparing the files look -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149485] "Show Whitespace" condition changes other documents look
https://bugs.documentfoundation.org/show_bug.cgi?id=149485 --- Comment #1 from NISZ LibreOffice Team --- Created attachment 180628 --> https://bugs.documentfoundation.org/attachment.cgi?id=180628=edit Test file which show whitespace (You can see the margins.) -- You are receiving this mail because: You are the assignee for the bug.
