[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2023-01-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.3.5.2 release |Inherited From OOo
 Status|RESOLVED|VERIFIED

--- Comment #24 from Stéphane Guillou (stragu) 
 ---
Fix verified in:

Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Issue was already in OOo 3.3.

Thanks everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Eike Rathke  changed:

   What|Removed |Added

 Resolution|WONTFIX |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #23 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c23c209a063273fda0670203bfbe3bf8ed6eb249

Resolves: tdf#150271 Further error checks of conditional formatting expression

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #22 from Eike Rathke  ---
(In reply to Heiko Tietze from comment #14)
> I believe an input field tells the user that it simply accepts text. Any
> restriction to numbers, dates etc. should have an indicator, if the input is
> processed it needs some kind of feedback like good/bad. But how should
> anyone know that entering an equation is possible and the result is being
> used? And for what purpose is that complexity good for?
? There are enough cases in the wild where a condition evaluates against a
formula expression, and if it's only to compare against the calculation of some
neighbouring cells.


> Anyway, we discussed the topic in the design meeting and follow Eike's
> suggestion to resolve WF.
I did not suggest to resolve this as WF.

I'm implementing a better check on the input expression that will clarify error
conditions, without modifying the UI any further.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #21 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/071fc970cd1deb326a30b667bd26c843890d97ad

Related: tdf#150271 Adjust unquoted string message to reality

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #20 from Eike Rathke  ---
(In reply to Eike Rathke from comment #13)
> An additional check probably could test the compilation result of the
> formula expression, but you don't want that for every key pressed..
We actually do that already, good; that probably should use the non-permissive
more errors catching (instead of leaving that to the interpreter later) mode
though and fine tune result conditions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition (see comment 13)

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Heiko Tietze  changed:

   What|Removed |Added

Summary|[UI][RFE] clearly visible   |[UI][RFE] clearly visible
   |hint or tooltip when|hint or tooltip when
   |entering a non-number   |entering a non-number
   |Conditional Formatting  |Conditional Formatting
   |condition   |condition (see comment 13)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #19 from Piotr Osada  ---
Created attachment 182153
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182153=edit
16 formula

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #18 from Piotr Osada  ---
Created attachment 182152
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182152=edit
15 proposition of hints

Suggestions in the sketch in image 15:

1 * Field names on mouseover would be the easiest improvement. Although it does
not bring much to the topic.

2 * A cheat sheet activated with a button next to the condition value field
would help users in most cases.

3 * Formula validation could be a very helpful function to enter code. And this
function could be adapted here as a general tool for displaying hints and
checking correctness of typing a formula. What would be appreciated when typing
formulas into cells in a spreadsheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #17 from Piotr Osada  ---
The rules of highlighting shown in photos 12 and 13 look like an inconsistency.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #16 from Piotr Osada  ---
Created attachment 182151
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182151=edit
13 lack of opening quotation mark

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #15 from Piotr Osada  ---
Created attachment 182150
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182150=edit
12 lack of exiting quotation mark

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #14 from Heiko Tietze  ---
I believe an input field tells the user that it simply accepts text. Any
restriction to numbers, dates etc. should have an indicator, if the input is
processed it needs some kind of feedback like good/bad. But how should anyone
know that entering an equation is possible and the result is being used? And
for what purpose is that complexity good for?

Anyway, we discussed the topic in the design meeting and follow Eike's
suggestion to resolve WF. We have top accept corner cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-08-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

--- Comment #13 from Eike Rathke  ---
The message "Strings without quotes are interpreted as column/row labels" is
nonsense anyway. Strings without quotes are interpreted as whatever the formula
expression context evaluates them to, that *may* be column/row labels, or cell
references or named ranges or named expressions or database range names, ...
i.e. the warning goes away if input is completed to such valid expression.

The important part is that if one wants to compare against a literal string
then one has to enclose the text in double quotes, as in any formula
expression.

Entering a single + character is just the same as entering  =+  as cell formula
(which if closed evaluates to Err:520 syntactical error).

An additional check probably could test the compilation result of the formula
expression, but you don't want that for every key pressed..

Furthermore there are errors that are detected only by the interpreter and can
be even position dependent, which comes into play if the conditional format is
copied around. There's not much that can be done there except interpreting the
formula expression once *on the position where it is defined* when entering it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-08-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0448
   Keywords||needsDevAdvice
 CC||andreas.heini...@yahoo.de,
   ||er...@redhat.com

--- Comment #12 from Heiko Tietze  ---
First of all I wonder how the plus sign is being interpreted since other
alphanumeric characters show the static tip. So we could improve the situation
by accepting the + sign. However, since curly brackets tell me "invalid value"
unless it has a closing pendant I suspect it's possible to do some magic here.
=> needsDevAdvice

What also comes in mind is to have a special condition for the column labels.
Currently it's a "cell value" and it could be "column label" (and we take
everything which is not a number as string).

And last but not least I think the preview should give some feedback on the
proper input. As discussed in bug 150448 we want to replace the list value of
values by the static label "This is a preview" and it could be "No valid input"
if the entered value is unclear.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150271] [UI][RFE] clearly visible hint or tooltip when entering a non-number Conditional Formatting condition

2022-08-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150271

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

  Component|Calc|UI
 Status|UNCONFIRMED |NEW
   Keywords||needsUXEval
 Blocks||116222
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Summary|[UI//UX enhancement]|[UI][RFE] clearly visible
   |clearly visible hint or |hint or tooltip when
   |tooltip when entering a |entering a non-number
   |Conditional Formatting  |Conditional Formatting
   |condition   |condition

--- Comment #11 from Roman Kuznetsov <79045_79...@mail.ru> ---
I agree this is a terrible situation, and I see some variants here:

1. Don't touch the attention phrase "Strings without quotes are interpreted as
column/row labels" but add all symbols except numbers to condition for it
displaying into source code

2. In addition to p.1 to highlight the label "Strings without quotes are
interpreted as column/row labels" with yellow color for example

3. Delete the label "Strings without quotes are interpreted as column/row
labels" and create some tooltip for field as Piotr suggest

UX-team, here is a task for you =)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116222
[Bug 116222] [META] Edit conditional formatting dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.