[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab (differently wrong in gtk3 and gen)

2022-08-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

Justin L  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab (differently wrong in gtk3 and gen)

2022-08-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

--- Comment #5 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a8ae24a8bd7bfffa75af9d0dc50765d51df9c720

tdf#150278: avoid gen/gtk3 difference in m_xPropBox->GetCurPage()

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab (differently wrong in gtk3 and gen)

2022-08-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

--- Comment #4 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6161b951c246125caf3efc009def0faf7caccc75

tdf#150278 sfx2: use provided aInfo, not factory

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab (differently wrong in gtk3 and gen)

2022-08-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab (differently wrong in gtk3 and gen)

2022-08-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=81
   ||293
Summary|Form control Property   |Form control Property
   |Browser dialog doesn't  |Browser dialog doesn't
   |remember last used tab  |remember last used tab
   ||(differently wrong in gtk3
   ||and gen)

--- Comment #3 from Justin L  ---
It looks like APP same revolutionary fix as MOD from Noel's bug 81293.

Proposed fix at
http://gerrit.libreoffice.org/c/core/+/138002 tdf#150278 sfx2: use provided
aInfo, not factory

and

http://gerrit.libreoffice.org/c/core/+/138003 tdf#150278: avoid gen/gtk3
difference in m_xPropBox->GetCurPage()

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab

2022-08-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

--- Comment #2 from Justin L  ---
(In reply to Justin L from comment #1)
> It restores the second-last tab.
During runtime, that too was a gtk3-only thing that worked up until Noel's 7.3
patch. Now it is only true for document-exit-reload for gtk3. gen remembers the
last (not second last) on document-exit-reload.

So my guess was that this only worked earlier by accident, by
access-after-free.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab

2022-08-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150278

--- Comment #1 from Justin L  ---
(In reply to Justin L from comment #0)
(although something, somehow could affect which tab that actually was.)
It restores the second-last tab.
A.) switch to Data tab.
B.) switch to Events tab.
C.) close and reopen. It opens to the Data tab.

During the switch between tabs, getActivePage() still returns the exiting tab.
On close, it actually rebuilds (yes, rebuilds) the whole thing from scratch and
restores m_sLastValidPageSelection which never got updated to the final tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.