[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||needsDevAdvice --- Comment #6 from Stéphane Guillou (stragu) --- Thank you for the reply! That makes sense. Marking as New, and NeedsDevAdvice for what I assume is an easyhack. Also in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ec2f1d73936c9d8cee83c0887170e9ecb8f044ba CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 grofaty changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from grofaty --- @Stephane, sorry for late response. Your question: "Can you point to a dialog that applies the changes when the "Close" button is pressed?" I can't. That is not what I have been claiming. I am trying to say, there are two buttons: Close and Cancel. The effect of Close button in all cases I have described are always the same as Cancel button. If two buttons have the same effect, then I see no reason in one occasion to use Close and in another occasion to use Cancel. My point is, following the simplicity rule, one of the buttons (Close or Cancel) should be removed and only one of them be used. In majority of the programs there is Cancel button and to follow user familarity with user interface, we should follow the Cancel button. In example, you are referring to the Insert | Hyperlink. If we apply the logic: 1. In URL field type in some address like: www.test.com 2. Now lets follow what do the buttons: Reset, Apply, Close and OK perform. Reset: it clear all of the data fields. Just like selecting text in the fields and right click and Delete. Apply: Apply the setting (in this case insert hyperlink into the selected Calc cell) and leave the dialog open. OK: OK should always!!! mean exactly the same action as Apply (so inserting the hyperlink into the selected cell) and!!! additionally close the dialog. Close: In this case what happens, program executes Reset (cleaning all of the data in all of the fields) and closes the dialog. This is classical Cancel operation. Why? Because we lose the data we have manually typed into the URL field. Close in this case is incorrectly used, it should be Cancel button. Cancel means lose everything you have set in the dialog and perform no operation in the Calc cells. When does Close button make sense to be used instead of Cancel button? Close should be used if there is e.g. Delete button inside dialog and after we click the Delete, then action is finished, there is no way to Cancel Delete effect, in this case Close button is appropriate to indicate, we can't change our mind and cancel the option. For example if there is file dialog. We open file dialog, select file and we click on Delete button and so we deleted the file. In this case Cancel button can not be used any more because we have deleted the file and file is irreversible deleted. We can't use Cancel anymore, because we can't reverse the delete file action. The only option in this case would be Close button. The Close button means: There is no other action to be applied or there is no other action to be canceled, the only thing that can be done is close down the dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 Grobe changed: What|Removed |Added CC||regeirs.fo...@gmail.com --- Comment #4 from Grobe --- In 7.4.3.2 (Linux Fedora) there is still OK/Close instead of OK/Cancel. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 stragu changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stephane.guil...@member.fsf ||.org Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #3 from stragu --- I can see the Close button in: Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded It looks like most insertion and formatting dialogs have a "Cancel" button but there are also a few dialogs with a "Close" button. I'm not sure what the logic is behind picking one over the other. grofaty, can you point to a dialog that applies the changes when the "Close" button is pressed? For example, the Insert > Hyperlink dialog doesn't apply the changes if the Close button is pressed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 stragu changed: What|Removed |Added Blocks||150884 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150884 [Bug 150884] [META] Sparklines bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 --- Comment #2 from grofaty --- Created attachment 181907 --> https://bugs.documentfoundation.org/attachment.cgi?id=181907=edit sample_document.ods Sample document you can follow starting step 7. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150518] Sparkline dialogs have Close button instead of Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=150518 --- Comment #1 from grofaty --- Created attachment 181906 --> https://bugs.documentfoundation.org/attachment.cgi?id=181906=edit close_button.jpg Dialog image. -- You are receiving this mail because: You are the assignee for the bug.
