[Libreoffice-bugs] [Bug 152871] Editing Date/Time fields have an inverted fixed/variable order

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152871

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Verified fix in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec2f1d73936c9d8cee83c0887170e9ecb8f044ba
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Heiko!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152871] Editing Date/Time fields have an inverted fixed/variable order

2023-01-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152871

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Heiko Tietze  ---
Reverted in master and 7.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152871] Editing Date/Time fields have an inverted fixed/variable order

2023-01-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152871

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Thanks Heiko, happy for a revert.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152871] Editing Date/Time fields have an inverted fixed/variable order

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152871

--- Comment #2 from Heiko Tietze  ---
(In reply to Stéphane Guillou (stragu) from comment #1)
>(nSubType == DATE_VAR) ? 0 : FIXEDFLD

The complete function is Date|Time mod Fixed. Neither modifying
SwDateTimeSubType in sw/inc/fldbas.hxx nor exchanging SwDateSubFormat in
sw/inc/flddat.hxx solves the problem resp. introduces other. And since the
FIXEDFLD flag is used widely across the application I vote for reverting the
patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152871] Editing Date/Time fields have an inverted fixed/variable order

2023-01-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152871

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
  Regression By||Heiko Tietze
Version|unspecified |7.5.0.1 rc
 Ever confirmed|0   |1
   Keywords||bibisectNotNeeded

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
As mentioned in bug 139141, repro in:

Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

The fields are inserted correctly, and the name is displayed correctly in the
navigator. Only the highlighting in the Edit Fields dialog does not correspond
to what is being edited.

Maybe the issue has to do with the condition:

   (nSubType == DATE_VAR) ? 0 : FIXEDFLD

In both:

-
https://opengrok.libreoffice.org/xref/core/sw/source/ui/fldui/fldpage.cxx?r=85c2ed8d#179
-
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/fldui/fldmgr.cxx?r=16075474#964

-- 
You are receiving this mail because:
You are the assignee for the bug.