[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Julien Nabet  changed:

   What|Removed |Added

 Status|VERIFIED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Julien Nabet  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #8 from Julien Nabet  ---
I confirm it works, thank you Caolán!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

--- Comment #7 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/72a08a55791a1c17c0ec15b2ab5c7294c23e2831

tdf#152931 deref of moPenColor std::optional on launching writer

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

--- Comment #6 from Julien Nabet  ---
(In reply to Stéphane Guillou (stragu) from comment #5)
> Can't reproduce on Ubuntu 20.04 with a build that doesn't include the patch:
> 
> 
> Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052
> CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: threaded
> 
> Am I missing something?

Since it’s an assertion, you must have a debug build, is it your case?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Can't reproduce on Ubuntu 20.04 with a build that doesn't include the patch:


Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Am I missing something?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #4 from Julien Nabet  ---
Patch from Caolán here: https://gerrit.libreoffice.org/c/core/+/145180

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

--- Comment #3 from Julien Nabet  ---
of course, we can use this patch:
diff --git a/vcl/unx/generic/gdi/gdiimpl.cxx b/vcl/unx/generic/gdi/gdiimpl.cxx
index 4b3b128b7442..522162fe1b11 100644
--- a/vcl/unx/generic/gdi/gdiimpl.cxx
+++ b/vcl/unx/generic/gdi/gdiimpl.cxx
@@ -152,7 +152,8 @@ X11SalGraphicsImpl::~X11SalGraphicsImpl()

 void X11SalGraphicsImpl::Init()
 {
-mnPenPixel = mrParent.GetPixel( *moPenColor );
+if (moPenColor.has_value())
+mnPenPixel = mrParent.GetPixel( *moPenColor );
 mnBrushPixel = mrParent.GetPixel( *moBrushColor );
 }

but would prefer having some feedback because it might just a bandaid.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Julien Nabet  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #2 from Julien Nabet  ---
Noel: thought you might be interested in this one since it seems to be a
regression from:
89b1d41e0d2cd
use std::optional for SALCOLOR_NONE

instead of re-using an actual real color value, because it will totally
not work when I convert vcl to use alpha instead of transparency

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

--- Comment #1 from Julien Nabet  ---
Created attachment 184528
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184528=edit
bt with debug symbols

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152931] Assertion when launching LO (gen rendering only)

2023-01-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152931

Julien Nabet  changed:

   What|Removed |Added

Summary|Crash when launching LO |Assertion when launching LO
   |(gen rendering only)|(gen rendering only)

-- 
You are receiving this mail because:
You are the assignee for the bug.