[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

--- Comment #9 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #8)
> Table of Objects shows a different part of the UI with the string "Create
> From the Following Objects";
Implicit in the proposal in comment 2 was that "the Following Objects" should
be deleted from the section title for "Table of Objects"  (Given that a list of
objects are shown, there is little or no information value in "the Following
Objects").

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

--- Comment #8 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #2)
> Table of Objects   Create Table (of Objects) From

Table of Objects shows a different part of the UI with the string "Create From
the Following Objects"; either we change it into "Create Table of Objects From
the Following Objects" or in this case just "Create Table From the Following
Objects". In any case it has to be done directly in the UI file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicDesign
 CC||mentoring@documentfoundatio
   ||n.org

--- Comment #7 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #6)
> Maybe the other changes (radio buttons, the %s in Create, and moving "Show
> up to level") can be an EasyHack?

Yes, those are not too difficult. 

* Change "Create From" into "Create %s From" at
sw/uiconfig/swriter/ui/tocindexpage.ui (ideally with a comment for translators
that %s will be replaced by the type)
* add a string variable with the same name sw/inc/strings.hrc, eg.
SID_CREATEFROM
* add a weld::label to sw/source/uibase/inc/swuicnttab.hxx, eg. m_xCreateFromLB
* instantiate this label in sw/source/ui/index/cnttab.cxx SwTOXSelectTabPage()
(it is named label2 in the ui file)
* add to the TOXTypeHdl:
m_xCreateFromLB->set_label(SwResId(SID_CREATEFROM).replaceAll(%s,
m_xTypeLB->get_active_text())

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

--- Comment #6 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #5)
> So just the label... How about simply going with "Create %s From" and
> replacing %s by what is selected in the dropdown? 
Elegant -- and easier to maintain.

Including the "type" name with "Create From" should make the section's purpose
more explicit. 

> "User-Defined", which we could rename to "User-Defined Table".
Change "type" to "User-defined Index" 

I can make a patch to change:
"Chapter" to "Heading" 
"Evaluate up to level" to "Show up to level".
"Create Index or Table of Contents" to "Scope"
"User-defined" -> "User-defined index"
(and update help pages)

Maybe the other changes (radio buttons, the %s in Create, and moving "Show up
to level") can be an EasyHack?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |
 Status|UNCONFIRMED |NEW

--- Comment #5 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #2)
> In Type tab, select Type according to first column below. Second column
> shows what is proposed as the Section title that should replace the current
> "Create From".

So just the label... How about simply going with "Create %s From" and replacing
%s by what is selected in the dropdown? Only drawback I see is for
"User-Defined", which we could rename to "User-Defined Table".

OTOH, replacing the label by some other string is also not a big deal.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

--- Comment #4 from sdc.bla...@youmail.dk ---
(In reply to RGB from comment #3)
Thanks for this useful comment. Have known about the function, but your comment
has resulted in my first experiments.

> Notice that in recent versions partial TOCs will be build from the current
> heading level 
Just to be sure that I have interpreted "build from the current heading level"
correctly.

The partial index is created from the immediately prior heading in relation to
where the cursor is placed, and only indexes headings have a higher outline
level than the immediately prior heading, stopping at (and not including) a
subsequent heading that has the same outline level as the "prior heading".  (at
least that is what my experiments show)

> using the chapter option while on a level 3 heading
just to be sure:  "on a heading" means that the cursor is placed AFTER the
heading (not in/on the paragraph with a heading PS).

> (the index will show only level 4 and lower) 
depending on what is set in "Evaluate up to level"

> that mean that the "Chapter" label (that only refers to a level 1 heading) is 
> not valid anymore, it should be "Current heading level" or something like 
> that.
Good point!  Perhaps "Heading" is enough. 

Also this makes me realise that "Evaluate up to level" would benefit from being
called "Show up to level" (in line with bug 105628 for "Chapter No." in the
Entries tab)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

RGB  changed:

   What|Removed |Added

 CC||rgb.m...@gmail.com

--- Comment #3 from RGB  ---
(In reply to sdc.blanco from comment #0)
> 
> Scope (of ToC or Index)
> 
>   ( ) Entire Document
>   ( ) Chapter 
> 

Notice that in recent versions partial TOCs will be build from the current
heading level (for example, if using the chapter option while on a level 3
heading, the index will show only level 4 and lower) and that mean that the
"Chapter" label (that only refers to a level 1 heading) is not valid anymore,
it should be "Current heading level" or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

--- Comment #2 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #1)
> Don't get this
Fair enough.  Easier to explain now that "Scope" is not involved.

In Type tab, select Type according to first column below. Second column shows
what is proposed as the Section title that should replace the current "Create
From"

Select TypeCurrent "Create From" title should show
---

Table of Contents  Create Table of Context From

Table of Figures   Create Table (of Figures) From

Index of TablesCreate Index (of Tables) From

User-Defined   Create Index From

Table of Objects   Create Table (of Objects) From

Additional comments:

1. The parts in parentheses could possibly be dropped.
2. possibly "Index of Tables" -> "Table Index"  
   (probably "Table of Tables" did not work)
3. For Type "Table of Contents", the option
  Evaluate up to level []  also appears in the "Scope" section.
  I believe this option can be meaningfully placed underneath the 3
  options (Headings, Additional Styles, Index Marks) for the
  "Create Table of Contents From" section. Where the option would be
   indented (like the "Use level from source" option in the 
   Used-defined type)
4. This change should give a much cleaner interface. Instead of current
interface that is somewhat generic, proposal makes the section titles
appropriate and specific to its Type context, and draws attention to the
section that decides what to include in the index.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

--- Comment #1 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #0)
> Scope (of ToC or Index)
>   ( ) Entire Document
>   ( ) Chapter 

LGTM


> Create ToC From 
> 
>Evaluate up to level []  (underneath the 3 checkboxes)  
> 
> Create Table (of Figures) From
> 
> Create Index (of Tables) From
> 
> Create Index From (User-defined)
> 
> Create Table (of Objects) From

Don't get this, at least it does not match the current situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153770

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||122497
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122497
[Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.