[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de |desktop.org | CC|libreoffice-ux-advise@lists | |.freedesktop.org| --- Comment #11 from Heiko Tietze --- (In reply to cwendling from comment #10) > - should validate the dialog and perform the default action (likely, > Insert) *consistently* > - Insert should either *always* be active when there are > 0 matches in the > table, OR whenever the table gains focus and has > 0 matches The patch makes Insert active and does not close the dialog via Enter. > - should behave as it does... Tab iterates over Recent and Favorite Characters instead cursor lef/right. This should be addressed somehow. Michael, do you want to integrate this in the current patch? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 Michael Weghorn changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||9215 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #10 from cwendl...@hypra.fr --- FWIW, IMO what would be expected would be: - should validate the dialog and perform the default action (likely, Insert) *consistently* - Insert should either *always* be active when there are > 0 matches in the table, OR whenever the table gains focus and has > 0 matches - should behave as it does (cycle through UI elements with a fine-ish granularity, e.g. between buttons and such, but not individual table cells), but in the recent/favorite it should *probably* not cycle through each char (but like on the main table, go out of it) - Reason for not tabbing through the whole table is that it's a nightmare. Basically people through to get to the next useful control, having to a million times because there's many options is a huge pain. - should move around the table(s) content (current behavior seems alright, although in recent/favorite leaves the table (which is consistent as them probably not being tables but individual widgets Additionally: - Recent/favorite should probably be tables like the main one (which behaves fine) - Recent/favorite items should have proper names attached to them, as currently they are not accessible at all (the screen reader doesn't see a name, so can only tell the user it's a "drawing area") Note that the main issue currently is that Insert doesn't get enabled when the focus enters the table, but only when clicking, or using one of . (OP's #1) #3 is also confusing because doesn't behave consistently, and the user might even not realize the character has been entered, and activate Insert again. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #9 from V Stuart Foote --- Your right, Favorites and Recents came in on the SCD at 6.0 for GSOC 2017, but the navigation and Cursor (U,D,L,R) was not implemented for the Character bar, only mouse click. Split button came in at 7.0 IIRC. The move at 5.4 -> 6.0 dropped the edit bar, making the SCD *non-modal*. Bug 115477 remain open to restore--necessary for string picks (both mouse or keyboard) and for polyglot input when no IME is in use. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #8 from Stéphane Guillou (stragu) --- Correct me if I'm wrong, but I thought Heiko simply meant that leaving the character grid with a tab should have the last highlighted character selected (which is already the case for the grid, but not for Favourites and Recents). I agree with all proposed improvements, with consistent behaviour in the fill list, search results, recent characters and favorite characters. Looking at another dialog that could allow inserting several things: AutoText. In that dialog, clicking the Insert button, double-clicking an item, pressing the spacebar or return key all do the same thing: insert and close. The special character dialog is different in that a mouse action (double-click) can insert without closing, and there should be a way to do the same thing without the mouse. (Which in my opinion also means it should be non-modal, although I just saw Heiko had arguments against in bug 56301.) (In reply to V Stuart Foote from comment #7) > (In reply to Heiko Tietze from comment #4) > > Another aspect on this dialog is the favorite chars, where only tab is > > accepted to traverse through the content; arrow keys are ignored. One has to > > tab through all items to finally continue at the next control. > > > > This is a bug and a regression, needs bibisection. The Cursor movements > should move between elements on the Recents and Favorites bar (with same > selection options and accessible event triggers)--both in the SCD and on the > Split button. Linkage has changed as I'm pretty sure this worked correctly, > is bad at 7.3.7 (that I have immediately to hand). 6.0.0.3 already tabbed through all favourites. Not sure when Favourites were introduced. 5.4 didn't have favourites. (testing on Linux) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #7 from V Stuart Foote --- (In reply to Heiko Tietze from comment #4) My last NO was for an "accept per " action. > Another aspect on this dialog is the favorite chars, where only tab is > accepted to traverse through the content; arrow keys are ignored. One has to > tab through all items to finally continue at the next control. > This is a bug and a regression, needs bibisection. The Cursor movements should move between elements on the Recents and Favorites bar (with same selection options and accessible event triggers)--both in the SCD and on the Split button. Linkage has changed as I'm pretty sure this worked correctly, is bad at 7.3.7 (that I have immediately to hand). The or cursor takes the focus elsewhere but positions at the start of the character bar, Favorites or Recents. While or does not respond. So cursor not doing nothing, movement is just not correctly linked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #6 from V Stuart Foote --- (In reply to Heiko Tietze from comment #4) > Navigating in the table per tab is wrong. The "copy" search results © and ℗ > allow using left/right arrow, if the list is larger up/down work as well. > And Insert becomes enabled. > > So what we have to do is to accept a select per tab. > > Another aspect on this dialog is the favorite chars, where only tab is > accepted to traverse through the content; arrow keys are ignored. One has to > tab through all items to finally continue at the next control. > > Another a11y improvement for the dialog could be to add a label for the > character list so we have a mnemonic for quick access. Spoils the design a > bit, however. NO! The should continue to reposition in the UI. When in the character chart cursor *alone* should perform the movement--but the Insert button, along with the focus "accessible action" for sounding the character name must activate. This is the same as movements between the clustered elements of the SB. And core keyboard navigation of , , /, and cursor , and is *maintained* with appropriate focus events firing. What is wrong with the SCD is its "Insert" action while in the character chart UI is not correctly linked. As enhancement: a shortcut to directly place UI focus into the character chart would be helpful, as would a shortcut to place directly in the search field. Likewise as enhancement: differentiating action from action for completing the character pick via keyboard. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #5 from V Stuart Foote --- (In reply to Michael Weghorn from comment #3) > (In reply to Stéphane Guillou (stragu) from comment #2) > > I agree that the current situation needs improvement, at the very least > > allowing inserting directly from the search results with the keyboard, just > > like in the favourite list. > > > > Interestingly, back in 6.3, I was able to insert from the search results by > > using Space bar, then Enter (which would also close the dialog). Since 6.4, > > I can't do that. Some kind of regression along the way? > > Reading this, another idea might be to distinguish between space and Enter > key and have Enter key close the dialog in addition, as happens e.g. in the > Insert -> Hyperlink dialog, too, so maybe sth like this (but then > consistently for both, characters in the character table (like search > results) *and* the favorites/recently used ones), so: > > * space key inserts the character, but leaves the dialog open > * Enter inserts the character and closes the dialog > > (And still make putting focus into the search results make the "Insert" > button usable right away.) > What do you think? +1, differentiate action of (to perform the Insert leaving SCD open for subsequent picks) and (to perform the Insert and close the SCD). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #4 from Heiko Tietze --- Navigating in the table per tab is wrong. The "copy" search results © and ℗ allow using left/right arrow, if the list is larger up/down work as well. And Insert becomes enabled. So what we have to do is to accept a select per tab. Another aspect on this dialog is the favorite chars, where only tab is accepted to traverse through the content; arrow keys are ignored. One has to tab through all items to finally continue at the next control. Another a11y improvement for the dialog could be to add a label for the character list so we have a mnemonic for quick access. Spoils the design a bit, however. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 --- Comment #3 from Michael Weghorn --- (In reply to Stéphane Guillou (stragu) from comment #2) > I agree that the current situation needs improvement, at the very least > allowing inserting directly from the search results with the keyboard, just > like in the favourite list. > > Interestingly, back in 6.3, I was able to insert from the search results by > using Space bar, then Enter (which would also close the dialog). Since 6.4, > I can't do that. Some kind of regression along the way? Reading this, another idea might be to distinguish between space and Enter key and have Enter key close the dialog in addition, as happens e.g. in the Insert -> Hyperlink dialog, too, so maybe sth like this (but then consistently for both, characters in the character table (like search results) *and* the favorites/recently used ones), so: * space key inserts the character, but leaves the dialog open * Enter inserts the character and closes the dialog (And still make putting focus into the search results make the "Insert" button usable right away.) What do you think? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org Version|7.6.0.0 alpha0+ Master |6.4.7.2 release --- Comment #2 from Stéphane Guillou (stragu) --- I agree that the current situation needs improvement, at the very least allowing inserting directly from the search results with the keyboard, just like in the favourite list. Interestingly, back in 6.3, I was able to insert from the search results by using Space bar, then Enter (which would also close the dialog). Since 6.4, I can't do that. Some kind of regression along the way? Version: 6.3.6.2 Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Version: 6.4.7.2 Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 V Stuart Foote changed: What|Removed |Added Blocks||109232 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109232 [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153806] Improve keyboard interaction for Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153806 Michael Weghorn changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org, ||m.wegh...@posteo.de Keywords||needsUXEval --- Comment #1 from Michael Weghorn --- @Heiko: Any thoughts/opinion on this? (In reply to Michael Weghorn from comment #0) > Suggestion: > > * for example 1: enable the "Insert" key right when a character in the table > is selected using the Tab key > * insert currently focused character from the table when pressing the space > or Enter key, just as is the case for "Recent characters"/"Favorite > characters" as well Suggested Gerrit change implementing that behavior: https://gerrit.libreoffice.org/c/core/+/147657 -- You are receiving this mail because: You are the assignee for the bug.
