[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 --- Comment #12 from Rizal Muttaqin --- My proposal: Change the behavior. When detecting RTL content switch icons to proper icon files instead of flipping them and remove unnecessary RTL icons that resides in all RTL UI languages (Arabic, Hebrew, Parsi, Urdu). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 --- Comment #11 from Caolán McNamara --- Yes we currently use a different icon from a equivalent command for the other direction so we look for something that will appear flipped IIRC. In either case of the existing hackery or new proposal I don't think we currently take current context into account, only the UI mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 --- Comment #10 from Heiko Tietze --- (In reply to Caolán McNamara from comment #9) > We do have some places where we swap the images depending on RTL. But we mirror the existing image and do not use some special icon, right? The proposal is to have this opportunity. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 --- Comment #9 from Caolán McNamara --- We do have some places where we swap the images depending on RTL. But as far as I know we do it based on the UI language and not the "current" direction of text. So see: framework/source/fwe/xml/toolboxdocumenthandler.cxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/toolbox/weldutils.cxx sfx2/source/toolbox/weldutils.cxx and search for uno:ParaLeftToRight and see the swap to ParaRightToLeft (etc) when AllSettings::GetLayoutRTL is true and references to bug #39370 as an example. So I think it could be: a) An easy hack to at least centralize those existing different places into one piece of code so we have just one copy of the swapping image name logic b) Assuming that the current swapping images idea is a good thing, then the question is if we should be changing those images depending on the current language/direction context. Some competitive comparison might be helpful to find out there, what do other similar products do, or anything seen as "doing the right thing". We do have QueryState which decides if a given toolbox item is enabled/disabled etc in the current context. I could see us adding another thing that can be queried (Or maybe we already have one, isn't there some paragraph direction toolbox item somewhere, does that generally give a single result, or how does it handle ambiguity right now?) to get an answer for the RTL in the context that could be used to do this swapping basically dynamically instead of just the UI direction. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval |needsDevAdvice CC|libreoffice-ux-advise@lists |caolan.mcnamara@collabora.c |.freedesktop.org|om, ||heiko.tietze@documentfounda ||tion.org --- Comment #8 from Heiko Tietze --- Let's add RTL specific icons (in addition to the language specific). Caolan, easyhack or GSoC project? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 Hossein changed: What|Removed |Added Assignee|hoss...@libreoffice.org |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 Kurosh Tavassoli changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |hoss...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 Hossein changed: What|Removed |Added Assignee|hoss...@libreoffice.org |libreoffice-b...@lists.free ||desktop.org CC||hoss...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 Kurosh Tavassoli changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |hoss...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154450] Incorrect symbol for images in RTL languages
https://bugs.documentfoundation.org/show_bug.cgi?id=154450 --- Comment #1 from Kurosh Tavassoli --- Created attachment 186291 --> https://bugs.documentfoundation.org/attachment.cgi?id=186291=edit The bug indication -- You are receiving this mail because: You are the assignee for the bug.
