[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #15 from Patrick Luby  ---
OK. I am not very picky about HIG compliance (the "G" stands for "guidelines"
afterall) so I don't have any strong opinion about UI changes like this.

But after looking at Microsoft Excel's behavior, I can see how people might
find the "move to next left/right chunk of the formula" useful. Maybe the
UX/design committee needs to evaluate such a change?

I definitely won't implement any changes to the current behavior as I don't
know how or where to implement new behavior. My skills are mostly limited to
vcl and implementing I am having a very difficult time determine what would
need to get the Calc code behavior to change. So far, I have only found that
the toolbar cell editor and the "in place" editor within a cell have their own
implementations and the toolbar cell editor doesn't seem to respond to any
main.xcu changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #14 from Heiko Tietze  ---
(In reply to Patrick Luby from comment #13)
> Is copying Excel's behavior what we want? If yes, then we can close this bug.
If you ask me, we should do better than MSO. Consistency on the OS-level is
more important than to copycat MSO. Others may have different opinions. The
goal would be to make customization possible and and if users want to change
the default we should not hinder them.

If customization is not possible we better hide the command/s in the list
(AccelConfig/MenuConfig...).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #13 from Patrick Luby  ---
OK. So I now see what is happening. vcl is trying to dispatch
MOVE_TO_BEGIN_OF_LINE/MOVE_TO_END_OF_LINE events but when editing a cell, Calc
rejects those events so vcl retries dispatching the last native event and the
last event is the "untransformed" Command-Left/Right keys.

I launched Microsoft Excel (the unpaid Mac App Store version) and found that
Command-Left/Right in Excel move only a word at a time left or right. So, I now
suspect that Calc is rejecting these MOVE_TO_BEGIN_OF_LINE/MOVE_TO_END_OF_LINE
events on purpose so that LibreOffice has the same behavior when editing cells
as Microsoft Excel for macOS.

@Heiko Tietze I think we are back to the bug filer's original question: is
copying Excel's behavior what we want? If yes, then we can close this bug. But
if no, then let me know and I'll see if I can find the code that rejects these
events in Calc only.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #12 from Patrick Luby  ---
(In reply to Heiko Tietze from comment #11)
> So apparently not easy hackable.

I agree. What is interesting is that when editing text in Impress,
editeng/source/editeng/editeng.cxx is receiving
MOVE_TO_BEGIN_OF_LINE/MOVE_TO_END_OF_LINE key events when Command-Left/Right
are pressed.

But when editing a cell in Calc, the same code receives KEY_LEFT/KEY_RIGHT
events. I know that vcl is receiving native
MOVE_TO_BEGIN_OF_LINE/MOVE_TO_END_OF_LINE events so I will need to do more
debugging to find where the native MOVE_TO_BEGIN_OF_LINE/MOVE_TO_END_OF_LINE
events are converted to KEY_LEFT/KEY_RIGHT events.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|difficultyBeginner, |
   |easyHack, skillDesign,  |
   |topicUI |

--- Comment #11 from Heiko Tietze  ---
(In reply to Patrick Luby from comment #9)
> I did some experimenting ... But that throws and an exception and crashes 
> LibreOffice.
So apparently not easy hackable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #10 from Patrick Luby  ---
I forgot to mention that in Writer, Calc, and Impress, any Command-Left/Right
keys are being mapped to the following in
svtools/source/misc/acceleratorexecute.cxx so I am guessing that Calc is
overriding this mapping somewhere:

case css::awt::Key::MOVE_TO_BEGIN_OF_LINE:
return ".uno:GoToStartOfLine";
case css::awt::Key::MOVE_TO_END_OF_LINE:
return ".uno:GoToEndOfLine";

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #9 from Patrick Luby  ---
(In reply to Heiko Tietze from comment #4)
> We define for example
> 
> 
>
>I10N SHORTCUTS - NO TRANSLATE
>.uno:GoToPrevWord
>
> 
> 

I did some experimenting and replaced all of the "LEFT_MOD1" entries in
main.xcd with "MOVE_TO_BEGIN_OF_LINE" which is a key constant defined in
Key.idl. But that throws and an exception and crashes LibreOffice.

So, my guess at this point is that we don't have the ability to add handlers in
main.xcd for macOS' special "action" keys even though such keys are defined in
Key.idl.

Since Writer and Impress appear to move to the start or end of a line properly,
I will see if I can find how either of those modules handle the
MOVE_TO_BEGIN_OF_LINE and MOVE_TO_END_OF_LINE special keys.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #8 from Xisco Faulí  ---
(In reply to Heiko Tietze from comment #7)
> MacOS users have continuously switch from cmd+left, working on all/most
> other tools, to alt+left. Super annoying => high. Feel free to revert.

Feel free to revert what ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

eisa01  changed:

   What|Removed |Added

 CC||eis...@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5651

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #7 from Heiko Tietze  ---
MacOS users have continuously switch from cmd+left, working on all/most other
tools, to alt+left. Super annoying => high. Feel free to revert.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #6 from Xisco Faulí  ---
Hi Heiko,
Could you please explain why it's a high priority bug ? IMHO, it doesn't make
sense to set an easyhack to high because it might take a lot of time until a
newcomer fixes it. If it's really a high priority bug you should consider to
fix it yourself asap

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Patrick Luby  changed:

   What|Removed |Added

 CC||plub...@libreoffice.org

--- Comment #5 from Patrick Luby  ---
I did some debugging and it appears to me that macOS standard key bindings are
transposing key shortcuts like this before our code sees them.

For example, Command-Left when pressed is the macOS standard "end of line" key
shortcut so instead of receiving a "key down" event with the Mod1 and
com::sun::star::awt::Key::LEFT pressed, LibreOffice receives receives an
"action" callback that our code translates to
com::sun::star::awt::Key::MOVE_TO_END_OF_LINE.

So I assume we just need to duplicate the applicable key shortcuts that are
already in the Calc configuration files and replace LEFT_MOD1/RIGHT_MOD1/etc.
with MOVE_TO_BEGIN_OF_LINE/MOVE_TO_END_OF_LINE/etc. Or is there a simpler way
to edit the existing entries?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

BogdanB  changed:

   What|Removed |Added

 Blocks||98290
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98290
[Bug 98290] [META] Better shortcuts on macOS
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-11-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Heiko Tietze  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|NEEDINFO|NEW
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicUI
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mentoring@documentfoundatio
   ||n.org

--- Comment #4 from Heiko Tietze  ---
We define for example


   
   I10N SHORTCUTS - NO TRANSLATE
   .uno:GoToPrevWord
   


in officecfg/registry/data/org/openoffice/Office/Accelerators.xcu with MOD1
being Ctrl/Cmd.

On Windows/Linux you move word-wise with ctrl+left. So what we need is to
change the commands/accelerator combination like in


.uno:SearchDialog
...


   .uno:SearchDialog

Very much welcome for the macOS users.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-11-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8355

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-10-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Heiko Tietze  ---
And the expectation is probably to do the same as Microsoft with

cmd+left/right: begin/end of line
opt+left/right: begin/end of word
cmd+up/down: begin/end of paragraph (we use with opt)
fn+up/down: page up/down

(selecting when shift is being pressed)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-10-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

steve  changed:

   What|Removed |Added

 CC||l...@disr.it
   Keywords||needsUXEval
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from steve  ---
In writer everything works as expected I think:

alt + left / right: move by word
cmd + left / right: start / end of line
fn + left / right: beginning / end of document

calc cell edit mode:

cmd + left / right: move by word
alt + left / right: change column width
fn left / right: start / end of line

Then there is also non cell edit mode and the keys do something else yet again.

Setting to new as confirming the inconsistency. But this needs input - adding
needsUXEval.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-05-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

--- Comment #1 from Telesto  ---
> for Home/End you must press
> Fn+left/right arrow, which generally does nothing on macOS.
> 
> Is this WAI?


>From https://support.apple.com/en-us/HT201236

Fn–Left Arrow: Home: Scroll to the beginning of a document.
Fn–Right Arrow: End: Scroll to the end of a document.(In reply to Dan
Dascalescu from comment #0)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-05-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Telesto  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155169] Inconsistent behavior of Cmd+left/right arrow on macOS

2023-05-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155169

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.