[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-09-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Justin L  changed:

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |---

--- Comment #8 from Justin L  ---
REOPENED because the patch was reverted for bug 157168.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7168

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.6.0|target:7.6.0 target:7.5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

--- Comment #7 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0d0841dc8faccc7d7d3d8d463916dd73a7c061a1

tdf#155241 keep current MetricSpinButton value if unparseable junk input

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Timur  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #6 from Timur  ---
Thanks Caolan!
This seems good, I tested with those that made problem> wrong decimal point and
/ 
Let's see how it will behave with users who can press what tech-savvy wouldn't
think of.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Caolán McNamara  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Caolán McNamara  ---
caolan->timur: does that solve the problem from your perspective?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4ae776b842a8b6f065206d3250113493fd688756

tdf#155241 keep current MetricSpinButton value if unparseable junk input

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #3 from Caolán McNamara  ---
One issue, the way things are now at least, is that we do detect a bogus string
in Formatter::ImplGetValue but use "m_dDefaultValue" and that itself defaults
to 0 so junk of -=-=-=[] effectively turns into 0 and doesn't remain at the
last valid number.

There may be other issues, but lets address that first and see how it plays
out.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEW
 Blocks||108364

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Thanks Timur.
Reproduced in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 002ae41bb6088002ba3ed0188ac822fb823a23f9
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Characters are stripped.

Related: if using a comma instead of the locale's decimal point by mistake (or,
I imagine, vice versa), it is silently stripped and results in a much larger
width.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108364
[Bug 108364] [META] Table/Row/Column/Cell management function bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

2023-05-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155241

--- Comment #1 from Timur  ---
Created attachment 187198
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187198=edit
Columns

Depending on input, there may be different ways how *all* columns (or rows) are
corrupted. Here is an example.

-- 
You are receiving this mail because:
You are the assignee for the bug.