[Libreoffice-bugs] [Bug 155350] Autocorrect does not work in comments

2023-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155350

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caolan.mcnamara@collabora.c
   |desktop.org |om
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155350] Autocorrect does not work in comments

2023-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155350

--- Comment #3 from Caolán McNamara  ---
This seems to be because there are two ways to input text, "directly" with key
press events and through the input method. And the AutoCorrect is only hooked
to the key press event case. Somewhere along the line gtk started preferring to
supply more via the IM.

In the main document situation we go through a big hack tower in
GtkSalFrame::IMHandler::signalIMCommit to see if something received through the
Input Method is something that could be represented as a single key press event
and if so send one of those instead. While those comments just forward the
input method data onwards without the second-guessing hackery.

Probably better to attempt to do AutoCorrect for text received through the IM
rather than continue trying to out-guess the IM and reroute to the older
mechanism

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155350] Autocorrect does not work in comments

2023-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155350

raal  changed:

   What|Removed |Added

  Regression By||Caolán McNamara
 CC||caolan.mcnamara@collabora.c
   ||om
   Keywords||bibisected, bisected

--- Comment #2 from raal  ---
This seems to have begun at the below commit in bibisect repository/OS
linux-64-7.3.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks

e20bdd2f28dd8f4a81fc226f4371cdca1bf99b48 is the first bad commit
commit e20bdd2f28dd8f4a81fc226f4371cdca1bf99b48
Author: Jenkins Build User 
Date:   Wed Mar 2 04:34:18 2022 +0100

source sha:8badc2314961e87e0b2cc01164442d97e20f9419

130775: Resolves: tdf#145580 need to use gtk_im_context_filter_keypress |
https://gerrit.libreoffice.org/c/core/+/130775

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155350] Autocorrect does not work in comments

2023-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155350

raal  changed:

   What|Removed |Added

   Keywords||regression
 CC||r...@post.cz
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 Blocks||103341, 106179

--- Comment #1 from raal  ---
works in Version 4.1.0.0.alpha0+ (Build ID:
efca6f15609322f62a35619619a6d5fe5c9bd5a)

but not in Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 3df90fbc24a650cf6b0767d00821753ed3d4f5f4
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179
[Bug 106179] [META] Writer comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.