[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 Patrick Luby changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | Status|NEW |ASSIGNED --- Comment #17 from Patrick Luby --- Update: I think that I have fixed some of the bugs seen so far: https://gerrit.libreoffice.org/c/core/+/155429 This patch fixes the following: - Eliminates the opaque background when opening https://bugs.documentfoundation.org/attachment.cgi?id=188792 in Draw or in Impress - I may have fixed the Windows GDI rendering problems described in https://bugs.documentfoundation.org/show_bug.cgi?id=156630#c12 Still todo before I commit the patch: - Fix opaqueness surrounding image when running a slideshow - Add native accessibility check described in https://bugs.documentfoundation.org/show_bug.cgi?id=156630#c6 - Fix the macOS-only Skia window scaling problems described in https://bugs.documentfoundation.org/show_bug.cgi?id=156629#c10 - Fix random drawing of black alpha mask when exporting to PDF with Skia/Metal when image is opened in Draw and the document background is set to an opaque color. This may be related to the macOS-only Skia window scaling problems. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #16 from Patrick Luby --- Created attachment 188832 --> https://bugs.documentfoundation.org/attachment.cgi?id=188832=edit Animation with Skia/Raster on macOS. Note the gray outline in the bottom half which is 2x scaled. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #15 from Patrick Luby --- (In reply to Patrick Luby from comment #14) > Created attachment 188811 [details] > Example of broken export to PDF rendering I am also seeing drawing problems when using Skia/Raster on macOS. Interestingly, the following change fixes all rendering problems in a document window and export to PDF (but not slideshow) for Skia/Metal and Skia/disabled. I don't want to commit the following diff but it really amplifies the Skia/Raster problems so next I will see if I can figure out why Skia/Raster is different than Skia/Metal: diff --git a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx index f3c4cf69911c..5a765c1fdd16 100644 --- a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx +++ b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx @@ -104,6 +104,8 @@ namespace drawinglayer::primitive2d maVirtualDeviceMask->EnableMapMode(false); maVirtualDevice->SetOutputSizePixel(aTarget); maVirtualDeviceMask->SetOutputSizePixel(aTarget); +maVirtualDevice->SetBackground(COL_BLACK); +maVirtualDeviceMask->SetBackground(COL_ALPHA_TRANSPARENT); } maVirtualDevice->Erase(); -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #14 from Patrick Luby --- Created attachment 188811 --> https://bugs.documentfoundation.org/attachment.cgi?id=188811=edit Example of broken export to PDF rendering -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #13 from Telesto --- Created attachment 188810 --> https://bugs.documentfoundation.org/attachment.cgi?id=188810=edit Screenshot FWIW: There also rendering glitches for the APNG in impress presentation mode (with Skia enabled). But maybe a different bug belonging to a new bug report -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #12 from Telesto --- (In reply to Telesto from comment #9) > Created attachment 188808 [details] > Screenshot Windows > > It looks even worse on Windows (build 9 days ago) > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226 > CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win > Locale: nl-NL (nl_NL); UI: en-US > Calc: CL threaded Note: I somewhat overlooked that Skia being disabled here. So this only happens on Windows in GDI mode. It looks OK with Skia/Raster (unable to test Vulkan on my Windows machine) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #11 from Patrick Luby --- (In reply to Paris Oplopoios from comment #10) > APNG support didn't exist in 7.6, I added it recently. That is good to know. I found the following patch of yours which should save me a ton of time trying to find which code controls the drawing: https://gerrit.libreoffice.org/c/core/+/153556 My first guess is that the transparency->alpha patch in master will now require an AlphaMask.Invert() to be added or removed from some in the drawing calls like was needed to fix the following slideshow animation bug: https://bugs.documentfoundation.org/show_bug.cgi?id=156540 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #10 from Paris Oplopoios --- (In reply to Telesto from comment #9) > Created attachment 188808 [details] > Screenshot Windows > > It looks even worse on Windows (build 9 days ago) > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226 > CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win > Locale: nl-NL (nl_NL); UI: en-US > Calc: CL threaded FYI that's the bug I'm talking about that I get on linux as well (In reply to Patrick Luby from comment #5) > (In reply to Patrick Luby from comment #4) > > Created attachment 188802 [details] > > Screen snapshot of drawing artifacts near trunk and tail > > I rebuilt master with the latest code this morning on macOS and what I see > is normal animation of the .png image. The only bug that I still see is that > there are drawing artifacts left over near the elephant's trunk and tail > (see > https://bug-attachments.documentfoundation.org/attachment.cgi?id=188802). > > The artifacts get cleared about every second or so maybe clipping and > clearing is the issue. Interestingly, in LibreOffice RC 7.6.0.2, there is no > animation at all when I open the .apng image in Draw. So maybe the "animate > in place" is a new feature on master? APNG support didn't exist in 7.6, I added it recently. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #9 from Telesto --- Created attachment 188808 --> https://bugs.documentfoundation.org/attachment.cgi?id=188808=edit Screenshot Windows It looks even worse on Windows (build 9 days ago) Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #8 from Patrick Luby --- (In reply to Telesto from comment #7) > 1. The white area around the elephant should be transparent, or at least it > was before > 2. The APNG is animating, however the tail shows artifacts I now see what you describe. I'll look at the filled white background first as I am guessing that fixing that might also eliminate the trunk and tail drawing artifacts. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #7 from Telesto --- Created attachment 188804 --> https://bugs.documentfoundation.org/attachment.cgi?id=188804=edit Screencast My observations 1. The white area around the elephant should be transparent, or at least it was before 2. The APNG is animating, however the tail shows artifacts 3. The performance is abysmal with Skia/Raster on macOS. Makes LibreOffice pretty unresponsive Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b3053b63c65372627c5fb4df6b4ddcd5e12e16f7 CPU threads: 8; OS: Mac OS X 13.4.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #6 from Patrick Luby --- (In reply to Patrick Luby from comment #5) > The artifacts get cleared about every second or so maybe clipping and > clearing is the issue. Interestingly, in LibreOffice RC 7.6.0.2, there is no > animation at all when I open the .apng image in Draw. So maybe the "animate > in place" is a new feature on master? Note to self: add a call to MiscSettings::GetUseReducedAnimation() to turn off animation if it returns true. If MiscSettings::GetUseReducedAnimation() returns true, it should override the internal LibreOffice "animate text" preference like we did for the Calc copy border in https://bugs.documentfoundation.org/show_bug.cgi?id=155414. I will see if I can track down which LibreOffice code does the animated drawing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 Patrick Luby changed: What|Removed |Added CC||plub...@neooffice.org --- Comment #5 from Patrick Luby --- (In reply to Patrick Luby from comment #4) > Created attachment 188802 [details] > Screen snapshot of drawing artifacts near trunk and tail I rebuilt master with the latest code this morning on macOS and what I see is normal animation of the .png image. The only bug that I still see is that there are drawing artifacts left over near the elephant's trunk and tail (see https://bug-attachments.documentfoundation.org/attachment.cgi?id=188802). The artifacts get cleared about every second or so maybe clipping and clearing is the issue. Interestingly, in LibreOffice RC 7.6.0.2, there is no animation at all when I open the .apng image in Draw. So maybe the "animate in place" is a new feature on master? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #4 from Patrick Luby --- Created attachment 188802 --> https://bugs.documentfoundation.org/attachment.cgi?id=188802=edit Screen snapshot of drawing artifacts near trunk and tail -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. I noticed this log: warn:vcl:22848:22848:vcl/source/bitmap/BitmapEx.cxx:135: BitmapEx: forced mask to monochrome -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 Paris Oplopoios changed: What|Removed |Added CC||noelgran...@gmail.com, ||parisop...@gmail.com --- Comment #2 from Paris Oplopoios --- Noel, any ideas? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 Paris Oplopoios changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156630] Regression: Opaque parts of APNGs don't seem to be drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=156630 --- Comment #1 from Paris Oplopoios --- Created attachment 188792 --> https://bugs.documentfoundation.org/attachment.cgi?id=188792=edit broken apng -- You are receiving this mail because: You are the assignee for the bug.
