[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2711 CC||dgp-m...@gmx.de Blocks||107553, 108237 --- Comment #23 from Dieter --- (In reply to Regina Henschel from comment #20) > I can reproduce the problem. > > The wish here is to have true table styles. > > I thought we have already a report about true table styles, but cannot find > it. This is perhaps bug 152711. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107553 [Bug 107553] [META] Writer table styles bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108237 [Bug 108237] [META] ODF specification issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #22 from Jambunathan K --- > [Changing enhancement priority to 'high' since the number of people in CC is > higher than > 20](https://bugs.documentfoundation.org/show_bug.cgi?id=34391#c28) > > > May be that bug will help you dig in to better reports. You may at your discretion want to tag this bug with [Table Autoformat](https://bugs.documentfoundation.org/show_bug.cgi?id=113208) bucket -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #21 from Jambunathan K --- (In reply to Regina Henschel from comment #20) > I can reproduce the problem. Thanks for re-opening the issue. The examples I have given are the simplest, in the sense that their hand-rolled, and has very bare essentials. Futhermore, my use-case is unique. The converter I am using--rather the one I am authoring and maintaining--doesn't use SDKs and relies on what XML LO already generates and improvises on it for simplicity. >From the "Standard Compliance" case perspective, the independently rolled converter tests the LO in unique ways. Having the issue open, ensures that my test case is available for someone to validate against. (Closing the issue means that my test case would remain lost in the haystack) IOW, keep the issue open not for the FR its making but for supplying a unique test case. Also I have been working on my Emacs-lisp based converter close to a decade, and I have personally felt that the Writer was seriously lacking in table cell style department, and ... I sensed that there is some momentum in getting Table Template and Table Cell styles formally blessed, and I wanted to make hay while the sun was shining. > The wish here is to have true table styles. Currently it works only as > template when generating a table or re-applying a template. When the > template is assigned, this generates direct formatting of table, column, row > and cells. > > An intermediate solution could perhaps be to generate these direct > formatting from the template when opening a file and overwrite its settings > in case there exists already direct formatting in the file. > > I thought we have already a report about true table styles, but cannot find > it. Are you thinking of [Bug 34391 - FORMATTING: Introduce table cell styles (edit) ](https://bugs.documentfoundation.org/show_bug.cgi?id=34391) which has the following remark [Changing enhancement priority to 'high' since the number of people in CC is higher than 20](https://bugs.documentfoundation.org/show_bug.cgi?id=34391#c28) May be that bug will help you dig in to better reports. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 Regina Henschel changed: What|Removed |Added Resolution|NOTABUG |--- Status|RESOLVED|UNCONFIRMED --- Comment #20 from Regina Henschel --- I can reproduce the problem. The wish here is to have true table styles. Currently it works only as template when generating a table or re-applying a template. When the template is assigned, this generates direct formatting of table, column, row and cells. An intermediate solution could perhaps be to generate these direct formatting from the template when opening a file and overwrite its settings in case there exists already direct formatting in the file. I thought we have already a report about true table styles, but cannot find it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #19 from Jambunathan K --- (In reply to Stéphane Guillou (stragu) from comment #17) > (In reply to Regina Henschel from comment #16) > > You need to remove direct formatting from the table. Otherwise the styles > > from the template will not become active. > > Thank you Regina for pointing what should have been my obvious first try, > before digging into the XML... > > Jambunathan, if you clear the table's direct formatting in both the before > and after ODTs, you'll end up with the same formatting. When you say "clear direct formatting" did you attach the table cells to the table styles from styles.xml ... My assumption was that when the table style names are left out-that is, NO direct formatting (with names from content.xml-local automatic styles), or NO custom formatting (with names from styles.xml-local custom styles)- then LO should look at the table template name to infer the cell styles, and attach the respective style (with same names as style that appears in styles.xml or an automatic name whose XML definition is same as what appears in styles.xml) I really would like to see your hand-edited XML file. (If you re-save LO rewrites XML, and it gets difficult track with automatically generated numbers) I will be happy if Regina or you could clarify what you tried at your end. If you share an artefacts that you created as part of investigating this bug, please share it, before you throw it away. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #18 from Jambunathan K --- (In reply to Stéphane Guillou (stragu) from comment #17) > (In reply to Regina Henschel from comment #16) > > You need to remove direct formatting from the table. Otherwise the styles > > from the template will not become active. > > Thank you Regina for pointing what should have been my obvious first try, > before digging into the XML... > > Jambunathan, if you clear the table's direct formatting in both the before > and after ODTs, you'll end up with the same formatting. There is NO direct formatting in the second table ... There are really no style names attached to any of the table row entities -- table, col, row, or cell --- apart from the template name. ```xml ``` Just to be sure, I nuked the paragraph styles with following regexp replacement text:style-name=".*?" → When I load the ODT file, I see plain vanilla table. I also opened the hand-modified ODT file in LO, did Table->Select->Table and did Format->Clear Direct Formatting. The table continues to remain vanilla ... > > Can you please check that your script also deals with (removing) direct > formatting, so your custom table style is actually visible? I think we have different notions of what "direct formatting" means. To me, if an element is LEAVES OUT the style name attribute, it has NO formatting whatsoever (including direct formatting / content.xml-specific automatic styles) May I know how you "removed direct formatting" from the ODT file I shared. > If there is a remaining issue, maybe better to start fresh with a new > report. So closing as "not a bug". May be there is no bug LO ... I think you can help me with clearing the bug in my understanding. Could you please share the recipe on how you hand-fixed the ODT xml. If you have a diff, I will be happy to take a look at it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #17 from Stéphane Guillou (stragu) --- (In reply to Regina Henschel from comment #16) > You need to remove direct formatting from the table. Otherwise the styles > from the template will not become active. Thank you Regina for pointing what should have been my obvious first try, before digging into the XML... Jambunathan, if you clear the table's direct formatting in both the before and after ODTs, you'll end up with the same formatting. Can you please check that your script also deals with (removing) direct formatting, so your custom table style is actually visible? If there is a remaining issue, maybe better to start fresh with a new report. So closing as "not a bug". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #16 from Regina Henschel --- You need to remove direct formatting from the table. Otherwise the styles from the template will not become active. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 Stéphane Guillou (stragu) changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #15 from Stéphane Guillou (stragu) --- Not sure what is going on here. The style itself is not correct, as applying it to a table won't use the expected red style. If I edit the modified file, save it again and extract it, the styles.xml will have all elements renamed using the "styleName.digit" structure. (And the table cell styles have no custom attributes whatsoever, hence the vanilla table.) So does one have to stick to the "styleName.digit" naming? Regina, any idea? Is that numbering thing an ODF thing or imposed only by LO? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #14 from Jambunathan K --- (In reply to Jambunathan K from comment #12) > Created attachment 190147 [details] > lo-bug-157350-table-template-not-working.zip I have tested that the hand-modified ODF table is NOT colored in ALL 3 version of LO you see below Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2a217a80bf383ddab0a5e0959ab2fd907dfd3406 CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8 CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Debian package version: 4:7.5.5-4 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350
Jambunathan K changed:
What|Removed |Added
Status|NEEDINFO|UNCONFIRMED
Ever confirmed|1 |0
--- Comment #13 from Jambunathan K ---
(In reply to Buovjaga from comment #11)
> (In reply to Jambunathan K from comment #0)
> > boxlistred-new.odt
> > This ODT file has a table which "applies" a ODT Table Template
> > called 'BoxListRed'. ('BoxListRed' is a verbatim copy of the
> > "Box List Red" auto-format style that LO ships with; only the
> > template, style and display name are changed.)
> >
> > I expect the Table to have Red Rows, because the table template,
> > and the table definition explicitly request for "BoxListRed"
> > style. (See notes below for details).
> >
> > Unfortunately, the Table appears "plain" with NO style at all
> > applied. This unexpected behaviour is a bug.
>
> Do you mean you have manually changed the .xml files? If so, it would be
> good, if you provided diff files of the changes. Maybe you already use it,
> but you can make the XML in your documents be saved pretty printed by going
> to Tools - Options - Advanced - Open Expert Configuration, search: pretty.
> Set PrettyPrinting to true.
>
> Set to NEEDINFO.
> Change back to UNCONFIRMED after you have provided the information.
See https://bugs.documentfoundation.org/attachment.cgi?id=190147
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350
Jambunathan K changed:
What|Removed |Added
CC||kjambunat...@gmail.com
--- Comment #12 from Jambunathan K ---
Created attachment 190147
--> https://bugs.documentfoundation.org/attachment.cgi?id=190147=edit
lo-bug-157350-table-template-not-working.zip
This attachment was produced in response to
https://bugs.documentfoundation.org/show_bug.cgi?id=157350#c11
- lo-bug-157350-table-template-not-working.zip :: Contains all the
details needed for this bug report
- boxlist-red-yet-again-1.odt :: An empty 5x5 table with Box List Red
applied. The table is rendered with color
- boxlist-red-yet-again-1.pdf :: PDF version of the above ~odt~ file
- boxlist-red-yet-again-2.odt :: Copy ~boxlist-red-yet-again-1.odt~
and do renamings as below. The renamings are done with a text
editor.
In ~styles.xml~, do the following re-namings.
#+begin_src emacs-lisp
(("Box List Red" "BoxListRed")
("Box_20_List_20_Red.10" "BoxListRedTableBackgroundCell")
("Box_20_List_20_Red.8" "BoxListRedTableOddColumnsCell")
("Box_20_List_20_Red.7" "BoxListRedTableEvenColumnsCell")
("Box_20_List_20_Red.6" "BoxListRedTableOddRowsCell")
("Box_20_List_20_Red.5" "BoxListRedTableEvenRowsCell")
("Box_20_List_20_Red.9" "BoxListRedTableBodyCell")
("Box_20_List_20_Red.4" "BoxListRedTableLastColumnCell")
("Box_20_List_20_Red.3" "BoxListRedTableFirstColumnCell")
("Box_20_List_20_Red.2" "BoxListRedTableLastRowCell")
("Box_20_List_20_Red.1" "BoxListRedTableFirstRowCell"))
#+end_src
In ~content.xml~, do the following re-naming.
#+begin_src emacs-lisp
(("Box List Red" "BoxListRed"))
#+end_src
Also, strip the ~table:style-name~ attribute from all the
~table:table-cell~ elements of the table.
Confirm that above XML files are well-formed according to the ODF
rng schema.
- boxlist-red-yet-again-1-to-2.diff :: This diff file shows what
renamings have been done.
- boxlist-red-yet-again-2.pdf :: PDF export of the above ~odt~ file.
- boxlist-red-yet-again-2 :: Unzipped version of
~boxlist-red-yet-again-2.odt~
* Bug description
- Open ~boxlist-red-yet-again-2.odt~
- Note that the table has no colors
The expected behaviour is that table in ~boxlist-red-yet-again-2~
should be rendered just the same way as ~boxlist-red-yet-again-1~.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350
Buovjaga changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDINFO
Ever confirmed|0 |1
Summary|Table ODF Table Template is |Table ODF Table Template is
|not honored (in LO 24.2 |not honored (In other
|daily builds) (In other |words, non-compliance with
|words, non-compliance with |ODF-v1.2 standard)
|ODF-v1.2 standard) |
CC||ilmari.lauhakangas@libreoff
||ice.org
--- Comment #11 from Buovjaga ---
(In reply to Jambunathan K from comment #0)
> boxlistred-new.odt
> This ODT file has a table which "applies" a ODT Table Template
> called 'BoxListRed'. ('BoxListRed' is a verbatim copy of the
> "Box List Red" auto-format style that LO ships with; only the
> template, style and display name are changed.)
>
> I expect the Table to have Red Rows, because the table template,
> and the table definition explicitly request for "BoxListRed"
> style. (See notes below for details).
>
> Unfortunately, the Table appears "plain" with NO style at all
> applied. This unexpected behaviour is a bug.
Do you mean you have manually changed the .xml files? If so, it would be good,
if you provided diff files of the changes. Maybe you already use it, but you
can make the XML in your documents be saved pretty printed by going to Tools -
Options - Advanced - Open Expert Configuration, search: pretty. Set
PrettyPrinting to true.
Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.
--
You are receiving this mail because:
You are the assignee for the bug.
