[Libreoffice-bugs] [Bug 33047] FILEOPEN HSQLDB sees no table when filename contains ? character

2011-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33047

--- Comment #9 from Julien Nabet serval2...@yahoo.fr 2011-10-29 00:02:48 PDT 
---
Created attachment 52875
  -- https://bugs.freedesktop.org/attachment.cgi?id=52875
patch proposed

Pb : the tables of a document odb with contains a ? character can't be viewed

I had put a backtrace but I don't know why there was a test which tried to
rename element.
I took a look at git log and found the commit
f463e18dd6201eb7ec2e6fce3dd221489ed2b4ec (16/02/2005).

I don't know why there was a test with a call to rename and not simply the call
of isStream so I simplified the code to just have the isStream call and put the
catch element like the ones of the 2 other methods.

With this patch, I can see tables of a document odb with contains a ?
character
Moreover, since the commit of 2005 fixed a bug
(http://openoffice.org/bugzilla/show_bug.cgi?id=39922), I tried to reproduce
this one after having applied the patch, I didn't reproduce it. But perhaps I
missed something.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 33047] FILEOPEN HSQLDB sees no table when filename contains ? character

2011-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33047

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|libreoffice-b...@lists.free |lio...@mamane.lu
   |desktop.org |

--- Comment #10 from Lionel Elie Mamane lio...@mamane.lu 2011-10-29 02:52:59 
PDT ---
(In reply to comment #9)
 Created attachment 52875 [details] [review]
 patch proposed

Great, thanks. Will review in the week of 7 November, if nobody else beats me
to it.

 I had put a backtrace but I don't know why there was a test which tried to
 rename element.

 I took a look at git log and found the commit
 f463e18dd6201eb7ec2e6fce3dd221489ed2b4ec (16/02/2005).

 I don't know why there was a test with a call to rename (...)

 (...) since the commit of 2005 fixed a bug
 (http://openoffice.org/bugzilla/show_bug.cgi?id=39922), I tried to reproduce
 this one after having applied the patch, I didn't reproduce it.

I *think* a later fixed bug i#39922 in a better way: instead of constantly
renaming the data file (within the .odb file as a zip file) to match the
filename of the odb file, just call it always data.

So it would have made the renaming you remove obsolete. But not sure, I have to
dig in deeper to really understand.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 33047] FILEOPEN HSQLDB sees no table when filename contains ? character

2011-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33047

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #8 from Julien Nabet serval2...@yahoo.fr 2011-10-28 14:54:37 PDT 
---
Here is a trace I get :
Error: Exception caught! :
Java_com_sun_star_sdbcx_comp_hsqldb_StorageFileAccess_isStreamElement From File
/home/maryline/compile-libreoffice/libo/connectivity/source/drivers/hsqldb/StorageFileAccess.cxx
at Line 94

I must do more tests.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs