[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2023-06-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #32 from ⁨خالد حسني⁩  ---
It seems that the ch and line units are implemented only when text grid is
enabled, without the grid it defaults to a fixed value for both units.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #31 from Kevin Suo  ---
Some code reference: the CJK character units seems added by:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=author=amwang

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2022-05-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #30 from AngelSherry  ---
I'm sure that it may cause by Line Spacing, which will mess up first line
indent using Character with CJK language if it's not on Sing Line.

In my memory, Libreoffice did add the feather of first line indent using
Character on 6.x version. But I find it only work on Sing Line. If I change to
other Line Spacing, the characters of first line won't be aligned, and it will
make no sense.

Testing on Libreoffce 7.3, still not fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2022-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

Kevin Suo  changed:

   What|Removed |Added

 CC||brian...@qq.com

--- Comment #29 from Kevin Suo  ---
*** Bug 123938 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2022-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

Kevin Suo  changed:

   What|Removed |Added

 Blocks||146932


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146932
[Bug 146932] CJK font-size in Writer default paragraph style is not the same as
Western font
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #28 from Volga  ---
(In reply to Kevin Suo from comment #25)
> One ch unit means one character unit, which equals to the height of the
> character of the current paragraph using the font of the current paragraph
> style.
> 
> In Chinese language there is a long standing convention that in a paragraph
> the first line indent should be 2 characters.
This is also documented in the Requirements for Chinese Text Layout by W3C.
https://www.w3.org/TR/clreq/#first_line_indents

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #27 from Volga  ---
(In reply to Kevin Suo from comment #10)
Another workaround for Chinese users:
Insert U+3000 IDEOGRAPHIC SPACE ( ) (known as 全角空格) twice at the beginning.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #26 from Kevin Suo  ---
The series of commits which added the "character unit" are:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep=cjk-character-units

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #25 from Kevin Suo  ---
One ch unit means one character unit, which equals to the height of the
character of the current paragraph using the font of the current paragraph
style.

In Chinese language there is a long standing convention that in a paragraph the
first line indent should be 2 characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #24 from Miklos Vajna  ---
It would be good to research what is that "ch" unit, I'm not familiar with
that. Is that intentionally depending on the font size or is there a fixed
conversion factor between ch and e.g. twips?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #23 from Kevin Suo  ---
Created attachment 176992
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176992=edit
screenshot showing the problem

Attached is a screenshot illustrating the problem, as well as a comparison with
MSO Word 2010.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #22 from Kevin Suo  ---
Created attachment 176991
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176991=edit
Test ODT Document

As shown in this test document, the first line indent for the 1st paragraph is
correctly 2-characters, whereas it is wrong in the 2nd paragraph.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

--- Comment #21 from Kevin Suo  ---
By the way, with the fix for bug 129448 (patch currently under review:
https://gerrit.libreoffice.org/c/core/+/125627), the first line indent will not
be effected by line space, thus when first line indent is set to Auto, then it
will always be precisely 2-characters indent, and the indent will be updated
upon font size change.

*This* bug is a little different as it only relates to when the "Use character
units" option is enabled and one inputs an first line indent of e.g. "2 Ch" in
the Paragraph Properties dialog. In other words, this bug is about the manually
set first line indent, not Auto first line indent.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

Kevin Suo  changed:

   What|Removed |Added

 CC||vmik...@collabora.com

--- Comment #20 from Kevin Suo  ---
This is still producible on current master. Anyone interest in this one, or
could some devs give some code pointers and advices?

I am adding Miklos Vajna to cc. Could you please advice? 
I am working bug 129448, they are related, but *this* one seems to be different
and I do not know where to start, and I am not sure whether this is as easy as
bug 129448 for me to work on.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36709

Kevin Suo  changed:

   What|Removed |Added

Summary|First Line Indent Using Ch  |For first line indent using
   |(Characters) as Units Won't |Ch (Characters) as unit,
   |Change Size as Font Size|the indent value should
   |Grow|change when font-size
   ||changes

-- 
You are receiving this mail because:
You are the assignee for the bug.