[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added CC||kohei.yosh...@gmail.com --- Comment #4 from Markus Mohrhard markus.mohrh...@googlemail.com 2012-04-03 18:58:46 PDT --- I'm not sure if this is really a bug. Kohei explicitly removed this for Bug 33756.(http://cgit.freedesktop.org/libreoffice/core/commit/?id=4ac51b9cd2b37996542eaaf13a57fa5ececa6dab) @Kohei: Any opinion on this bug? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 --- Comment #5 from Kohei Yoshida kohei.yosh...@gmail.com 2012-04-03 19:08:52 PDT --- It's a bug. Hidden cells should always be treated as if they don't exist when expanding selection. Having said that, this cursor navigation code has become such a complex monster we need to refactor it so that we can guard it with a decent amount of unit tests. Otherwise it would be extremely hard to avoid introducing another regression when fixing a bug (any bug) in this code. I believe we talked about this briefly before when we were talking about some unit test areas (with me, you and Eike). When expanding selection or navigating the cell cursor, we need to factor in: 1) hidden rows/columns 2) protected areas 3) merged cells 4) modifier keys (shift / ctrl / both) So, one has to check all these possibilities when modifying the cursor navigation code. And from my own experience it's way too easy to introduce regressions in this code... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com --- Comment #6 from Markus Mohrhard markus.mohrh...@googlemail.com 2012-04-03 19:58:17 PDT --- (In reply to comment #5) It's a bug. Hidden cells should always be treated as if they don't exist when expanding selection. Having said that, this cursor navigation code has become such a complex monster we need to refactor it so that we can guard it with a decent amount of unit tests. Otherwise it would be extremely hard to avoid introducing another regression when fixing a bug (any bug) in this code. I believe we talked about this briefly before when we were talking about some unit test areas (with me, you and Eike). I remember something like that now. I'm just getting a bit old and start forgetting things ;) I agree that this would need a real unit test and I think we can easily write one for that. I will look into it. I think in this case it even makes a lot of sense to write the tests now before actually implementing the code. I fear that this code is not testable by ucalc because it needs vcl and the view part of sc. So our best shot on testing this is writing a real unit test. We should get a good test for this by mocking ScDocument (at least a part) and moving as much functionality for this behavior into an own class that has only dependencies to ScDocument. When expanding selection or navigating the cell cursor, we need to factor in: 1) hidden rows/columns 2) protected areas 3) merged cells 4) modifier keys (shift / ctrl / both) So, one has to check all these possibilities when modifying the cursor navigation code. And from my own experience it's way too easy to introduce regressions in this code... I suspect i will have a lot of fun with this. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||bi...@gmx.de --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-03-31 23:18:34 PDT --- *** Bug 48071 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 OfficeUser bi...@gmx.de changed: What|Removed |Added Keywords||regression --- Comment #3 from OfficeUser bi...@gmx.de 2012-04-01 04:58:34 PDT --- Added regression keyword due this comment: https://bugs.freedesktop.org/show_bug.cgi?id=48071#c3 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns
https://bugs.freedesktop.org/show_bug.cgi?id=45020 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #1 from Cor Nouws c...@nouenoff.nl 2012-01-20 23:22:48 PST --- annoyed me now and then the past months, but the bug is there already in 3.3.4 Not in OOo 3.3.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
