[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Robert Großkopf  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #33 from Robert Großkopf  ---
Bug appears with LO 7.5.1.2 on OpenSUSE 15.4 64bit rpm Linux. Nothing changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #32 from QA Administrators  ---
Dear Robert Großkopf,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Tom  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #31 from Tom  ---
More information and correction:
Correction: The mentioned workaroud does work but with restrictios, see below.
Other findings: 
1. Unlike implemented for push-buttons, no "click-effect" is implemented for
image-buttons. User therefore does not clearly see whether or not a button has
been used.
2. Image-buttons used for navigation are not disabled when not applicable (i.e.
first and previous record buttons are not disabled when record-pointer at first
record of a recordset). This is working correctly when using push-buttons with
a navigation action.
3. When opening a second form without closing the current form, and then using
the first form again, navigation does not work anymore when using
image-buttons. It seems the form has lost its record-pointer.
4. When using image-buttons in combination with a called macro to perform the
required record action everything works correctly, except disabling as
mentioned before.
Used coding in that case: 
sFormName  = Split(thiscomponent.Title," : ")(1)'required?
oForm = thisComponent.drawpage.forms.getByName(sFormName)   'required?
oDocument  = ThisComponent.CurrentController.Frame
oDispatcher = createUnoService("com.sun.star.frame.DispatchHelper")
oDispatcher.executeDispatch(oDocument ,".uno:FirstRecord","",0,Array())
Interesting finding: if in addition to image-buttons also push-buttons are
defined with action navigation on the form disabling reacts for these buttons
if the image-buttons are used. 

I do realize that these issues have mainly a "cosmetic" character, since
push-buttons can be used instead, but the concerned functionality should for
image-buttons either be corrected or not made available.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #30 from Tom  ---
Using Windows 11 on laptop 16GB and Windows 10 Home on desktop, LO version
7.3.5.2 (64 bits), database Firebirds external (server) I can confirm that the
issue still exists. Trying to use earlier mentioned workarounds is NOT
recommanded either: causing LO crash or freeze.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #29 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/2a27ff2190a40afe806bbf3577b641390047e209

tdf#140151: revert fix for tdf#46579 which caused regression

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.1.1|target:7.1.1 target:7.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #28 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/9567639d6a649cffc9f1a965a11b5b202b241179

tdf#140151: revert fix for tdf#46579 which caused regression

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|
   |target:7.1.0.0.beta2|
   |target:7.0.5|
 CC|serval2...@yahoo.fr |
 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #27 from Julien Nabet  ---
Patch caused regression (see tdf#140151).
So I reverted it on master, and the revert waits for review for 7.1 and 7.0
branches.
No idea at all what's the pb of regression.
=> revert back to NEW and uncc myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #26 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a444a8dd40cf7035c44ee8ef168be2b3e3144c86

tdf#140151: revert fix for tdf#46579 which caused regression

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0151

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|target:7.2.0
   |target:7.1.0.0.beta2|target:7.1.0.0.beta2
   ||target:7.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #25 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/45963cfb6b453cf18aaa7534f20c35a38975dc89

tdf#46579: fix form fields 'Image Button' in Forms

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #24 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/6b5ca41c5d78e6a45f7a39d99c5a7ae283d243de

tdf#46579: fix form fields 'Image Button' in Forms

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|target:7.2.0
   ||target:7.1.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #23 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/07be45d03f80fa681c697ca9f5a13084a81c7a26

tdf#46579: fix form fields 'Image Button' in Forms

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #22 from Julien Nabet  ---
Let's go on with m_pFeatureInterception which is ControlFeatureInterception.
This last one is initialized with param
- m_xORB (css::uno::Reference< css::uno::XComponentContext >) in
formnavigation.cxx (the OK case)
- _rxFactory in clickableimage.cxx (the KO case)
...
Then the more I try to understand the rest, the more I got lost with all these
dispatch, m_xORB, references, ...
The only thing I'm sure is the patch made this work.
I'll push this one on master and let people give it a try. If someone complains
about it, don't hesitate to revert.
I'm quite fed up of all these tricky mechanisms in some parts of LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #21 from Julien Nabet  ---
(In reply to Julien Nabet from comment #20)
> Lionel: I finally found the missing element for clickable image.
> dispatch/interceptor part was difficult to track down.
> I submitted https://gerrit.libreoffice.org/c/core/+/107037

Sorry Lionel the comment of my patch didn't explain anything, I was quite tired
yesterday and eager to submit the patch :-)

Let's start with non image button which work.
When entering the form, the specific dispatch mechanism for these urls is
prepared:
Thread 1 "soffice.bin" hit Breakpoint 1,
frm::OFormNavigationHelper::queryDispatch (this=0x7781dc8, _rURL=...) at
forms/source/helper/formnavigation.cxx:263
263 return m_pFeatureInterception->queryDispatch( _rURL );
(gdb) p _rURL
$1 = (const com::sun::star::util::URL &) @0x7783208: {Complete =
".uno:FormController/moveToFirst", Main = ".uno:FormController/moveToFirst",
Protocol = ".uno:", User = "", Password = "", Server = "", 
  Port = 0, Path = "FormController/moveToFirst", Name = "", Arguments = "",
Mark = ""}
(gdb) bt
#0  frm::OFormNavigationHelper::queryDispatch(com::sun::star::util::URL const&)
(this=0x7781dc8, _rURL=...) at forms/source/helper/formnavigation.cxx:263
#1  0x7f85f9087ec1 in frm::OFormNavigationHelper::connectDispatchers()
(this=0x7781dc8) at forms/source/helper/formnavigation.cxx:200
#2  0x7f85f9087353 in frm::OFormNavigationHelper::updateDispatches()
(this=0x7781dc8) at forms/source/helper/formnavigation.cxx:146
#3  0x7f85f8eef7ee in
frm::OButtonControl::modelFeatureUrlPotentiallyChanged() (this=0x7781c80) at
forms/source/component/Button.cxx:623
#4  0x7f85f8eef701 in
frm::OButtonControl::setModel(com::sun::star::uno::Reference
const&) (this=0x7781c80, _rxModel=
uno::Reference to (UnoControlButtonModel *) 0x393af28) at
forms/source/component/Button.cxx:607
#5  0x7f864a52ac26 in sdr::contact::(anonymous
namespace)::ControlHolder::setModel(com::sun::star::uno::Reference
const&) const
(this=0x7fffa2d6e700, _m=uno::Reference to (UnoControlButtonModel *)
0x393af28) at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:187

Notice URL:
{Complete = ".uno:FormController/moveToFirst", Main =
".uno:FormController/moveToFirst", Protocol = ".uno:", User = "", Password =
"", Server = "", 
  Port = 0, Path = "FormController/moveToFirst", Name = "", Arguments = "",
Mark = ""}

It's also during form opening that the method "getModelUrlFeatureId" you quoted
in your previous comment is called:
#0  frm::OButtonControl::getModelUrlFeatureId() const (this=0x73d2820) at
forms/source/component/Button.cxx:655
#1  0x7f85f8eef787 in
frm::OButtonControl::modelFeatureUrlPotentiallyChanged() (this=0x73d2820) at
forms/source/component/Button.cxx:618
#2  0x7f85f8eef701 in
frm::OButtonControl::setModel(com::sun::star::uno::Reference
const&)
(this=0x73d2820, _rxModel=uno::Reference to (UnoControlButtonModel *)
0x3e49c88) at forms/source/component/Button.cxx:607
#3  0x7f864a52ac26 in sdr::contact::(anonymous
namespace)::ControlHolder::setModel(com::sun::star::uno::Reference
const&) const
(this=0x7fffa2d6e700, _m=uno::Reference to (UnoControlButtonModel *)
0x3e49c88) at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:187

Then once in the form, each click on one of these button calls:
#0  frm::OFormNavigationHelper::dispatch(short) const (this=0x7784578,
_nFeatureId=5) at forms/source/helper/formnavigation.cxx:287
#1  0x7f85f8f3 in frm::OButtonControl::actionPerformed_Impl(bool,
com::sun::star::awt::MouseEvent const&) (this=0x7784430,
_bNotifyListener=false, _rEvt=...) at forms/source/component/Button.cxx:498
#2  0x7f85f8eeed58 in frm::OButtonControl::OnClick(void*) (this=0x7784430)
at forms/source/component/Button.cxx:478
#3  0x7f85f8eee5c0 in frm::OButtonControl::LinkStubOnClick(void*, void*)
(instance=0x7784430, data=0x0) at forms/source/component/Button.cxx:429
#4  0x7f864739e9e8 in Link::Call(void*) const (this=0x6e1ec78,
data=0x0) at include/tools/link.hxx:111
#5  0x7f864739abee in ImplHandleUserEvent(ImplSVEvent*)
(pSVEvent=0x6e1ec70) at vcl/source/window/winproc.cxx:1990


Now, let's take a look at image button which doesn't work.
When opening form there's some preparation with:
#0 
frm::OImageButtonModel::describeFixedProperties(com::sun::star::uno::Sequence&)
const (this=0x6f92d40, _rProps=empty uno::Sequence)
at forms/source/component/ImageButton.cxx:78
#1  0x7f85f8fd2c7c in
frm::OControlModel::describeFixedAndAggregateProperties(com::sun::star::uno::Sequence&,
com::sun::star::uno::Sequence&) const
(this=0x6f92d60, _out_rFixedProperties=empty uno::Sequence,
_out_rAggregateProperties=empty uno::Sequence) at
forms/source/component/FormComponent.cxx:1040
#2  0x7f85f9070f4c in frm::PropertyBagHelper::impl_ts_getArrayHelper()
const (this=0x6f92ec8) at forms/source/component/propertybaghelper.cxx:154
#3  0x7f85f8f6e7a5 in 

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #20 from Julien Nabet  ---
Lionel: I finally found the missing element for clickable image.
dispatch/interceptor part was difficult to track down.
I submitted https://gerrit.libreoffice.org/c/core/+/107037

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #19 from Julien Nabet  ---
(In reply to Lionel Elie Mamane from comment #18)
> ...
> My guess is that the same treatment must happen for image buttons, but
> doesn't. Probably should happen either somewhere in ImageButton.cxx or in
> the parent class clickableimage.cxx

Thank you for the feedback. I'll take a look.
What I liked in the patch I quoted is the fact we could use same uno commands
as others. If we fix this bug by finding the way to deal with
.uno:FormController/*, we won't be able to remove these since it'll bring some
compatibility regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #18 from Lionel Elie Mamane  ---
Wow, that's a strange bug indeed.

Text button and image button seem to have quite different implementations, not
sure why.

I see that text buttons, in forms/source/component/Button.cxx, have some
special treatment of URLs starting with ".uno:FormController/", in function
OButtonControl::getModelUrlFeatureId:

// are we a URL button?
if ( eButtonType == FormButtonType_URL )
{
// is it a feature URL?
if ( isFormControllerURL( sUrl ) )
{
nFeatureId = OFormNavigationMapper::getFeatureId( sUrl );
}
}

My guess is that the same treatment must happen for image buttons, but doesn't.
Probably should happen either somewhere in ImageButton.cxx or in the parent
class clickableimage.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #17 from Julien Nabet  ---
Lionel: following Robert's comment about using ".uno:NextRecord", I gave a try
with this patch:
diff --git a/extensions/source/propctrlr/pushbuttonnavigation.cxx
b/extensions/source/propctrlr/pushbuttonnavigation.cxx
index 3d1bf748c712..786ef8862eb6 100644
--- a/extensions/source/propctrlr/pushbuttonnavigation.cxx
+++ b/extensions/source/propctrlr/pushbuttonnavigation.cxx
@@ -43,7 +43,7 @@ namespace pcr
 {
 ".uno:FormController/moveToFirst",
 ".uno:FormController/moveToPrev",
-".uno:FormController/moveToNext",
+".uno:NextRecord",
 ".uno:FormController/moveToLast",
 ".uno:FormController/saveRecord",
 ".uno:FormController/undoRecord",
diff --git a/forms/source/inc/frm_strings.hxx
b/forms/source/inc/frm_strings.hxx
index 06d3f8cb148b..af69996206c5 100644
--- a/forms/source/inc/frm_strings.hxx
+++ b/forms/source/inc/frm_strings.hxx
@@ -274,7 +274,7 @@ namespace frm
 #define URL_FORM_RECORDCOUNT  ".uno:FormController/RecordCount"
 #define URL_RECORD_FIRST  ".uno:FormController/moveToFirst"
 #define URL_RECORD_PREV   ".uno:FormController/moveToPrev"
-#define URL_RECORD_NEXT   ".uno:FormController/moveToNext"
+#define URL_RECORD_NEXT   ".uno:NextRecord"
 #define URL_RECORD_LAST   ".uno:FormController/moveToLast"
 #define URL_RECORD_SAVE   ".uno:FormController/saveRecord"
 #define URL_RECORD_UNDO   ".uno:FormController/undoRecord"
diff --git a/svx/source/inc/fmurl.hxx b/svx/source/inc/fmurl.hxx
index a354eae59e84..bd6c9837e047 100644
--- a/svx/source/inc/fmurl.hxx
+++ b/svx/source/inc/fmurl.hxx
@@ -24,7 +24,7 @@
 #define FMURL_FORM_RECORDCOUNT ".uno:FormController/RecordCount"
 #define FMURL_RECORD_MOVEFIRST ".uno:FormController/moveToFirst"
 #define FMURL_RECORD_MOVEPREV  ".uno:FormController/moveToPrev"
-#define FMURL_RECORD_MOVENEXT  ".uno:FormController/moveToNext"
+#define FMURL_RECORD_MOVENEXT  ".uno:NextRecord"
 #define FMURL_RECORD_MOVELAST  ".uno:FormController/moveToLast"
 #define FMURL_RECORD_MOVETONEW ".uno:FormController/moveToNew"
 #define FMURL_RECORD_UNDO  ".uno:FormController/undoRecord"

Then I modified the form to use next record for the image control since it was
broken with the patch then it worked!

So do you think it's the right way or should we stick to urls like:
.uno:FormController/ ?
I mean, I'm not sure these uno/FormController work in other cases so even if
the each exiting forms will have to be modified, since it didn't work at first
place, I think it might be the right move.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #16 from Tom  ---
(In reply to Tom from comment #15)
> Bug still exists in LO 6.3.4  on Windows 10 (64 bits).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #15 from Tom  ---
Bug still exists in LO 6.3.4  on Windows 10 (64 bits). Database-type does not
matter. Unfortunately the suggested workaround does not work either (in my
case): The settings are accepted when editing the form, but nothing happens
when used.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #14 from Robert Großkopf  ---
Bug still exists with LO 6.1.5.2 on OpenSUSE 15, 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #12 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated yesterday, I can still
reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Volga  changed:

   What|Removed |Added

 Blocks||105585


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105585
[Bug 105585] [META] Base image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #10 from rob...@familiegrosskopf.de ---
OK, I have found a workaround:
You could set the action to 
"Open document/web page"
and then type for URL
.uno:NextRecord
... so you get the action "Next Record"

Seems the actions have simply been forgotten ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #9 from rob...@familiegrosskopf.de ---
Bug still exist in
Version: 5.2.4.2
Build-ID: 3d5603e1122f0f102b62521720ab13a38a4e0eb0
CPU-Threads: 4; BS-Version: Linux 4.1; UI-Render: Standard; VCL: kde4; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group

Also tested with LO 5.4.0.0.alpha0. Same behavior. Nothing happens if I click
on any "ImageButton" of the form.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of
LibreOffice 
(5.1.6 or 5.2.3  https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of
LibreOffice and 
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave 
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20170103

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

Version|3.3.0 release   |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 CC||rib...@gmail.com

--- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk ---
*** Bug 89169 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46579

--- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk ---
Adding self to CC if not already on

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46579

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet serval2...@yahoo.fr ---
For the record, on pc Debian x86-64 with master sources updated yesterday, I
could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46579

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||lio...@mamane.lu
Summary|EDITING: Graphical Buttons  |Form fields 'Image Button'
   |won't work in Base-Forms|do not work in Forms
Version|unspecified |LibO 3.3.0 release

--- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-02-25 00:27:08 PST ---
[Reproducible] with LibreOffice Portable 3.3.0  - WIN7  Home Premium (64bit)
German UI [OOO330m19 (Build:6) tag libreoffice-3.3.0.4] 

Also a problem  with 3.4.5, 3.5.0

Still [Reproducible] with LOdev 3.6.0alpha0+  English UI/Locale [Build ID:
aa7e105-b2dd236-9eed775-d06f752-4dba2d1 (libreoffice-3-5-branch-point)] 
{Win-x86@9-Voreppe Win32 pull time 2012-02-14 16:17:23}. OS: German WIN7 Home
Premium (64bit)  

Inherited from OOo, also a Problem with OOo 3.1.1, 3.3, 3.4Beta; I did not find
an AOOo Issue.

I attached a modified version of reporter's database showing that normal Push
Buttons work as expected.

Lionel: 
One for you? Please set Status to ASSIGNED and add yourself to Assigned To if
you accept this Bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46579

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

  Attachment #57604|0   |1
is obsolete||

--- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-02-25 00:39:59 PST ---
Created attachment 57621
  -- https://bugs.freedesktop.org/attachment.cgi?id=57621
Enhanced sample document

Enhanced sample document additionally shows that normal buttons work fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs