[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

Buovjaga  changed:

   What|Removed |Added

 CC|mentoring@documentfoundatio |
   |n.org   |
   Keywords|difficultyBeginner, |
   |easyHack, skillCpp, topicUI |

--- Comment #18 from Buovjaga  ---
This is too confusing for an easy hack, so removing relevant bits

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #17 from Federico Gallo  ---
Hello, as a candidate to new contributor I would like to add a small
perspective on how to workaround this. 
Currently, the history of Find as well as the state of check-boxes are
kept as long as the suite is still open. 

This means, that if Calc is closed and Writer is opened (while the suite is
still opened), the history is there but the checkbox for *All sheets* is
obviously not. However, opening Calc again and performing the F action will
show the checkbox with its last state/value. 

So technically, if we see the different modules (Writer, Calc, etc) as part of
the whole (the suite), once the suite is closed the history and options are
lost. Then the title for this feature request is accurate. 
And here is the perspective, maybe when a user open a module (Calc for example)
finish a task and close the program, maybe the suite should stay active and
minimized by default. This could be an option for the user to set.

This definitely does not satisfy the feature request but on the other hand this
request has more than 10 years of discussion. It will somehow relieve the
headache or stress of losing previous searches or options from some users.
Because currently while the suite is still open it does it, it keep the state
and history

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #16 from gwb...@gmail.com ---
I will just add another vote for the setting to be persistent even after
closing the application. If we are trying to protect people from 'forgetting'
we could make it a preferences setting that would require a more sophisticated
user / action to change the default behavior.Importance will vary with use.  I
personally get tired of having to constantly click the box.  A small effort,
yes. However, I believe in the computer doing the tedious work for me ;-),

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #15 from Heiko Tietze  ---
Fwiw, I agree with Ady to not remember the setting across sessions. But I'd
keep it on once it has been set manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #14 from ady  ---
(In reply to Jeff Fortin Tam from comment #13)

> At that point if the user repeatedly ignores _four_ indicators and then
> blames the software, the amount of things we can do is limited. But they can
> always undo even long after that dialog is dismissed.

We simply disagree – I won't waste (everyone's) time explaining more details.

* I agree with remembering the "all sheets" setting when the relevant file is
still open;
* once LO is closed, the "all sheets" setting should be OFF.

(I even disagree with the current UX behavior in which the F settings is
remembered between different files within the same session, but that's not part
of this ticket.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #13 from Jeff Fortin Tam  ---
Ady, I respectfully think you're way overcomplicating this, with your idea of
adding a settings saving template mechanism for this dialog. That dialog is
already pretty cluttered and confusing enough, in my view.

The most I would add would be a tooltip on the "Replace all" button that
appears only when "Search all sheets" is checked, saying "Replace all matches
on all sheets", which serve as a third visual warning sign. Heck, if you
want to be _extra_ obvious, in addition to the tooltip, you could change the
"Replace All" button's label to including a warning sign emoji ("Replace All
⚠️") when "Search all sheets" is checked, but I think that's unnecessary.

Remember these incident-reducing factors:

* There's more than one undo history step possible in an app like LibreOffice,
and they can work long after the "Find & Replace" dialog has been dismissed.

* The checkbox widget is already quite noticeable on toolkits/OSes that color
the checkboxes (indication no.1), and the user would need to "accidentally" use
"Replace all" (instead of replace once) whose label is a second indication (and
a tooltip could be a 3rd indication), _and_ somehow still not notice this even
with my proposed improvements to the "results" dialog (which would be the 4th
indication that makes it really pretty obvious that an operation has indeed
happened across all sheets, and would make it easy to undo).

At that point if the user repeatedly ignores _four_ indicators and then blames
the software, the amount of things we can do is limited. But they can always
undo even long after that dialog is dismissed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #12 from ady  ---
(In reply to Jeff Fortin Tam from comment #11)
> I have tested now, and Undo (Ctrl+Z) *does* work even if you did a search &
> replace across all sheets.

When a user executes a replace on _all sheets_ by accident, and the action is
discovered immediately, then undo might help. That is not the relevant case I
presented; just think about not discovering the accident immediately, with
multiple actions after the unnoticed 'replace' (even possibly saving the file
and exiting LO completely).

Usually, the default settings tend to prevent loss of data, especially by
mistake.

The alternative method could be to provide a way to set new defaults for a user
to set at will:

* "factory" default settings for F would be the current situation.
* add an icon or checkbox or a round/point/dot option in the F dialog to save
whichever settings are set (ON/OFF) in that moment as the next default
settings; as soon as the user presses OK in the dialogue, the new settings will
be the new default (and the new checkbox will be set OFF in the next execution
of the dialogue).
* add an icon or checkbox or a round/point/dot option in the F dialog to
reset the default settings to the "factory" defaults as soon as the user
presses OK in the dialogue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #11 from Jeff Fortin Tam  ---
> a user that would execute find and replace on all sheets by mistake
> (and might not even notice the 'all sheets' checkbox)
> would unwillingly modify data without the possibility of recovering it.

I have tested now, and Undo (Ctrl+Z) *does* work even if you did a search &
replace across all sheets.


That said, I can empathize with your concern. If you want the UI to be extra
helpful in preventing "did not notice" accidents, what should be done instead
is, in the Search & Replace results dialog (misnamed as "Search Results"...):

* Instead of only showing "6 results found" as a string near the bottom, show
"6 results found and replaced across 3 sheets." (use bold text
and indicate the number of sheets affected, in case the user doesn't notice
from the sheet names column, especially with large lists of results)

* Provide an "Undo" button directly in that dialog, next to the Close button.
That way, the user cannot panic, the button is conveniently right there.

* ALWAYS show that dialog when doing a search (or search & replace) across
multiple sheets, and hide the "Show this dialog" toggle checkbox widget in that
situation. In fact, since there is no option to turn that option back on from
the "Find and Replace" dialog, I might go one step further and recommend
eliminating this option entirely, it kinda makes no sense.

* Bonus points: make that dialog larger to avoid scrolling (ideally auto-sized
if there aren't too many results), i.e. bug #157207

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #10 from ady  ---
Beware: a user that would execute find and replace on all sheets by mistake
(and might not even notice the 'all sheets' checkbox) would unwillingly modify
data without the possibility of recovering it.

Forgetting to uncheck an option (e.g. 'all sheets') after it was used once
would be very easy/frequent for a common user. One thing is to maintain it
(i.e. remember its status) while a file is open; another very different thing
is to keep it after the file is closed, or, even worse, to keep it for the next
LO session. There are risks in such cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

Heiko Tietze  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org,
   ||mentoring@documentfoundatio
   ||n.org
   Keywords||difficultyBeginner,
   ||easyHack, skillCpp, topicUI

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

Jeff Fortin Tam  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||270

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

Andreas Heinisch  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9473

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

--- Comment #9 from Andreas Heinisch  ---
Code pointer:

include/unotools/searchopt.hxx
svx/source/dialog/srchdlg.cxx
unotools/source/config/searchopt.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

Stanislav Horacek  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #7 from Stanislav Horacek  ---
Any reason for NEEDINFO? Setting back to NEW as the enhancement is described
clearly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: "Search in all sheets" setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58676

ted...@yahoo.com  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #6 from ted...@yahoo.com  ---
I've been hoping and searching for this feature for many years now, and it's
now almost 3 years since the last post (and about 4.5 years since the first
post) on this thread about this.

Has this enhancement been figured out by now?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: Search in all sheets setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=58676

raal r...@post.cz changed:

   What|Removed |Added

 CC||wmiko...@gmail.com

--- Comment #5 from raal r...@post.cz ---
*** Bug 84395 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: Search in all sheets setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=58676

m.a.riosv mari...@miguelangel.mobi changed:

   What|Removed |Added

 CC||bob...@seznam.cz

--- Comment #4 from m.a.riosv mari...@miguelangel.mobi ---
*** Bug 77395 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: Search in all sheets setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=58676

Stanislav Horacek stanislav.hora...@gmail.com changed:

   What|Removed |Added

 CC||sandeepsangwan...@gmail.com

--- Comment #3 from Stanislav Horacek stanislav.hora...@gmail.com ---
*** Bug 62974 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: Search in all sheets setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=58676

Joren De Cuyper joren.libreoff...@telenet.be changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 QA Contact||joren.libreoffice@telenet.b
   ||e
 Ever confirmed|0   |1

--- Comment #2 from Joren De Cuyper joren.libreoff...@telenet.be ---
(In reply to comment #1)
 Thanks for reporting, Mathieu.
 
 I am agree with your request for enhancement.

Therefore I set this as NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: Search in all sheets setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=58676

Mathieu Stempell dma...@gmx.fr changed:

   What|Removed |Added

Summary|EDITING: Search in all |EDITING: Search in all
   |sheets setting should be   |sheets setting should be
   |persitent after reopening   |persistent after reopening
   |the application |the application

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58676] EDITING: Search in all sheets setting should be persistent after reopening the application

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=58676

mariosv mari...@miguelangel.mobi changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC||mari...@miguelangel.mobi

--- Comment #1 from mariosv mari...@miguelangel.mobi ---
Thanks for reporting, Mathieu.

I am agree with your request for enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs