[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added CC||paolo_debort...@yahoo.com --- Comment #25 from Joren De Cuyper joren.libreoff...@telenet.be --- *** Bug 59590 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #24 from Caolán McNamara caol...@redhat.com --- *** This bug has been marked as a duplicate of bug 55974 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Blocks|54157 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #23 from Michael Meeks michael.me...@novell.com --- So the solution to this is either/and: * add functionality to toolkit/ to tag that some UNO peers don't own the underly outputdevice / widget: seems like a useful feature anyway. The snag is that we need to work out who is creating the VCLXDevice for that widget. * add some null-able smart pointer that goes NULL when it gets destroyed for the sd::Window class (or even vcl::OutputDevice ?), such that we can detect and handle this case sanely. I'll try to poke at either/both of those in my spare cycles. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added CC||gerry.trep...@googlemail.co ||m --- Comment #22 from Joren De Cuyper joren.libreoff...@telenet.be --- *** Bug 59313 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #16 from Michael Meeks michael.me...@novell.com --- The bug in comment #7 reproduces for me too - but not the steps in comment #1. will take a look ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #17 from Michael Meeks michael.me...@novell.com --- Created attachment 72854 -- https://bugs.freedesktop.org/attachment.cgi?id=72854action=edit stack trace. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Michael Meeks michael.me...@novell.com changed: What|Removed |Added Attachment #72854|0 |1 is obsolete|| --- Comment #18 from Michael Meeks michael.me...@novell.com --- Created attachment 72855 -- https://bugs.freedesktop.org/attachment.cgi?id=72855action=edit more debugging valgrind log. I get some deja-vu with this; IIRC I've seen a duplicate of it in the past. It strongly looks like yet-another artifact of VCL's lack of reference-counting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #19 from Joren De Cuyper joren.libreoff...@telenet.be --- (In reply to comment #16) The bug in comment #7 reproduces for me too - but not the steps in comment #1. will take a look ... I can't confirm it anymore with my own steps either (Description); But I can indeed still reproduce with comment #7. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815
--- Comment #20 from Michael Meeks michael.me...@novell.com ---
Wonderful; as expected it is basically VCL being unutterably horrible lifecycle
wise:
--- a/toolkit/source/awt/vclxdevice.cxx
+++ b/toolkit/source/awt/vclxdevice.cxx
@@ -53,6 +53,8 @@ VCLXDevice::~VCLXDevice()
void VCLXDevice::DestroyOutputDevice()
{
+fprintf (stderr, Destroy output device %p: '%s'\n,
+ mpOutputDevice, mpOutputDevice ? typeid(*mpOutputDevice).name() :
null);
delete mpOutputDevice;
mpOutputDevice = NULL;
}
prints out:
Destroy output device 0x8955ee0: 'N2sd6WindowE'
Destroy output device 0x8956268: '9ScrollBar'
Destroy output device 0x8956d30: '9ScrollBar'
Destroy output device 0x8957060: '12ScrollBarBox'
I get:
#0 std::listLink, std::allocatorLink ::remove (this=0x50, __value=...)
at /data/opt/libreoffice/libreoffice-4-0/vcl/source/app/vclevent.cxx:162
#1 0xb67f9533 in VclEventListeners::removeListener (this=0x50, rListener=...)
at /data/opt/libreoffice/libreoffice-4-0/vcl/source/app/vclevent.cxx:110
#2 0xb6a04fed in Window::RemoveEventListener (this=0x8955ee0,
rEventListener=...)
at /data/opt/libreoffice/libreoffice-4-0/vcl/source/window/window.cxx:5310
#3 0xacb17099 in sd::slidesorter::SlideSorter::ReleaseListeners
(this=0x89584c8)
at
/data/opt/libreoffice/libreoffice-4-0/sd/source/ui/slidesorter/shell/SlideSorter.cxx:403
#4 0xacb17649 in sd::slidesorter::SlideSorter::~SlideSorter (this=0x89584c8,
__in_chrg=optimized out)
at
/data/opt/libreoffice/libreoffice-4-0/sd/source/ui/slidesorter/shell/SlideSorter.cxx:218
#5 0xacb17862 in sd::slidesorter::SlideSorter::~SlideSorter (this=0x89584c8,
__in_chrg=optimized out)
at
/data/opt/libreoffice/libreoffice-4-0/sd/source/ui/slidesorter/shell/SlideSorter.cxx:246
The slide-sorter has this rather naive / optimistic boost::shared_ptr:
typedef ::boost::shared_ptrsd::Window SharedSdWindow;
...
class SlideSorter
: private ::boost::noncopyable
{
...
SharedSdWindow mpContentWindow;
Which is just hard deleted by a toolkit peer:
==24244== Address 0xe2a2484 is 244 bytes inside a block of size 324 free'd
==24244==at 0x4027F33: operator delete(void*) (in
/usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==24244==by 0x4FC1085: VCLXDevice::DestroyOutputDevice()
(vclxdevice.cxx:56)
==24244==by 0x4FE34F1: VCLXWindow::dispose() (vclxwindow.cxx:957)
==24244==by 0x509F5B6: UnoWrapper::WindowDestroyed(Window*)
(unowrapper.cxx:263)
==24244==by 0x56BE2B4: Window::~Window() (window.cxx:4333)
==24244==by 0x56936B6: SystemWindow::~SystemWindow() (syswin.cxx:85)
==24244==by 0x56C5C77: WorkWindow::~WorkWindow() (wrkwin.cxx:142)
==24244==by 0x56C5CB1: WorkWindow::~WorkWindow() (wrkwin.cxx:150)
==24244==by 0x12A6BD70:
boost::detail::sp_counted_impl_pWorkWindow::dispose() (checked_delete.hpp:34)
==24244==by 0x12991C0F: boost::detail::shared_count::~shared_count()
(sp_counted_base_gcc_x86.hpp:145)
==24244==by 0x12A69E5E:
sd::framework::BasicViewFactory::~BasicViewFactory() (shared_ptr.hpp:168)
==24244==by 0x12A69F1F:
sd::framework::BasicViewFactory::~BasicViewFactory() (BasicViewFactory.cxx:145)
Which is just silly.
Quite why toolkit thinks it can go deleting windows like that - I have no idea.
The ownership of those resources is extraordinarily unclear.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815
--- Comment #21 from Michael Meeks michael.me...@novell.com ---
Digging at the bibsect:
git log
7c4d3ea6ba4d42b4dda5148a00c8c411b5d7703d..5b195fbcf7a441aeb193f6abd08b877e580938e0
-- sd/
suggest that Thorsten's commit:
commit aa1927dc257b52edf96de220cc3797e02c83a0ae
Author: Thorsten Behrens tbehr...@suse.com
Date: Wed Oct 10 10:57:35 2012 +0200
Make svg export use slidesorter selection in most cases.
There was code previously that took the current selection, iff
Impress main view was in slidesorter mode. Extended this quite
helpful functionality to also work in other modes (as long as a
slidesorter pane is displayed has up-to-date selection, it should
work).
Change-Id: Ibbfe630a4ca31aa52978501745c2eef0d79fb8e3
91 0 sd/source/ui/framework/factories/ViewShellWrapper.cxx
13 2 sd/source/ui/inc/framework/ViewShellWrapper.hxx
Is almost certainly to blame for changing the ordering in subtle ways here:
+::boost::shared_ptr ::sd::slidesorter::SlideSorterViewShell
mpSlideSorterViewShell;
...
@@ -64,6 +75,8 @@ ViewShellWrapper::ViewShellWrapper (
const Referenceawt::XWindow rxWindow)
: ViewShellWrapperInterfaceBase(MutexOwner::maMutex),
mpViewShell(pViewShell),
+ mpSlideSorterViewShell(
+ ::boost::dynamic_pointer_cast
::sd::slidesorter::SlideSorterViewShell ( pViewShell )),
mxViewId(rxViewId),
mxWindow(rxWindow)
{
in particular.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #14 from Petr Mladek pmla...@suse.cz --- I have reproduced the steps from the comment #7 on Linux as well. I used my own build from libreoffice-4-0 branch, pulled today morning. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #15 from ape os...@yandex.ru --- (In reply to comment #14) I have reproduced the steps from the comment #7 on Linux as well. I used my own build from libreoffice-4-0 branch, pulled today morning. 1. Switch Off left panel: View Slide Panel (Impress) \ Page Pane (Draw) 2. Agree with the restoration of Untitled_1.odp \ odg. 3. Starts smath.exe (Windows OS only) and closes its after. -- Impress and Draw are working right. 'Add Slide(impress)\Page(Draw)' option works too across 'Insert Slide'. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #12 from ape os...@yandex.ru --- LOdev_4.1 crashes when closing a new empty (ODG or ODP) document: WindowsXP 64-bit; LOdev_4.1.0.0.alpha0+ (ID: 6a393297ce6d99bbc4edefbf01ab9c5c6f0eff8; TinderBox: Win-x86@6, Branch:master, Time: 2013-01-04_01:06:01). 1. Run Draw or Impress 2. Close the new empty document (i.e., close the Draw or Impress) 3. LOdev_4.1.0.0.alpha0+ suffers crash. But LOdev_4.0.0.0.beta2+ - OK. These are regressions compared to LOdev_4.0.0.0.beta2 (ID assembly: b060b43f093dce23222fd99375b1c6bd433703d; Tinderbox l.lu...@suse.cz: Win-x86 @ 6, time 2013-01-03 13:16:15) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 ape os...@yandex.ru changed: What|Removed |Added Severity|critical|blocker CC||os...@yandex.ru Version|4.0.0.0.beta1 |4.1.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Version|4.1.0.0.alpha0+ Master |4.0.0.0.beta1 --- Comment #13 from Julien Nabet serval2...@yahoo.fr --- ape: I put back former version, for more explanation, see https://wiki.documentfoundation.org/BugReport_Details#Version -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added Summary|[CRASH] new document, close |[CRASH] new document, add |without saving crashes |slide/page, close without |Impress |saving crashes Impress, ||Draw Component|Presentation|Libreoffice --- Comment #11 from Joren De Cuyper joren.libreoff...@telenet.be --- (In reply to comment #10) I've to add that crashes Drawing too! Reproduce: same as Impress. Open Drawing, on the left panel right click, New Page, close the document, click NO save, Drawing crashes I can reproduce that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
