[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 Noel Power nopo...@novell.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |nopo...@novell.com |desktop.org | --- Comment #10 from Noel Power nopo...@novell.com --- (In reply to comment #5) On pc Debian x86-64 with master sources updated yesterday, I reproduced the problem. Noel: one for you? I guess so, no idea what changed here, presumeably either aoo resync or String-OUString work 'cause I don't recall any other changes to this stuff since Libreoffice came into existence ( could be wrong about that though ) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 Joel Madero jmadero@gmail.com changed: What|Removed |Added Severity|major |normal Priority|high|medium CC||jmadero@gmail.com Version|4.0.1.1 rc |3.5.5.3 release --- Comment #2 from Joel Madero jmadero@gmail.com --- updating version as you've said last working version was 3.5.4 release. We use version field to show first version we see problem, not latest it's been tested on (we use comments to say we've tested on newer version and see same problem) Also this will not constitute a major bug (no loss of data, no crash, no memory issues). This is just a normal bug. Marking as NORMAL. Not confirming the issue as I want to see what it looks like using the last version it worked in order to see the difference. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 --- Comment #3 from Joel Madero jmadero@gmail.com --- Additional note for any QA personnel - I tried to bibisect this but see exact same behavior in earliest bibisect as I do with 4.0.0.3 release as well as 4.1 master :-/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 --- Comment #4 from Zarko Zivanov zza...@gmail.com --- I'm not sure that 3.5.4 was last working version, but it was last form 3.x that I used. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 Joel Madero jmadero@gmail.com changed: What|Removed |Added Version|3.5.5.3 release |unspecified -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||nopo...@novell.com, ||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated yesterday, I reproduced the problem. Noel: one for you? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090
--- Comment #6 from Julien Nabet serval2...@yahoo.fr ---
Noel, what about this patch? I tested it for this case and it works but perhaps
I forgot something.
diff --git a/basic/source/runtime/methods.cxx
b/basic/source/runtime/methods.cxx
index 5dc45ed..12dfff2 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -1266,7 +1266,7 @@ RTLFUNC(Mid)
{
aResultStr = aArgStr;
aResultStr.remove( nStartPos, nLen );
-aResultStr.insert( nStartPos,
rPar.Get(4)-GetOUString().getStr(), nLen);
+aResultStr.insert( nStartPos,
rPar.Get(4)-GetOUString().getStr(), std::min(nLen,
rPar.Get(4)-GetOUString().getLength()));
}
rPar.Get(1)-PutString( aResultStr.makeStringAndClear() );
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 --- Comment #7 from Joel Madero jmadero@gmail.com --- Julien - do you see this with 3.6? If not, I must be misunderstanding something, I'd like to get a bibisect if possible -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 --- Comment #8 from Julien Nabet serval2...@yahoo.fr --- (In reply to comment #7) Julien - do you see this with 3.6? If not, I must be misunderstanding something, I'd like to get a bibisect if possible Sorry Joel, I don't have anymore 3.6 or 4.0 sources (I focus on master sources). However I tested on 3.5.4 (Debian package version) and I didn't reproduce the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090
--- Comment #9 from Julien Nabet serval2...@yahoo.fr ---
Also, I think this block should be common (before the if bCompatibility)
sal_Int32 nArgLen = aArgStr.getLength();
if( nStartPos + 1 nArgLen )
{
StarBASIC::Error( SbERR_BAD_ARGUMENT );
return;
}
Because if not, Mid(s, 20, 10, lazy) will have the same kind of effect.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 --- Comment #1 from Zarko Zivanov zza...@gmail.com --- Created attachment 76260 -- https://bugs.freedesktop.org/attachment.cgi?id=76260action=edit The result of using Mid(s,5,10,lazy) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 Zarko Zivanov zza...@gmail.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) Severity|normal |major Priority|medium |high -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62090] : Mid statement doesn't work as expected
https://bugs.freedesktop.org/show_bug.cgi?id=62090 Zarko Zivanov zza...@gmail.com changed: What|Removed |Added Attachment #76260|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
