[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2017-12-13 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=63154

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4441
 Resolution|--- |FIXED

--- Comment #77 from Michael Stahl  ---

* i've redefined SVLIBRARY now similar to comment #3, see commit
68eb27e3bd5d536e7b00b7dc145ae4943b95bec9
* regarding DELETEZ i'd just stupidly expand all invocations, there's no harm
in resetting a pointer if it's not necessary, might even make use-after-free
easier to spot ... it looks like Noel has just started on this so we can assume
it will be finished by next week
* for sal_uLong i've filed bug 114441

other than that, there is just the SVBT stuff left, don't think that can be
easily removed.

so let's call this fixed for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2017-12-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=63154

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:4.1.0 target:4.3.0   |target:4.1.0 target:4.3.0
   ||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2017-12-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=63154

--- Comment #76 from Commit Notification 
 ---
ekuiitr committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=adad3724e6c3e85b1b286ccddaf810f3c782424b

tdf#63154 removed some solar.h references

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2016-02-17 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=63154

jan iversen  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|marcos.souza@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #75 from jan iversen  ---
After mail

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-05-03 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

himanshu hcrobo...@gmail.com changed:

   What|Removed |Added

   Assignee|marcos.souza@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-05-03 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

--- Comment #21 from Tor Lillqvist tlillqv...@suse.com ---
himanshu, please, we don't need two people working on the same thing. (And this
is a too trivial task to count as experience for GSoC anyway.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-05-03 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

David Tardon dtar...@redhat.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |marcos.souza@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-04-20 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

David Tardon dtar...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |marcos.souza@gmail.com
   |desktop.org |
 CC||dtar...@redhat.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-04-16 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

--- Comment #4 from Marcos Souza marcos.souza@gmail.com ---
Thanks for the tips Stephan!

I look at this when my patch about std::max get checked by the build checks.
Maybe Windows build could broke with this commit.

That patch is big, so I want to get it merged before touch this macro :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-04-12 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

--- Comment #3 from Stephan Bergmann sberg...@redhat.com ---
SVLIBRARY should not go into a URE header, as it codifies non-URE
knowledge---namely, that some LO libraries carry a lo in their name.

The best solution appears to be to keep this in a non-URE header.  If there's
no better place than tools, maybe create a dedicated
tools/inc/tools/lomodulename.hxx with a TOOLS_LOMODULENAME macro.  And in any
event, let that macro re-use SAL_MODULENAME (sal/inc/osl/module.h),
TOOLS_LOMODULENAME(name) SAL_MODULENAME(name lo).

The second best solution would be to change the existing uses of SVLIBRARY
directly to SAL_MODULENAME, hard-coding the lo into them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-04-11 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

--- Comment #2 from Marcos Souza marcos.souza@gmail.com ---
Guys, and about this:

#define STRING_CONCAT3( s1, s2, s3 ) \
s1 s2 s3

// dll file extensions

#if defined WNT
#define SVLIBRARY( Base ) \
STRING_CONCAT3( Base, lo, .dll )
#elif defined MACOSX
#define SVLIBRARY( Base ) \
STRING_CONCAT3( lib, Base, lo.dylib )
#elif defined UNX
#define SVLIBRARY( Base ) \
STRING_CONCAT3( lib, Base, lo.so )
#else
  #error unknown platform
#endif

Where we can put this?

This is the file list of who uses the SVLIBRARY macro:
marcos@jedi:~/gitroot/core$ git grep SVLIBRARY
connectivity/source/drivers/mozab/MDriver.cxx:$libname$,
OUString( SVLIBRARY( mozabdrv ) )
connectivity/source/drivers/mozab/MDriver.cxx:const OUString
sModuleName(SVLIBRARY( mozabdrv ));
connectivity/source/drivers/mozab/MServices.cxx:const OUString
sModuleName(SVLIBRARY( mozabdrv ));
connectivity/workben/testmoz/main.cxx:, SVLIBRARY( dtransX11 )//
OBR
sc/source/ui/attrdlg/scabstdlg.cxx:aStrBuf.appendAscii( SVLIBRARY(scui)
);
sc/source/ui/docshell/impex.cxx:OUString sFilterLib(SVLIBRARY(scfilt));
sd/source/filter/sdfilter.cxx:String aTemp(OUString(SVLIBRARY(?)));
sfx2/source/appl/app.cxx:static OUString aLibName( SVLIBRARY( basctl  )
);
sfx2/source/appl/app.cxx:static OUString aLibName( SVLIBRARY( basctl  )
);
sfx2/source/appl/appinit.cxx:static OUString aLibName( SVLIBRARY( cui
) );
sfx2/source/appl/appserv.cxx:static OUString aLibName( SVLIBRARY( basctl 
) );
sfx2/source/appl/appserv.cxx:static OUString aLibName( SVLIBRARY( basctl 
) );
svtools/source/misc/svtaccessiblefactory.cxx:const OUString
sModuleName( SVLIBRARY( acc ));
svx/source/form/dbtoolsclient.cxx:const OUString sModuleName(
SVLIBRARY( dbtools )
sw/source/filter/basflt/fltini.cxx:bool ok = msword_.loadRelative(
thisModule, SVLIBRARY( msword ), SAL_LOADMODULE_GLOBAL | SAL_LOAD
sw/source/ui/dbui/swdbtoolsclient.cxx:const OUString
sModuleName(RTL_CONSTASCII_USTRINGPARAM(SVLIBRARY(dbtools)));
toolkit/source/helper/accessibilityclient.cxx:const OUString
sModuleName( SVLIBRARY( acc ) );
tools/inc/tools/solar.h:#define SVLIBRARY( Base ) \
tools/inc/tools/solar.h:#define SVLIBRARY( Base ) \
tools/inc/tools/solar.h:#define SVLIBRARY( Base ) \
vcl/source/filter/FilterConfigCache.cxx:OUString sTemp(SVLIBRARY(?));

Maybe on sal or osl...?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-04-05 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

Michael Meeks michael.me...@novell.com changed:

   What|Removed |Added

 Whiteboard||EasyHack,DifficultyBeginner
   ||,SkillCpp,TopicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

2013-04-05 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=63154

Michael Meeks michael.me...@novell.com changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #1 from Michael Meeks michael.me...@novell.com ---
Stephan might have some thoughts on this too :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs