[Libreoffice-bugs] [Bug 65492] Opening Password for DOC / XLS file limited to 15 characters (obsolete MSO limit - focus on comment 9)

2020-06-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

Justin L  changed:

   What|Removed |Added

 CC||ke...@palling.net

--- Comment #15 from Justin L  ---
*** Bug 131313 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65492] Opening Password for DOC / XLS file limited to 15 characters (obsolete MSO limit - focus on comment 9)

2020-06-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

Justin L  changed:

   What|Removed |Added

Summary|Opening Password for DOC /  |Opening Password for DOC /
   |XLS file limited to 15  |XLS file limited to 15
   |characters  |characters (obsolete MSO
   ||limit - focus on comment 9)

--- Comment #14 from Justin L  ---
Providing support for longer than 15 character passwords probably requires a
fairly major overhaul. (For .doc I could extend that to 16 characters just by
-if ( nLen <= 15 )
+if ( nLen <= 16 )
in Init97Codec, but higher numbers didn't work, probably because "16" is
hardcoded all over the place in filter/source/msfilter/mscodec.cxx.

This is not an area I should be contributing to anyway, so that's as far as I
will investigate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65492] Opening Password for DOC / XLS file limited to 15 characters

2020-06-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

--- Comment #13 from Justin L  ---
Sample code that allows copy/pasters to open DOC files when typing or pasting a
password larger than the maximum length.
https://gerrit.libreoffice.org/c/core/+/96868

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65492] Opening Password for DOC / XLS file limited to 15 characters

2020-06-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

--- Comment #12 from Justin L  ---
Sample code that allows copy/pasters to open XLS files with a too-long
password. https://gerrit.libreoffice.org/c/core/+/96777

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65492] Opening Password for DOC / XLS file limited to 15 characters

2020-06-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

--- Comment #11 from Justin L  ---
(In reply to hp.web from comment #4)
> It probably would help, if the dialogue would give a hint,
> how many characters the password could have.
The typing hint (during save) exists now in LO 7.0 thanks to bug 43452.


The open dialog itself does not (and should not) limit the characters to 15.
However, I could not open an xls file with a 16 character password created by
Excel 2016.

The code that handles the password checking for xls seems to be in
comphelper/source/misc/docpasswordhelper.cxx
DocPasswordHelper::requestAndVerifyDocPassword()


I also am not able to open Mike's document from comment 9 in LO.

The code that handles the password checking for doc seems to be in
sw/source/filter/ww8/ww8par.cxx
Init97Codec()

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65492] Opening Password for DOC / XLS file limited to 15 characters

2020-05-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

eisa01  changed:

   What|Removed |Added

Version|4.0.3.3 release |Inherited From OOo
Summary|Opening Password for DOC|Opening Password for DOC /
   |file limited to 15  |XLS file limited to 15
   |characters  |characters
   Hardware|Other   |All
 Blocks||109072
 OS|Windows (All)   |All

--- Comment #10 from eisa01  ---
See the spec, section 20 for more info. MSO up to 2003 only supported 15
characters, but 2007 and 2010 supported longer up to 255. Applies to XLS, but
assume it's the same for DOC

https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-xls/a3ad4e36-ab66-426c-ba91-b84433312068

LO 3.3 exhibits the same behavior, can only save with 15 characters, so assume
this is inherited


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109072
[Bug 109072] [META] XLS (binary) format bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs