[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

Stephan Bergmann sberg...@redhat.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTOURBUG   |---

--- Comment #13 from Stephan Bergmann sberg...@redhat.com ---
(In reply to comment #12)
 (In reply to comment #10)
  
  Still, I cannot reproduce the original problem from comment 0.  Dennis, is
  there a chance you produce a screenshot of the Failed to execute default
  Web Browser error box?  It is not clear to me where that originates from. 
  Also, do you run under Gnome, KDE, or some other manager?
 
 Thanks Stephan, you got it ! The problem was desktop environment related : I
 was running XFCE, but when I tried the same steps of comment #0 with KDE or
 MATE, it worked !
 
 So I'm closing this bug and will file one to XFCE people.
 Thanks to all and sorry for the noise.

Not so quick---the different desktops affect LO in that it has three different
scripts it can call when launching a browser, depending on desktop either
program/gnome-open-url, program/kde-open-url, or the fallback program/open-url.

Now, in the fallback program/open-url there is indeed line 65 where the
argument is not properly quoted,

  if echo $1 | grep '^mailto:'  /dev/null; then

where $1 should rather read $1 with quotes around it.

What's strange is that that appears to not make a difference when I test it
here; maybe a variance in Bash.

Denis, if you manually fix that line in your LO installation, does it work even
under XFCE then?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

--- Comment #14 from Stephan Bergmann sberg...@redhat.com ---
Denis, another way to find out exactly where things start to go wrong for you
in the open-url script is to add a line

  set -x

directly after the first line (#!/bin/sh) of your LO installation's
program/open-url, start you LO installation's program/soffice from a terminal
window and capture the output that gets printed when you ctrl+click on the
hyperlink (when running under XFCE).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

--- Comment #15 from denis.pr...@wanadoo.fr ---
(In reply to comment #14)
 Denis, another way to find out exactly where things start to go wrong for
 you in the open-url script is to add a line
 
   set -x
 
 directly after the first line (#!/bin/sh) of your LO installation's
 program/open-url, start you LO installation's program/soffice from a
 terminal window and capture the output that gets printed when you ctrl+click
 on the hyperlink (when running under XFCE).

Thanks Stephan for your tip.
I could reproduce the problem from command line, trying to open the URL with
exo-open, the utility used by XFCE to open files/URL.
So this is definitely an XFCE bug.
I reported it here : 
https://bugzilla.xfce.org/show_bug.cgi?id=10410

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open under XFCE (exo-open)

2013-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

Stephan Bergmann sberg...@redhat.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTOURBUG
Summary|hyperlinks containing   |hyperlinks containing
   |single quote in their URL   |single quote in their URL
   |fail to open|fail to open under XFCE
   ||(exo-open)

--- Comment #16 from Stephan Bergmann sberg...@redhat.com ---
* The missing quoting in echo $1 was indeed a red herring, I fixed that
cosmetic issue nevertheless with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ff0a2e41c872dbfacf132ff756ed10dc8f3e8c7
Quoting clean-up now.

* I discovered one case in the open-url script where things could go wrong,
though, when there is no xdg-open installed and Thunderbird is called with a
-remote openURL(...,new-window) command, verbatim parentheses or commas in the
URL would prevent Thunderbird from parsing that openURL command.  I fixed that
independent issue with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fcdde111e451f84e373c67a485c87d1ad744cfe4
fdo#69462 Properly escape URL in Mozilla -remote openURL(...) command now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open under XFCE (exo-open)

2013-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|BSA PossibleRegression  |BSA PossibleRegression
   ||target:4.2.0

--- Comment #17 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Stephan Bergmann committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fcdde111e451f84e373c67a485c87d1ad744cfe4

fdo#69462 Properly escape URL in Mozilla -remote openURL(...) command



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

denis.pr...@wanadoo.fr changed:

   What|Removed |Added

Summary|hyperlinks containing right |hyperlinks containing
   |parenthesis in their URL|single quote in their URL
   |fail to open|fail to open

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
Version|4.1.1.2 release |3.5.7.2 release

--- Comment #9 from Qubit qu...@runcibility.com ---
(In reply to comment #8)
 But if I replace your URL by this one : 
 
 http://2013-10-08 CR réunion d'organisation Patrick Frédéric Denis (DP).pdf
 
 I get the error message I mentioned in comment #1.
 
 And if I remove the single quote, the problem disappears.

Hi Denis,

Based on my testing I get some mixed results. I can't trigger an error message,
but it looks like the URL isn't always properly passed to the browser.


(Testing on
Ubuntu 12.04.3
LO 4.1.2.3 and LO 3.5.7.2
FF 24
Chromium 28.0.1500.71
)

Steps:
1) Open LibreOffice Writer
2) Select from the Menu: Insert - Hyperlink
3) Use a URL with an apostrophe in it for the 'Target':

(A) http://bla.blah'doo.com
(B) http://2013-10-08 CR réunion d'organisation Patrick Frédéric Denis (DP).pdf

4) Put Test Me into the 'Text' field
5) Click 'Apply' and then 'Close'
6) Try to open the resulting URL using Ctrl-click

RESULT (A): A browser window will open and will show the URL in the Address bar
(note that Chromium will percent-encode the URL):
FF: http://bla.blah'doo.com/
Chromium: http://bla.blah%27doo.com/

Both browsers warn than they were unable to access the website/server.

RESULT (B): A browser window will open, but will show the home page. The
specified URL will not be present in the Address bar  (Same behavior observed
when FF/Chromium is set as the Default Browser).


IS THE URL LEGAL?
In doing some research, I ran across this bug (which will provide you with more
information than you probably ever wanted to know about apostrophes in URLs):
https://bugzilla.mozilla.org/show_bug.cgi?id=407172

I believe that the URLs above are legal per the RFCs mentioned in the Mozilla
bug report above.

TRIAGE:
Some hyperlinks fail to open properly in browser, so this bug is valid:
Changing status 'NEEDINFO' - 'NEW'.

Bug present in 3.5.7.2, which is older than 4.1.1.2, so rolling the version
field back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

Stephan Bergmann sberg...@redhat.com changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #10 from Stephan Bergmann sberg...@redhat.com ---
The URLs in comment 8 and comment 9, http://2013-10-08 CR réunion
d'organisation Patrick Frédéric Denis (DP).pdf and http://bla.blah'doo.com,
are invalid in that their authority component contains invalid characters, and
it is not too surprising that browsers respond differently to them  Replace the
// with //example.com/ in both cases and browsers will start to respond
more similarly to them.  (And about the only thing LO could do about this is
not allow to enter such broken URLs into the Hyperlink dialog in the first
place.)

Still, I cannot reproduce the original problem from comment 0.  Dennis, is
there a chance you produce a screenshot of the Failed to execute default Web
Browser error box?  It is not clear to me where that originates from.  Also,
do you run under Gnome, KDE, or some other manager?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

--- Comment #11 from Thomas Arnhold tho...@arnhold.org ---
The problem seems to be %221:

1. Insert this Link into the hyperlink dialog: http://www.google.de/%20TEST%221

2. This translates to the link: http://www.google.de/ TEST

3. Clicking on this link leads to (in the browser):
http://www.google.de/%20TEST;

The problem seems to be the quotation mark aka %221.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

denis.pr...@wanadoo.fr changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from denis.pr...@wanadoo.fr ---
(In reply to comment #10)
 
 Still, I cannot reproduce the original problem from comment 0.  Dennis, is
 there a chance you produce a screenshot of the Failed to execute default
 Web Browser error box?  It is not clear to me where that originates from. 
 Also, do you run under Gnome, KDE, or some other manager?

Thanks Stephan, you got it ! The problem was desktop environment related : I
was running XFCE, but when I tried the same steps of comment #0 with KDE or
MATE, it worked !

So I'm closing this bug and will file one to XFCE people.
Thanks to all and sorry for the noise.

Denis

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69462] hyperlinks containing single quote in their URL fail to open

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69462

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Resolution|FIXED   |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs