[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=69973 --- Comment #6 from Michael Meeks --- As you like =) it does little harm performance-wise I suspect. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=69973 --- Comment #5 from Julien Nabet --- Thank you Michael for your feedback. Side question: I'm just wondering if we could/should remove SFX_EVENT_CLOSEDOC since I can't imagine a use case that will need it. It would allow us to save 1 call to AddDocumentToPickList. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=69973 Michael Meeks changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Michael Meeks --- Sure - so we do a call there that in AddDocumentToPickList does: if ( aURL.GetProtocol() == INET_PROT_FILE ) Application::AddToRecentDocumentList( aURL.GetURLNoPass( INetURLObject::NO_DECODE ), (pFilter) ? pFilter->GetMimeType() : OUString(), (pFilter) ? pFilter->GetServiceName() : OUString() ); Which (AFAICS) should not really be filtering out only file URLs (at least here) but ... that ends up here: GtkRecentManager *manager = gtk_recent_manager_get_default (); gtk_recent_manager_add_item (manager, sGtkURL.getStr()); And (I guess) it is entirely possible that this now works properly =) I believe the file-selector in other apps uses this, as that now synchronizes without exiting libreoffice, we can close this guy =) Thanks for the poke. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=69973
Julien Nabet changed:
What|Removed |Added
CC||serval2...@yahoo.fr
--- Comment #3 from Julien Nabet ---
Michael: I noticed that AddDocumentToPickList was called at the opening +
closing of the document.
406 case SFX_EVENT_OPENDOC:
407 {
408 AddDocumentToPickList(pDocSh);
409 }
410 break;
411
412 case SFX_EVENT_SAVEDOCDONE:
413 case SFX_EVENT_SAVEASDOCDONE:
414 case SFX_EVENT_SAVETODOCDONE:
415 case SFX_EVENT_CLOSEDOC:
416 {
417 AddDocumentToPickList(pDocSh);
418 }
419 break;
420
421 case SFX_EVENT_SAVEASDOC:
422 {
... 434 AddDocumentToPickList(pDocSh);
See
http://opengrok.libreoffice.org/xref/core/sfx2/source/appl/sfxpicklist.cxx#406
Moreover, shell/source/unix/sysshell/systemshell.cxx is nowhere to be seen (at
least in master sources).
Any thoughts?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.freedesktop.org/show_bug.cgi?id=69973 Qubit changed: What|Removed |Added Whiteboard|EasyHack,DifficultyInterest |EasyHack |ing,SkillCpp,TopicCleanup |DifficultyInteresting ||SkillCpp TopicCleanup CC||qu...@runcibility.com --- Comment #2 from Qubit --- Removing comma from whiteboard (please use a space to delimit values in this field) https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.freedesktop.org/show_bug.cgi?id=69973 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #1 from Björn Michaelsen --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69973] gtk+ recent-files integration improvements
https://bugs.freedesktop.org/show_bug.cgi?id=69973 Michael Meeks changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard||EasyHack,DifficultyInterest ||ing,SkillCpp,TopicCleanup Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
