[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9272

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #32 from Samuel Mehrbrodt (CIB)  ---
Implemented the change suggested by Stuart (adding "Standard" to the top of the
list).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #31 from Commit Notification 
 ---
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1334ee97787aa7cea399fa7f1633aea84ff8047d

tdf#70759 Clear formatting should set "Standard" text style

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|BSA |BSA target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #30 from V Stuart Foote  ---
(In reply to Heiko Tietze from comment #29)
> Better we have Text Body as the default style according bug 47295. (If I had
> the chance to prioritize tickets/topics I'd make this one of the key topics
> for 6.2).

That is fine, but it requires we rework the templates. Issue here is a simple
fix to restore consistency until the templates could be scrubbed.

There are advantages to not tweaking the Default style (e.g. bug 113517) and
moving instead to template controlling the Text Body metrics (bug 94464), but
until we can restructure the standard template(s) to use values of Text
Body--the behavior as here of using Text Body style on clearing styles, rather
than Default style is wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #29 from Heiko Tietze  ---
Better we have Text Body as the default style according bug 47295. (If I had
the chance to prioritize tickets/topics I'd make this one of the key topics for
6.2).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||8969

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #28 from V Stuart Foote  ---
This issue remains. We apply a Text Body paragraph style when using the "Clear
formatting" action from the Apply Styles droplist of the Formatting toolbar.

Correct action should be to apply Default Style to restore paragraph to match
default format when creating paragraphs as from standard template. 

Hey @Samuel, in hindsight, your thought on now restoring a Default (Standard
template) derived style result? Removing Style and ending with non-defaults as
a style is not logical. If it is a simple as restoring the "Standard" to the
top of the list in tbcontrl.cxx seems like we should. And if we ever move to a
Text Body style by default (needing template changes) can realign then.

=-ref-=
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b22881c8166708d6fd42fbadad47ff880ba19ed4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #27 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #26 from Yousuf Philips (jay)  ---
(In reply to V Stuart Foote from comment #24)
> Yes discussions were as I'd linked in comment 18, but still need to finalize
> bug 47295, do we default style to "Default" aka "Standard" or to "Text Body"
> as caused by the changed list?

Oh okay. I didnt think samuel's change there caused the change regression.

> Better question might be why, when creating a new paragraph, do we pick up
> "Default" (ex. Standard) rather than "Text Body"?  And accept that when
> clearing formatting "Text Body" is the correct format (though it needs
> adjustment as in bug 94464).

Well the default template starts off with "Default" for paragraphs, so that is
automatically used unless you create a new paragraph by pressing enter from a
heading style, wherein which the newly paragraph takes on "Text Body". So if we
dont use "Text Body" by default, we should change heading styles' next style to
"Default".

(In reply to Jon Grossart from comment #25)
> In doing reading of how to format "properly", it seems like "Default" should
> only be used to set font family/size, and not really used at in the document.
> 
> It would seem like the default format in a new document should be "Text
> Body" rather than "Default".

With all previously created documents using "Default" and MS Word using
"Normal" which maps to LO's "Default", i would keep "Default" as the default.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #25 from Jon Grossart  ---
This also matches one of my suggestions in 46550.

In doing reading of how to format "properly", it seems like "Default" should
only be used to set font family/size, and not really used at in the document.

It would seem like the default format in a new document should be "Text Body"
rather than "Default".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #24 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #23)
> Thanks. Guess the removal of "Standard" from the top of the aWriterStyles[]
> has caused this behaviour and that can easily be fixed, especially as
> "Standard" (aka Default Style) still remains at the top of the list.

Yes discussions were as I'd linked in comment 18, but still need to finalize
bug 47295, do we default style to "Default" aka "Standard" or to "Text Body" as
caused by the changed list?

Better question might be why, when creating a new paragraph, do we pick up
"Default" (ex. Standard) rather than "Text Body"?  And accept that when
clearing formatting "Text Body" is the correct format (though it needs
adjustment as in bug 94464).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

--- Comment #23 from Yousuf Philips (jay)  ---
(In reply to Aron Budea from comment #22)
> From the range, only the following is a candidate:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=b22881c8166708d6fd42fbadad47ff880ba19ed4

Thanks. Guess the removal of "Standard" from the top of the aWriterStyles[] has
caused this behaviour and that can easily be fixed, especially as "Standard"
(aka Default Style) still remains at the top of the list.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

--- Comment #22 from Aron Budea  ---
Bibisected down to this range:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=1ec666e2c2570e246d2603e6bf5754aaa08f4b92..ec530530b7c4afbc7b521aaf05ac4e3d527fdf7e

>From the range, only the following is a candidate:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b22881c8166708d6fd42fbadad47ff880ba19ed4
author  Samuel Mehrbrodt 2012-12-05
19:48:43 (GMT)
committer   Bosdonnat Cedric  2012-12-06
09:36:21 (GMT)

Modify the default Style list in Writer, give them a custom order.
Asking on UX-Advise, there were no negative voices for this change:
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Default-Styles-in-Writer-td4020441.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70759] Apply Style toolbar "Clear formatting" action sets "Text Body" instead of "Default Style" from LO 4.1+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70759

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 CC||ba...@caesar.elte.hu,
   ||philip...@hotmail.com,
   ||r...@post.cz,
   ||xiscofa...@libreoffice.org
 Blocks|102946  |108346
Summary|Writer: Apply Style toolbar |Apply Style toolbar "Clear
   |"Clear formatting" action   |formatting" action sets
   |sets "Text Body" instead of |"Text Body" instead of
   |"Default Style" from LO 4.1 |"Default Style" from LO
   ||4.1+

--- Comment #21 from Yousuf Philips (jay)  ---
@raal, @xisco, @aron: Can either of you track down the commit this was made in
so we can see the reasoning behind it?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
[Bug 102946] [META] Styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108346
[Bug 108346] [META] Writer paragraph style drop down menu control bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs