[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

--- Comment #21 from Maxim Monastirsky  ---


*** This bug has been marked as a duplicate of bug 113433 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #20 from Maxim Monastirsky  ---
The original problem that the color on the button might not be the same as
applied when clicking it, doesn't exist since [1]. The other part that the last
applied color should be remembered is also covered by Bug 72991.

[1]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=584b415924bba22db23a4258062e54973de0ed7c

*** This bug has been marked as a duplicate of bug 72991 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Xisco Faulí  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Shimon Shore  changed:

   What|Removed |Added

   Assignee|shim...@most.gov.il |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |shim...@most.gov.il
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|shim...@most.gov.il |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Shimon Shore  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |shim...@most.gov.il
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

jan iversen  changed:

   What|Removed |Added

   Assignee|shim...@most.gov.il |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Shimon Shore  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |shim...@most.gov.il
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

jan iversen  changed:

   What|Removed |Added

   Keywords||difficultyInteresting

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||easyHack, skillCpp
 CC||j...@documentfoundation.org
   ||,
   ||xiscofa...@libreoffice.org

--- Comment #14 from Xisco Faulí  ---
@Jan: there's a code pointer in comment 9. An easy hack? I can't tell the
difficulty...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Robinson Tryon (qubit)  changed:

   What|Removed |Added

   Keywords||bibisectNotNeeded
 Whiteboard|bibisectNotNeeded   |

--- Comment #13 from Robinson Tryon (qubit)  ---
Migrating Whiteboard tags to Keywords: (bibisectNotNeeded)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71413

Robinson Tryon (qubit) qu...@runcibility.com changed:

   What|Removed |Added

 CC||qu...@runcibility.com
 Whiteboard||bibisectNotNeeded

--- Comment #12 from Robinson Tryon (qubit) qu...@runcibility.com ---
(In reply to Ivan Timofeev (retired) from comment #9)
 The problem here is that a color info is lost after destroying and creating
 a SvxColorExtToolBoxControl on toolbar hide and show, respectively.
 
 http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.
 cxx#2429

Sounds like we understand this regression pretty well, so 
Whiteboard - bibisectNotNeeded

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71413

Maxim Monastirsky momonas...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=61868

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71413

--- Comment #11 from Winfried Donkers winfrieddonk...@libreoffice.org ---
A possible solution might be to store the last used colours in the class from
which the buttons are created, i.e. ScDLL in the case of Calc.
However, this solution does not look right, as ScDLL has nothing to do with
data such as last used colours of buttons. It disregards some principles of
object oriented programming.

Another solution could be to keep the last used colours with the toolbar
settings. This way it will even remember the last used colours when starting
LibreOffice. But this will be a rather large change and is not familiar terrain
for me at all.

All in all, I don't think it will be me patching this behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71413

Ivan Timofeev timofeev@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|timofeev@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org
 CC||winfrieddonkers@libreoffice
   ||.org

--- Comment #9 from Ivan Timofeev timofeev@gmail.com ---
Set to NEW, because I don't contribute to LibreOffice anymore.

My previous solution didn't work.

The problem here is that a color info is lost after destroying and creating a
SvxColorExtToolBoxControl on toolbar hide and show, respectively.

http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.cxx#2429

Adding Winfried, maybe he can help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71413

--- Comment #10 from Winfried Donkers winfrieddonk...@libreoffice.org ---
(In reply to comment #9)
 Set to NEW, because I don't contribute to LibreOffice anymore.
 
 My previous solution didn't work.
 
 The problem here is that a color info is lost after destroying and creating
 a SvxColorExtToolBoxControl on toolbar hide and show, respectively.
 
 http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.
 cxx#2429
 
 Adding Winfried, maybe he can help.

I will have look at it in due time, am currently busy with calc functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71413

Ivan Timofeev timofeev@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |timofeev@gmail.com
   |desktop.org |

--- Comment #4 from Ivan Timofeev timofeev@gmail.com ---
Thanks for the report. I have a dirty solution... :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71413] WRITER and CALC: Font color toolbar button not redrawn in correct color

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71413

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@quipo.it,
   ||timofeev@gmail.com
Summary|WRITER and CALC: Font color |WRITER and CALC: Font color
   |button on Toolbar doesn't   |toolbar button not redrawn
   |redraw in the correct color |in correct color
Version|4.1.3.2 rc  |3.6.0.4 release
   Keywords||regression
  Component|Writer  |UI
 Ever confirmed|0   |1

--- Comment #3 from tommy27 ba...@quipo.it ---
I confirm issue about Writer and Calc in 4.1.3.2 under Win7 64bit (I had not
time to test Calc behaviour)

it's a regression of 3.6.0 release (it works in 3.5.7) and affects any release
from then to date including Version: 4.2.0.0.alpha0+ 2013-11-01 build

I add GUI expert to CC list.
Ivan, is this something you can handle?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs