[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2023-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

--- Comment #13 from Shane Clay  ---
(In reply to László Németh from comment #8)
> Hi Heiko & Michael: here is the suggested fix for the new action icons,
> shown when the tracked change contains only a single comment, not any extra
> text changes. Likely this is a good compromise to keep it simple while
> offering better feedback (see on the attached screenshot):
> 
> https://gerrit.libreoffice.org/c/core/+/131387 
> https://geometrydash-unblocked.com


I'm surprised at what you comment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

--- Comment #12 from László Németh  ---
(In reply to Heiko Tietze from comment #11)
> Works like a charm. 
> 
> Icons are nice but it shouldn't be the only way of feedback. That's why I
> appreciate the automatic insertion of a TC comment, which could be "Comment
> added" and "Comment deleted" in this case.

@Heiko: many thanks for your nice feedback and suggestion. Here is the proposed
fix for using redline comments:

https://gerrit.libreoffice.org/c/core/+/131659

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

László Németh  changed:

   What|Removed |Added

 Blocks||148032


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148032
[Bug 148032] Writer track changes: add TC comments for annotation-only redlines
as “Comment added”, “Comment deleted” during text insertion/deletion.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

Heiko Tietze  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #11 from Heiko Tietze  ---
Works like a charm. 

Icons are nice but it shouldn't be the only way of feedback. That's why I
appreciate the automatic insertion of a TC comment, which could be "Comment
added" and "Comment deleted" in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|RESOLVED

--- Comment #10 from László Németh  ---
Please, file a new issue for the remaining Filter issue, i.e. filtering by the
tracked comments, if it's needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5645

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

Heiko Tietze  changed:

   What|Removed |Added

 CC||michael.st...@allotropia.de
   Keywords||needsDevAdvice

--- Comment #6 from Heiko Tietze  ---
Michael, any blocker to have more action types at track changes in
addition/deletion/format?

Deletions are taken into the comments now (maybe the option to show deletions
in margins needs to be enabled). Could imagine this as a general way for better
feedback. Could be something like "(+) |  |  | Comment added".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

Buovjaga  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #5 from Buovjaga  ---
Let's ask UX what they think about adding a new type.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7574

--- Comment #4 from Dieter  ---
(In reply to Buovjaga from comment #3)
> The name of the column is "Action" and "Insertion" is expressed with a green
> plus sign. In the Filter tab you can see the names of the change types in a
> dropdown, if you check the action box.

Thank you for explanation. So ide is to have "Comment" a new action type. But
before it should be clear, if comments hould be part of track changes (as far
as I can see only inserting and deleting of comments are tracked as changes);
see bug 147574

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73125] Recorded change type (Action) for comment should be Comment instead of Insertion

2022-03-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73125

Buovjaga  changed:

   What|Removed |Added

Summary|Recorded change type for|Recorded change type
   |comment should be Comment   |(Action) for comment should
   |instead of Insertion|be Comment instead of
   ||Insertion
 Status|NEEDINFO|NEW

--- Comment #3 from Buovjaga  ---
(In reply to Dieter from comment #2)
> I can only see one insertion, but I can't see the column "Type" in Manage
> Changes Dialog. Perhps appearance of the dialog has changed. Could you
> please retest?

The name of the column is "Action" and "Insertion" is expressed with a green
plus sign. In the Filter tab you can see the names of the change types in a
dropdown, if you check the action box.

-- 
You are receiving this mail because:
You are the assignee for the bug.