[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #15 from Julien Nabet  ---
Created attachment 160511
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160511=edit
screenshot

On pc Debian x86-64 with master sources updated today but line break character
is badly display in custom properties (see screenshot).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #14 from ed...@gmx.fr ---
Still there in
Version: 6.1.3.2
Locale: en-US (en_US.UTF-8);

sergio.callegari test document
http://bugs.documentfoundation.org/attachment.cgi?id=124453
macro set_test_property sets a test property where the line break was removed:
"This is a stringwith a line break"

The print_test_property macro does nothing here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #12 from ed...@gmx.fr ---
Still there in
Version: 6.1.3.2
Locale: en-US (en_US.UTF-8);

sergio.callegari test document
http://bugs.documentfoundation.org/attachment.cgi?id=124453
macro set_test_property sets a test property where the line break was removed:
"This is a stringwith a line break"

The print_test_property macro does nothing here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||108747


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108747
[Bug 108747] [META] File properties/settings (meta data) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #10 from sergio.calleg...@gmail.com ---
Just added a document with a test case for the issue.

Document foo.odt is a text document. Looks empty, but contains two macros:

1) Open the document and enable macros

2) Run macro "set_test_property". This programmatically sets a custom property
in the document to the string "This is a string with a line break", with a line
break between the words 'string' and 'with'

3) Test that this is the case by running the macro "print_test_property". You
should see a message box with the text

This is a string
with a line break

4) Open the properties editor: File->Properties->Custom Properties. See that
there is a "test" property. Notice how the text associated to it reads "This is
a stringwith a line break". Press OK.

5) Run again the macro "print_test_property". Now, you see a message box with
the text

This is a stringwith a line break

This proves that opening the properties editor has broken the custom property
by removing the line break.

Now, to the best of my understanding, the odf standard enables line breaks and
other special chars in custom properties, namely:

#x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x1-#x10]
(any Unicode character, excluding the surrogate blocks, FFFE, and ).

Hence, the document properties editor should not break properties containing
any of these chars, otherwise it may end up breaking macros and extensions that
rely on setting these properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #9 from sergio.calleg...@gmail.com ---
Created attachment 124453
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124453=edit
A document with a testcase for the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #8 from sergio.calleg...@gmail.com ---
The bug is still present as of 5.1.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #7 from tommy27  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of
LibreOffice (5.0.5 or 5.1.2 https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of
LibreOffice and your operating system, and any changes you see in the bug
behavior

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a short comment that includes your version of
LibreOffice and Operating System

Please DO NOT

- Update the version field
- Reply via email (please reply directly on the bug tracker)
- Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so: 

1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug 

3. Leave a comment with your results. 

4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 
4b. If the bug was not present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2016-04-16

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

--- Comment #6 from sergio.calleg...@gmail.com ---
A couple of side notes:

1) A regression test for this can be easily implemented, there is no need to
test against an old extension. It is enough to define a LibO macro that puts a
string in containing the line termination char in a custom property.

2) IMHO custom properties should be used for tasks where properties need to be
stored by the user and there is no other obvious interface for the user to
enter them.  In the case of extensions such as texmaths that need to store big
chunks of data that is 'private' to the extension and for which the extension
offers its own user interface, custom properties seem not very appropriate to
me. In fact, big chunks of data tend to clutter the document custom properties
significantly (think of an extension that decides to use 1000 custom properties
for which it is the only user... this would make the custom property dialog
very polluted and difficult to search).

If I read the odf standard properly, there is the possibility to store Text
content being used as RDF metadata. Sec. 4.2.1 see
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#InContentMetadata.
Now, I wonder if LibO provides an API to macro writers for this. If this is the
case, extension writers could be incouraged to use this option when they have
relatively large chunks of data to store. If currently there is no API for
this, it may be worth providing it.

Custom metadata (custom XML elements within meta.xml). Sec. 4.3.1
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#CustomMetadataElements
could be an alternative, but I see it is in being deprecated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

sergio.calleg...@gmail.com changed:

   What|Removed |Added

   Priority|medium  |lowest
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|enhancement |trivial

--- Comment #5 from sergio.calleg...@gmail.com ---
My feeling is that the odf standard should be the rule here.

In principle, if it allows custom properties to contain special characters,
then the UI of LibO should not remove them.  According to the standard, a
custom property of type 'string' ('text' in the LibO interface) should allow

#x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x1-#x10]
(any Unicode character, excluding the surrogate blocks, FFFE, and ).

If LibO decides to remove any of these, the same incident that happened with
texmaths could happen in the future with new extensions, or one might end up
breaking documents made with other production tools compatible with the odf
standard.

In fact, the LibO roundtrip is already OK, because when LibO loads+saves a
file, it preserves these chars. The only issue is that when opening the
document-properties dialogue and editing /any/ custom property, /all/ the
custom properties get deprived of some of the special characters.

So, the whole issue is confined to the management of an interface dialog and
the
point is how to fix it without complicating too much the codebase. IMHO, there
is no need to provide interface elements to let one enter special characters in
the custom properties, and it can even be acceptable to remove special
characters from those entries that are edited. So the only thing that should be
avoided is the cleaning of properties that are not being edited.
It would probably be enough to have a modified flag associated to each custom
property row in the interface and to restrict the update of custom properties
inside the document to those that get the modified flag set.

Since no known extension currently depends on special chars in custom
properties, this can be a very low priority task. But I would confirm the bug
and keep it open as a reminder of the minor issue with the odf standard (e.g.
Priority - lowest, Severity - minor or trivial).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75914

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

Version|4.1.5.3 release |Inherited From OOo

--- Comment #4 from Joel Madero jmadero@gmail.com ---
If the latest texmath has a workaround - I'm wondering if we shouldn't just
close this bug. It seems strange to go test old extensions to show an issue in
LibreOffice.

@Sergio - thoughts about this?

Also changing version to inherited from OOo as I just saw in the description
that that's the correct version (again version is oldest version not latest
tested on)

Thanks all

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=75914

--- Comment #2 from thack...@nexgo.de ---
Hello Sergio, *,
I cannot confirm this bug neither with LO Version: 4.1.5.3 Build-ID:
1c1366bba2ba2b554cd2ca4d87c06da81c05d24 nor with LO Version: 4.2.3.3
Build ID: 6c3586f855673fa6a1576797f575b31ac6fa0ba3 (parallel installed,
following the instructions from
https://wiki.documentfoundation.org/Installing_in_parallel), both with
installed Germanophone lang- as well as helppack under Debian Testing i686,
sorry ... :(

What I did:
1. Downloaded and installed
http://extensions.libreoffice.org/extension-center/texmaths-1/releases/0.39/texmaths-0-39.oxt
2. Created a Writer (but later I tried it also with Impress) document
3. Followed your instructions from point 1 to point 12 ... ;)

But when I reach your point 12, my preamble is not corrupted at all. It looks
the same as the first time.

Which version of the extension did you use, btw.? And would you be so kind to
tell us, which OS/architecture you used to find this bug, please?
TIA
Thomas.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=75914

--- Comment #3 from sergio.calleg...@gmail.com ---
This is because texmaths 0.39 has a workaround for the issue.
It substitutes a rarely used char for the line break.

You can test with texmaths 0.38 or writing a macro that programmatically sets a
custom property to a string with a line break.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=75914

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 CC||jmadero@gmail.com
Version|unspecified |4.1.5.3 release

--- Comment #1 from Joel Madero jmadero@gmail.com ---
Setting version to at least 4.1.5 as version field is the oldest version that
we can reproduce the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs