[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #47 from Noel Grandin  ---
 noelgrandin: perhaps you can exploit the fact that document.xml
refers to the references in footnotes.xml in the same order (refs in
document.xml, data in footnotes.xml), so if you just make sure we stop reading
after the reference we were looking for is found, and try to not start from 0
but try to continue, you would solve the perf problem for the majority of the
cases
 vmiklos, that is an interesting idea

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #46 from Noel Grandin  ---
comments from vmiklos:

 noelgrandin: without reading the bug; IIRC the footnote parsing is
lame, and it parses the whole stream all the time, but ignores all but one
entries; so you have perf problems when you have lots of footnotes, correct?
 vmiklos, correct.
 noelgrandin: one high-level idea might be to see what the RTF
tokenizer does, i think it already generates a token stream which doesn't have
this problem and handled by dmapper. if this is indeed the case, then perhaps
the writerfilter/source/ooxml/ code could be improved to do the same, that
might solve the problem.
 noelgrandin: or a different way: see if comments have the same
problem; if not, perhaps the solution used there could be applied to footnotes,
too.
 vmiklos, thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #45 from Michael Meeks  ---
> Hmmm, so we appear to be parsing the same substream over and over, once
> for each footnote.

Sure - there is just one XML file there; it's a nonsense doing the same rather
expensive XML parsing repeatedly - we should parse once and cache the results
somewhere sensible if we can.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:4.4.0 target:4.3.0.2 |target:4.4.0 target:4.3.0.2
   ||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #44 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/6fea13e7a10272922ffdf74b65add10ecf8cec38%5E%21

tdf#76260 cache next page style number

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #43 from Noel Grandin  ---
Hmmm, so we appear to be parsing the same substream over and over, once for
each footnote.

We construct a child document, parse the substream, and filter out the piece we
are interested in to build the child document.

In theory, we could delay dealing with notes till the end of the document, and
then parse the substream once, but that's a pretty big change.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #42 from Noel Grandin  ---
Unfortunately, there are, in fact ~1000 footnotes in this document, and each
footnote lives in its own little substream, so we need to open and parse 1000
substreams.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-05-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

Xisco FaulĂ­  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #41 from Xisco FaulĂ­  ---
it takes

real1m20,769s
user1m19,477s
sys 0m0,615s

in

Version: 6.3.0.0.alpha1+
Build ID: ad7dfdef5f9504dfcd600bf4d88a97c35b9d5d6d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Noel, I thought you might be interested in this issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2019-02-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=39
   ||179

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 39)

2018-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0351

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes ( see Comment 27 and Comment 39)

2018-05-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76260

Timur  changed:

   What|Removed |Added

Summary|FILEOPEN: extremely slow|FILEOPEN: slow loading and
   |loading .docx with lots of  |dump of .docx with lots of
   |footnotes   |footnotes (see Comment 27
   ||and Comment 39)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs