[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|target:4.4.0|target:4.4.0 target:4.3.2 --- Comment #21 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- nrb...@gmail.com committed a patch related to this issue. It has been pushed to libreoffice-4-3: http://cgit.freedesktop.org/libreoffice/core/commit/?id=22731ba9e15978ab1d1ed98a29d88431cf674257h=libreoffice-4-3 fdo#79599: use \highlightN instead of \chcbpatN in RTF import and export It will be available in LibreOffice 4.3.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #22 from Adolfo Jayme f...@libreoffice.org --- (In reply to comment #19) Please never do that or suggest others to do so. If you use the cherry-pick button, then you'll create a review that you haven't even build-tested Fine, then that button is only for obvious, tiny changes :-) otherwise I do not understand why it was added in the first place... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #19 from Miklos Vajna vmik...@collabora.co.uk --- (In reply to comment #18) You can use the Cherry Pick button in Gerrit to apply a patch to a different branch. Please never do that or suggest others to do so. If you use the cherry-pick button, then you'll create a review that you haven't even build-tested, if something breaks people will learn that your patches are under-tested and it'll just commit to a bad reputation... Thanks! :-) --- Comment #20 from Norbert X nrb...@gmail.com --- Thank you, Adolfo Jayme! Thank you, Miklos Vajna and sberg from IRC! Cherry-picked locally, tested and pushed to LibO 4.3 branch, Gerrit - https://gerrit.libreoffice.org/#/c/10813/ (previously reviewed https://gerrit.libreoffice.org/#/c/9776/). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #18 from Adolfo Jayme f...@libreoffice.org --- You can use the Cherry Pick button in Gerrit to apply a patch to a different branch. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #17 from Jay Philips philip...@hotmail.com --- Hey Norbert, Any chances for 4.3 backport as i just came across an RTF today which wouldnt load the highlight. :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 Norbert X nrb...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=65403 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 tommy27 ba...@quipo.it changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||ba...@quipo.it --- Comment #16 from tommy27 ba...@quipo.it --- Thanks 4 your patch. I set status to FIXED. regarding 4.2.x and 4.3.x backport you should ask in the developer mailing list how to ask a patch review. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #15 from Norbert X nrb...@gmail.com --- Tested on Windows ( Version: 4.4.0.0.alpha0+ Build ID: 67f64c266cd5a0368eff0be727228bc6a9c67cb2 TinderBox: Win-x86@42, Branch:master, Time: 2014-06-20_01:28:13 ) - the bug is fixed. Is it possible to push this changes to all not-EOL versions of LibO (4.2, 4.3)? Who can perform this push? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.4.0 --- Comment #14 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- nrb...@gmail.com committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7eafd8ccac56d7503b4287dfa3acac2cf0560b20 fdo#79599: use \highlightN instead of \chcbpatN in RTF import and export The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #13 from Jay Philips philip...@hotmail.com --- Hi nrbrtx, Seems this issue has been bugging you for the last year, as the other bug is a duplicate of this one for doc and docx. Hope it turns out as fruitful as this one :) Note: it would be nice if you added your name or nickname, so i dont have to refer to you by your email user id. You can change it by visiting https://bugs.freedesktop.org/userprefs.cgi?tab=account and adding something to the 'Your real name' field. :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #10 from nrb...@gmail.com --- Changes pushed to gerrit: https://gerrit.libreoffice.org/9776 , https://gerrit.libreoffice.org/9777 , https://gerrit.libreoffice.org/9778 . With these three commits RTF higlighting works as expected and allows users to exchange RTF-documents between MS Word and LibreOffice. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #11 from Jay Philips philip...@hotmail.com --- Hi nrbrtx, Look forward to testing your patches once they are merged into the daily builds. Do you plan to stick around and help out more with LibreOffice bugs? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 nrb...@gmail.com changed: What|Removed |Added Attachment #100793|0 |1 is obsolete|| --- Comment #9 from nrb...@gmail.com --- Comment on attachment 100793 -- https://bugs.freedesktop.org/attachment.cgi?id=100793 patch for fdo#79599 This patch breaks some unit-tests, so I mark it as obsolete. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #8 from nrb...@gmail.com --- Created attachment 100793 -- https://bugs.freedesktop.org/attachment.cgi?id=100793action=edit patch for fdo#79599 It seems that I solved the problem. For now LibO Writer do not produce \chcbpat (uses \highlight instead of it). And what is important - MS Word 2003 and 2007 can remove produced highlight. Some notes: DomainMapper had wrong logic before. nIntValue contains full color (0xRRGGBB), so getColorFromIndex is not needed. For now PROP_CHAR_HIGHLIGHT is not used. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #7 from nrb...@gmail.com --- Created attachment 100688 -- https://bugs.freedesktop.org/attachment.cgi?id=100688action=edit modified test file for fdo#61909 Thank you Michael and Miklos! I'm playing with RTF-import part and it seems there is something wrong in DomainMaper (writerfilter/source/dmapper/DomainMapper.cxx), it does not show highlighting in document - see NS_ooxml::LN_EG_RPrBase_highlight at http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#1336 . I installed KDevelop, configured source code for debugging but I have no idea how to debug this. It looks so complicated. While working on this bug I found previous bug 61909 and what is interesting - the test file ( http://cgit.freedesktop.org/libreoffice/core/plain/sw/qa/extras/rtfimport/data/fdo61909.rtf ) have white highlight in RTF-markup, so highlight is invisible ( \highlight11 is white=rgb(255,255,255) ). I modified it (used all colors from color table, see fdo61909_mod.rtf) - all paragraphs have no highlight. I also compliled old libreoffice (commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=65f42760736d656b4999aa8830cb4f44f6d4e718h=libreoffice-4-0 , which is related to bug 61909) and there is no higlight too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC||michael.me...@collabora.com --- Comment #5 from Michael Meeks michael.me...@collabora.com --- Miklos any mentoring thoughts ? =) [ rather than fixing it yourself ]. I guess he'd like some code pointers. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #6 from Miklos Vajna vmik...@collabora.co.uk --- editeng is not related to the Writer RTF import/export, as you already found, the relevant import part is writerfilter/source/rtftok/rtfdocumentimpl.cxx, and the relevant export part is sw/source/filter/ww8/rtfattributeoutput.cxx. It's kind of sad that Word has this stupid duplication of character background and highlighting, but sure, if that helps the life of Word users, then we can map our character background to Word's highlight, and not its character background. \highlight is already handled here: http://opengrok.libreoffice.org/xref/core/writerfilter/source/rtftok/rtfdocumentimpl.cxx#3646 If you could check why it's not working the way you would expect it, that would be great. :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #4 from nrb...@gmail.com --- I did checkout of sources from git, found that RTF-export may be fixed by changing line 2237 of file sw/source/filter/ww8/rtfattributeoutput.cxx (http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/filter/ww8/rtfattributeoutput.cxx?id=655377e90c57bb68e5000f06f76531baf9eeaa37#n2237). If I replace m_aStyles.append(OOO_STRING_SVTOOLS_RTF_CHCBPAT); with m_aStyles.append(OOO_STRING_SVTOOLS_RTF_HIGHLIGHT); and recompile, I get RTF-file which may be normally edited by MSO (and possible others, because of \highlight controlword instead of \chcbpat). But if I open this RTF-file with patched LibreOffice it does not render highlight. Should I change something in editeng/source/rtf/rtfitem.cxx and/or writerfilter/source/rtftok/rtfdocumentimpl.cxx ? Any ideas ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 Jay Philips philip...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|major |normal CC||philip...@hotmail.com Version|unspecified |Inherited From OOo Ever confirmed|0 |1 --- Comment #3 from Jay Philips philip...@hotmail.com --- Confirmed in Linux Mint in 3.3.0, 4.2.4 and 4.3 beta. Confirmed against Kingsoft Writer and Word 2013. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 nrb...@gmail.com changed: What|Removed |Added CC||nrb...@gmail.com, ||romano.gianne...@gmail.com See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=37540 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 nrb...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=64490 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599 --- Comment #1 from nrb...@gmail.com --- Created attachment 100365 -- https://bugs.freedesktop.org/attachment.cgi?id=100365action=edit ODT and RTF files produced by LibO and MSO 2003,2007 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79599] FILEOPEN FILESAVE RTF: Libreoffice produces incompatible rtf-code for text-highlighting (uses \chcbpatN instead of \highlightN)
https://bugs.freedesktop.org/show_bug.cgi?id=79599
--- Comment #2 from nrb...@gmail.com ---
As a small note.
I performed the aforementioned tests with Abiword (version 2.9.2 in Ubuntu
Precise).
The results are the following:
Part 1 - Abiword uses '\highlightN' for character background, so RTF-document
exchange between Abiword and MSO 2003,2007 works as expected.
Part 2 - Abiword is able to remove highlight from documents which are produced
in MSO 2003 and MSO 2007.
Also I tested Caligra Words 2.4.0:
it does not render background in RTF file ('highlight_lo.rtf', produced by
LibO),
it renders background normally in RTF files ('highlight_2k3.rtf',
'highlight_2k7.rtf', produced by MSO 2003 and 2007) and is able to remove
highlight
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
