[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

--- Comment #19 from Andreas Heinisch  ---
May anyone can clarify my doubts here. The proposed patch just inserts the
entire text into the hyperlink text as requested.

After I made my settings in the hyperlink dialog, should the entire content of
the selected cell be replaced or should the hyperlink inserted after the cursor
in the respective cell?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Andreas Heinisch  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #18 from Andreas Heinisch  ---
Could this be viable solution: https://gerrit.libreoffice.org/c/core/+/131156

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Heiko Tietze  changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #17 from Heiko Tietze  ---
*** Bug 129493 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
   Keywords|needsUXEval |

--- Comment #16 from Heiko Tietze  ---
We discussed the request in the design meeting and support the idea. Removing
needsUX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

--- Comment #15 from Cor Nouws  ---
(In reply to Cor Nouws from comment #4)
> Thinking about reconsidering my support for this.
> A 'highlighted' cell as meant here, is a cell with the cell-focus.
> Always the behavior is: start typing/pasting, and the current content is
> ignored and replaced.
> As such, the current behavior is logic and consistent.

The requested behavior makes that the content (foo) is indeed replaced, by the
hyperlink. So my comment was confused - I support this request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Cor Nouws  changed:

   What|Removed |Added

   Keywords||needsUXEval

--- Comment #13 from Cor Nouws  ---
propose to add to the agenda of the UX meeting(s).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||120543


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120543
[Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

--- Comment #12 from Cor Nouws  ---
(In reply to Yousuf Philips (jay) from comment #10)

As written in comment #5: its against the nature of editing in Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

--- Comment #10 from Yousuf Philips (jay)  ---
(In reply to Eike Rathke from comment #9)
> If I understood correctly, the original request is to prefill the
> hyperlink's Text field with the cell content the cell cursor is on (as if
> the entire cell content was selected when doing in-cell editing), and when
> applied the hyperlink should replace the cell content. Correct?

Yes this is what was requested. But there will be situations when the cell
contents have a hyperlink in it, and ideally in this case, it would clear any
hyperlinks already present and creating the new hyperlink that covers all the
cells text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

--- Comment #9 from Eike Rathke  ---
Excel can have only one hyperlink per cell and only a hyperlink if a hyperlink,
no further text. That's not a good example. And not even related to the
original request. ODF doesn't have that limitation.

If I understood correctly, the original request is to prefill the hyperlink's
Text field with the cell content the cell cursor is on (as if the entire cell
content was selected when doing in-cell editing), and when applied the
hyperlink should replace the cell content. Correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Heiko Tietze  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #8 from Heiko Tietze  ---
(In reply to Yousuf Philips (jay) from comment #6)
> The same as we show in Writer, ...
> I dont think the current behaviour is good and tested Excel...

Calc contains structured data which makes it different to Writer.

Excel 2010:

123 http://test.com 456 -> no hyperlink
123 http://test.com -> no hyperlink
http://test.com 456 -> no hyperlink
http://test.com -> hyperlink

Regina, any relevant aspects from ODF spec?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||vstuart.fo...@utsa.edu

--- Comment #6 from Yousuf Philips (jay)  ---
(In reply to Heiko Tietze from comment #5)
> We should take care about over-engineering. What should be shown in case of
> "foo http://test.com bar"?

The same as we show in Writer, "foo http://test.com bar".

> So how about keeping the current behavior and
> fill in the dialog only when the cell contains a valid link.

I dont think the current behaviour is good and tested Excel, WPS, Softmaker and
Google Docs and all take the cell contents as the text.

@Eike, Stuart: What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

--- Comment #5 from Heiko Tietze  ---
We should take care about over-engineering. What should be shown in case of
"foo http://test.com bar"? So how about keeping the current behavior and fill
in the dialog only when the cell contains a valid link.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

--- Comment #4 from Cor Nouws  ---
Thinking about reconsidering my support for this.
A 'highlighted' cell as meant here, is a cell with the cell-focus.
Always the behavior is: start typing/pasting, and the current content is
ignored and replaced.
As such, the current behavior is logic and consistent.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80043] EDITING: Insert hyperlink dialog wont use text in highlighted cell as hyperlink text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80043

Yousuf Philips (jay)  changed:

   What|Removed |Added

Summary|EDITING: dialog to insert   |EDITING: Insert hyperlink
   |hyperlink doesn't use cell  |dialog wont use text in
   |text when the cell -not |highlighted cell as
   |(part of) the content- is   |hyperlink text
   |selected|

--- Comment #3 from Yousuf Philips (jay)  ---
Still present.

steps:
1. open calc
2. type 12 into A1 and press enter
3. press up key to return to A1
4. insert hyperlink
5. 'text' field doesnt show '12'

Version: 6.0.0.0.alpha1+
Build ID: 8ba60ca42d4d1873b8cd85c5d3b5ed2f0e19df60
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs