[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #16 from Caolán McNamara caol...@redhat.com --- because there is initially no ControlFont, getting one gives a 0x0 font, i.e. use default size, so multiplying it has no effect. Hence I guess the hard-coded 15pt. 15pt is 1.25 the size of the typical 12pt, but we use 1.2 in the message dialogs, so lets go with that multiplier. The trick being to retrieve from the settings a Font which has the true number of the default filled in -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476
--- Comment #15 from Michael Meeks michael.me...@collabora.com ---
Ah - well ;-) I suspect that the problem lies here:
sfx2/source/dialog/backingwindow.cxx
const int nButtonsFontSize = 15;
which is a hard-coded point (whatever that means) size for the font there.
I suspect if instead we had something like:
Font aFont = pParent-GetSettings().GetStyleSettings().GetLabelFont();
aFont.SetSize(Size(0, aFont.GetSize().Height() * 1.2));
aFont.SetWeight(WEIGHT_BOLD);
Or somesuch (as we do for the message dialogs font); perhaps this would do it -
testing appreciated:
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -59,7 +59,7 @@ const char TEMPLATE_URL[] = slot:5500;
const char OPEN_URL[] = .uno:Open;
const char SERVICENAME_CFGREADACCESS[] =
com.sun.star.configuration.ConfigurationAccess;
-const int nButtonsFontSize = 15;
+const float nButtonsFontEnlarge = 1.5;
const Color aButtonsBackground(114, 168, 84); // TDF green
const Color aButtonsText(COL_WHITE);
@@ -242,7 +242,7 @@ void BackingWindow::initControls()
// setup nice colors
mpCreateLabel-SetControlForeground(aButtonsText);
Font aFont(mpCreateLabel-GetControlFont());
-aFont.SetHeight(nButtonsFontSize);
+aFont.SetHeight(aFont.GetSize().Height() * nButtonsFontEnlarge);
mpCreateLabel-SetControlFont(aFont);
mpHelpButton-SetControlForeground(aButtonsText);
@@ -274,7 +274,7 @@ void BackingWindow::setupButton( PushButton* pButton )
{
// the buttons should have a bit bigger font
Font aFont(pButton-GetControlFont());
-aFont.SetHeight(nButtonsFontSize);
+aFont.SetHeight(aFont.GetSize().Height() * nButtonsFontEnlarge);
pButton-SetControlFont(aFont);
// color that fits the theme
Then again - that doesn't appear to have any effect on the font size whatever
so ... ;-) hmm.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC||michael.me...@collabora.com --- Comment #12 from Michael Meeks michael.me...@collabora.com --- Is this truly a most-annoying bug for 4.3 ? =) compared to the others, it doesn't seem so severe. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 --- Comment #13 from Mirek2 maz...@gmail.com --- (In reply to comment #12) Is this truly a most-annoying bug for 4.3 ? =) compared to the others, it doesn't seem so severe. It's an eyesore whenever I see this on a MacBook, and given that this is something Mac OS X users always see when launching LibreOffice, I would say it's pretty important (albeit perhaps only for Mac users). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 --- Comment #14 from V Stuart Foote vstuart.fo...@utsa.edu --- MAB, yes. But certainly no blocker. But it is of MAB importance from the perspective that it is our most visible element (i.e. the first seen seen every launch) implemented with GTK+ UI. And there is also an implementation issue of using GTK+ UI widgets for GUI layout if we are unable to control things to obtain consistent results. Even if it is because of differences in the widgets across the platforms--maybe Not Our Bug, but we still have to deal with it. Can we even specify font family and weight in UI and have it apply in all OS? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 --- Comment #8 from Adolfo Jayme f...@libreoffice.org --- (In reply to comment #7) from a design and UX perspective it is an oversight in implementation. Hm, I doubt that the difference in sizing is our implementators’ fault. The UI fonts used in Windows (MS Sans Serif, Tahoma, Segoe UI); Mac (Lucida Grande, Helvetica Neue); and Linux (DejaVu, Ubuntu, Cantarell, ...) have all wildly different metrics, so it’s obvious that they will look different. (In reply to comment #3) Compared to every other UI element -- e.g. the two rectangular buttons at the bottom. (If you launch other applications or open other LibreOffice, the difference is even clearer, but you can still guess at the correct size by looking at e.g. the menu bar or the title bar.) Well, the design for the start center contemplated bigger labels from the start. Nobody made mockups with Lucida Grande, as it’s obvious. Also, how is this not a bug? I doubt it was the intention to make the button labels look terribly disproportionate on Mac OS X, but nice on Linux. See my reply to comment #7. Anyway, as I mentioned already, we could reduce the size a bit everywhere and achieve a nice compromise. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 --- Comment #9 from Mirek2 maz...@gmail.com --- (In reply to comment #8) (In reply to comment #7) from a design and UX perspective it is an oversight in implementation. Hm, I doubt that the difference in sizing is our implementators’ fault. The UI fonts used in Windows (MS Sans Serif, Tahoma, Segoe UI); Mac (Lucida Grande, Helvetica Neue); and Linux (DejaVu, Ubuntu, Cantarell, ...) have all wildly different metrics, so it’s obvious that they will look different. They might have different metrics, but that's not all that's in play here. Compare the Linux and the Mac OS X screenshot. On Linux (using the Cantarell font), the font sizes used in the sidebar are quite similar -- the labels in the rectangular buttons at the bottom are just slightly smaller than the labels above. On Mac OS X, though, the labels at the top are huge, bigger than the Linux ones, while the labels at the bottom are miniscule, smaller than the Linux ones. That either means that two different fonts are being used in the Mac OS X sidebar -- which I doubt, but if it was the case, it would present a consistency problem as well -- or that there's a problem with label scaling. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 --- Comment #10 from Adolfo Jayme f...@libreoffice.org --- They might have different metrics, but that's not all that's in play here That *is* in play. Of course, I didn’t mean to say that’s the only affecting factor – also, different OS approaches to font scaling ← I wouldn’t say it’s a LibreOffice issue (it’s the OS the one doing the rendering), but LibreOffice exacerbates it by using non-standard font sizes. On Linux (using the Cantarell font), the font sizes used in the sidebar are quite similar But that is only an effect of your setting of Cantarell Bold as your UI face. Try again using Cantarell like in a normal setup (i.e. the Regular weight) and you will notice a bigger difference. (BTW, you’re using a pretty old version of Cantarell). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 --- Comment #11 from Adolfo Jayme f...@libreoffice.org --- That either means that two different fonts are being used in the Mac OS X sidebar Lucida Grande only has two weights, and Bold is obviously not used. Also, the Start Center code has not hardcoded any font. or that there's a problem with label scaling. That’s what I’m saying. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 Mirek2 maz...@gmail.com changed: What|Removed |Added Blocks||75025 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||65138 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Severity|enhancement |normal Priority|medium |high CC||vstuart.fo...@utsa.edu --- Comment #7 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to comment #1) ... Not a bug, btw. Actually, while the devs may object, from a design and UX perspective it is an oversight in implementation. Function may be correct, but the form is equally important--if not more so given the functional goals for the Start center. https://wiki.documentfoundation.org/Design/Whiteboards/Start_Center In implementing layout using GTK+ UI widgets we gain some very nice design and development resources, but we are finding occasional cross-platform warts like this. Such issues are bugs and need to be corrected. As to priority, if it is visible/noticeable, while not at the level of a functional regression, it is high. Setting back accordingly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks|65138 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||61914 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80476] Start Center sidebar button labels are too large and vary in size on different operating systems
https://bugs.freedesktop.org/show_bug.cgi?id=80476 kl...@yopmail.com changed: What|Removed |Added Hardware|x86-64 (AMD64) |All OS|Mac OS X (All) |All Severity|normal |enhancement Summary|Start Center sidebar button |Start Center sidebar button |labels are too large with |labels are too large and |OS X’s Lucida Grande font |vary in size on different ||operating systems --- Comment #6 from kl...@yopmail.com --- (In reply to comment #3) The bottom buttons represent web-links rather than programs. It's not like they'd exceed the screen width either. The devs decided to go with this. So I doubt, it wasn't the intention to enlarge so-called 'labels'. I've switched it to 'enhancement' and made a major edit. The XP-version is currently the smallest in 4.3 RC1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
