[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83037

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #11 from Caolán McNamara  ---
If there are no other problems after testing let me know and we can backport to
5-2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83037

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:4.4.0|target:4.4.0 target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83037

--- Comment #10 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bfefc0b396bd61cc5f508bf86afc12cfadaa483

Resolves: tdf#83037 <-->  corrected into ← →  instead of ↔

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83037

--- Comment #9 from Caolán McNamara  ---
What we could do is to go back revisit bug 55693 which make a hyphen a word
break character, and not do that unless certain conditions hold that are good
enough for the needs of bug 55693

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83037

tommy27  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #8 from tommy27  ---
adding Caolan McNamara to CC list 

he recently provided a fix for Bug 96369 - ordinal numbers suffixes autocorrect
replacements triggered in between words

so I'm asking him to evaluate if a similar approach could be use to fix this
autocorrect collision as well, and specifically use the possibile solution I
suggested in comment 3 which is:

add an exception to the "hyphen autocorrect trigger thing" and use it as a
trigger only if preceded by letters, number or any other symbol rather than
another hyphen.

if this solution is technically feasible it would resolve at least 3 bugs about
hyphen autocorrect collision: Bug 83037, Bug 81301 and Bug 67364

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83037

--- Comment #7 from tommy27  ---
<--  corrected into  ←-  instead of  ← 
and <-->  corrected into ← →  instead of ↔  

still exists in recent LibO 5.1.0 alpha 

both issues are caused by the autocorrect engine kicking in as soon as you type
an hyphen as explained in detail in comment 3 and comment 4

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

--- Comment #6 from tommy27 ba...@quipo.it ---
@Lazlo

the committ I refer is:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=10176b1b6f4801d78695451a1eccabf32701e175

I'm not a developer but I suppose that if you were able to disactivate the
/ as an autocorrect trigger under some circumstances (i.e. dates like 1/2/14)
it should be possible to do something similar with - in order to avoid the
autocorrect to kick in when an hyphen is followed by another hyphen --

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

--- Comment #5 from tommy27 ba...@quipo.it ---
(In reply to comment #4)
 
 
 I wonder if you could tweak the code to avoid autocorrect triggering when an
 hyphen is followed by another hyphen, adding an exception similar to the one
 used to fix Bug 33899 - Autocorrection replaces dates with fractions
 
 moreoved if that  -- no autocorrect could be achieved it would also
 represent a fix for aforementioned Bug 67364 and Bug 81301

hi Lazlo, have you read my suggestion in previous comment?
do you think that it's technically feasible?
If my idea is right it would fix 3 bugs in a single shot: current Bug 83037,
Bug 67364 and Bug 81301.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

tommy27 ba...@quipo.it changed:

   What|Removed |Added

Summary|→ and ← and autocorrect |→ and ← and ↔ autocorrect
   |collisions  |collisions

--- Comment #4 from tommy27 ba...@quipo.it ---
Hi Lazlo,
another existing collision is the one that happens between:

-- to ↔
and 
.*-.* to ←
and
.*-.* to → 

(adding this to summary notes as well)

so when you type -- you obtain instead of ↔ you get ← → 

this is again due to the hyphen autocorrect trigger issue

basically the -- sequence is not managed by autocorrect engine as a single
replacement, but is splitted as - + - since the first hyphen triggers
autocorrect to replace - into ← and then - as →

I wonder if you could tweak the code to avoid autocorrect triggering when an
hyphen is followed by another hyphen, adding an exception similar to the one
used to fix Bug 33899 - Autocorrection replaces dates with fractions

moreoved if that  -- no autocorrect could be achieved it would also represent
a fix for aforementioned Bug 67364 and Bug 81301

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and ↔ autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

tommy27 ba...@quipo.it changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=67364

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard||target:4.4.0

--- Comment #1 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=34827767b1551f7a61bcd53947255ad2d2a9e5da

fdo#83037 fix autocorrect collisions of short and long ASCII arrows



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

László Németh nem...@numbertext.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from László Németh nem...@numbertext.org ---
I have restored the original work of the single -- sequence.

Bad replacement of the single -- is an interesting problem, maybe it doesn't
related to the wildcard patch.

Thanks for your report!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

--- Comment #3 from tommy27 ba...@quipo.it ---
(In reply to comment #2)
 I have restored the original work of the single -- sequence.
 
 Bad replacement of the single -- is an interesting problem, maybe it
 doesn't related to the wildcard patch.

the root of this problem is that the hyphen - is an autocorrect trigger like
. , , , : , ; , space and enter

that's why, even without wildcards you have a collision between - and --

it because when you type the last - of -- this triggers the -
autocorrect.
basically typing -- is like typing -.  so that's why 

this hyphen autocorrect trigger issue is the cause of other autocorrect
collision which are described here: 

Bug 67364 - FORMATTING: Autocorrect no longer functions correctly when
replacing two hyphens if also an entry with three hyphens exists

Bug 81301 - apply border won't work because of hyphen to en-dash
autocorrect collision (nl-NL and nl-BE locales only) (edit)

the only way to avoid all these 3 bugs would be to tweak the code and add an
exception to the hyphen autocorrect trigger thing and use it as a trigger
only if preceded by letters, number or any other symbol rather than another
hyphen.

LibO already supports some kind of autocorrect exceptions like Words with Two
Initial Capitals or Abbreviations (words with no subsequent capitalization

so probably we should do something like no autocorrect trigger after --
I don't know if this is technically feasible... what's your opinion Lazlo?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

tommy27 ba...@quipo.it changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=81301

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83037] → and ← and autocorrect collisions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=83037

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 CC||ba...@quipo.it
   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=81571

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs