[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|NEW |RESOLVED CC||serval2...@yahoo.fr Resolution|--- |FIXED --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- So fixed by David's patch, see https://bugs.freedesktop.org/show_bug.cgi?id=84090#c5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp TopicCleanup |SkillCpp TopicCleanup ||target:4.4.0 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- David Ostrovsky committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0ea9722f72c1bece218013cce4c5d9097994408f fdo#84090: Remove maUniName from oox::TokenMap The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 --- Comment #4 from Matúš Kukan matus.ku...@collabora.com --- (In reply to comment #2) Can you be more precise as to what we have to do here ? Change: typedef ::std::vector TokenName TokenNameVector; to typedef ::std::vector css::uno::Sequence sal_Int8 TokenNameVector; And remove TokenMap Also remove TokenMap::getUnicodeTokenName And make it compile ;-) .. which also means you will have to use getUtf8TokenName and do some conversions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 --- Comment #2 from Siddu sidchelsea...@gmail.com --- (In reply to comment #0) This task is about removing maUniName from include/oox/token/tokenmap.hxx which stores the same content as maUtf8Name in another form and is used mostly for debugging purposes only. Where TokenMap::getUnicodeTokenName was used, one can use TokenMap::getUtf8TokenName Remove maUniName from struct TokenName, that struct can then also die, and do following simplifications / adaptations. We used to spend 10m pseudo cycles in TokenMap constructor, this should save about a half of that. Can you be more precise as to what we have to do here ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 --- Comment #3 from Siddu sidchelsea...@gmail.com --- (In reply to comment #0) This task is about removing maUniName from include/oox/token/tokenmap.hxx which stores the same content as maUtf8Name in another form and is used mostly for debugging purposes only. Where TokenMap::getUnicodeTokenName was used, one can use TokenMap::getUtf8TokenName Remove maUniName from struct TokenName, that struct can then also die, and do following simplifications / adaptations. We used to spend 10m pseudo cycles in TokenMap constructor, this should save about a half of that. 1.Do I have to replace the method getUnicodeTokenName with getUtf8TokenName in tokenmap.cxx? 2. After removing maUniName what do you mean the entire struct i.e TokenName can die ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 --- Comment #1 from Siddu sidchelsea...@gmail.com --- Sudarshan Rao proposed a change to core: Changed getUnicodeTokenName to getUtf8TokenName. https://gerrit.libreoffice.org/11558. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84090] Speed up oox::TokenMap by removing unnecessary maUniName OUString
https://bugs.freedesktop.org/show_bug.cgi?id=84090 Matúš Kukan matus.ku...@collabora.com changed: What|Removed |Added Whiteboard||EasyHack DifficultyBeginner ||SkillCpp TopicCleanup CC||libreoffice@lists.freedeskt ||op.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
