[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.1.0|target:5.1.0 target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #22 from Commit Notification 
 ---
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7df058224a7cabb1cbfc8564ffe22a6844fb2a1f

tdf#86508 Use Yellow and Green for 2 entry color scale

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #20 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #19)
> Created attachment 137658 [details]
> Yellow to Green color variants
> 
> Light Yellow 3 and Light Green 3 are too light/faded in my view, especially
> as the sheet is white, and we should likely go with Light Yellow 2 and Light
> Green 2.

Thanks for the side-by-side clip, looking more closely at this agree the 3's
are a bit too muted and the 2's would be the better defaults.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #19 from Yousuf Philips (jay)  ---
Created attachment 137658
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137658=edit
Yellow to Green color variants

Light Yellow 3 and Light Green 3 are too light/faded in my view, especially as
the sheet is white, and we should likely go with Light Yellow 2 and Light Green
2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #18 from Heiko Tietze  ---
Decision in the design meeting was to use "Yellow Light 3" and "Yellow Green 3"
from the new standard palette.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|

--- Comment #16 from Yousuf Philips (jay)  ---
(In reply to Xisco Faulí from comment #15)
> > With the 2 part color scales, Katarina and I were debating it on IRC with
> > the suggested options from comment 6 and thought a color on both side with
> > one of them not being white, as white is the default color of the sheet,
> > would likely be the best option (i.e. Green and Yellow). What do others
> > think?
> 
> @Yousuf, it seems there are no other opinions after 2 years :D
> Should the UX team be added?

Heiko's added it to the agenda of this week's design meeting.

Stuart, Cor, Adolfo: do you guys have a preference for the color scale 2
entries. See the excel colors mentioned in comment 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #15 from Xisco Faulí  ---
(In reply to Yousuf Philips (jay) from comment #14)
> So Katarina fixed the 3 part color scales to Red 3, Yellow 2, Green 3 and
> that has been pushed in.
> 
> With the 2 part color scales, Katarina and I were debating it on IRC with
> the suggested options from comment 6 and thought a color on both side with
> one of them not being white, as white is the default color of the sheet,
> would likely be the best option (i.e. Green and Yellow). What do others
> think?

@Yousuf, it seems there are no other opinions after 2 years :D
Should the UX team be added?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|needsDevEval topicUI|needsDevEval topicUI
   ||target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #13 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f0ca33be7e6cb22ecc8853c1812fa649bfdf4d0

tdf#86508: Traffic light colour scale for cond. formatting

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard|needsDevEval topicUI|target:5.1.0
   |target:5.1.0|

--- Comment #14 from Yousuf (Jay) Philips  ---
So Katarina fixed the 3 part color scales to Red 3, Yellow 2, Green 3 and that
has been pushed in.

With the 2 part color scales, Katarina and I were debating it on IRC with the
suggested options from comment 6 and thought a color on both side with one of
them not being white, as white is the default color of the sheet, would likely
be the best option (i.e. Green and Yellow). What do others think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #12 from Katarina Behrens (CIB)  ---
Interested people can try this: https://gerrit.libreoffice.org/#/c/19609/

the code change's trivial, it's more the choice of colours that needs some
feedback

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

fractal618  changed:

   What|Removed |Added

   Hardware|Other   |All
Version|4.4.0.0.alpha2  |5.0.0.5 release
   Severity|enhancement |minor

--- Comment #7 from fractal618  ---
The middle color should be White not Black

http://imgur.com/eKINwig

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #9 from V Stuart Foote  ---
still needs dev review and designation as an EasyHack

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

V Stuart Foote  changed:

   What|Removed |Added

Version|5.0.0.5 release |4.4.0.0.alpha2
   Severity|minor   |enhancement

--- Comment #8 from V Stuart Foote  ---
back to enhancement and version as in OP

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #11 from V Stuart Foote  ---
(In reply to Yousuf (Jay) Philips from comment #10)
> @Bubli, @Maxim: Is this something easy to fix with the dialog not being in
> the new glade .ui style?

Yes just the dialog is in .UI already

http://opengrok.libreoffice.org/xref/core/sc/uiconfig/scalc/ui/conditionalformatdialog.ui

I think the controls are in 
http://opengrok.libreoffice.org/xref/core/sc/source/ui/inc/condformatdlgentry.hxx

and

http://opengrok.libreoffice.org/xref/core/sc/source/ui/condformat/condformatdlgentry.cxx#902
where we I think we would disable automatic for the LB_COL_MIDDLE. Or
alternatively, define its default specifically to WHITE--but I couldn't find
where the default colors for the LB_COL_MIN and LB_COL_MAX, and presumably
would set a default COLOR for LB_COL_MIDDLE

For the 3Color gradient type--the default middle color of BLACK is bad.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||bu...@bubli.org,
   ||momonas...@gmail.com

--- Comment #10 from Yousuf (Jay) Philips  ---
@Bubli, @Maxim: Is this something easy to fix with the dialog not being in the
new glade .ui style?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86508

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||962,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||966
 Whiteboard|needsDevEval|needsDevEval topicUI

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86508

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Blocks||87351

--- Comment #6 from Jay Philips philip...@hotmail.com ---
Yes ideally this should be an EasyHack. In addition to the 'Color Scale (3
Entries)' being Red 3, Blank (Black), and Blue 3, 'Color Scale (2 Entries)' is
set to Red 3 and Blue 3, which should also be changed.

Excel comes with these 2 entry predefined color scale color themes (visible in
attachment 109790):

White, Red
Red, White
Green, White
White, Green
Green, Yellow
Yellow Green

It should also be noted that Red 3 and Blue 3 are also the preset colors used
in conditional formatting data bar, so changes to color scale color presets
shouldnt effect data bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86508

--- Comment #4 from Jay Philips philip...@hotmail.com ---
(In reply to V Stuart Foote from comment #3)
 +1, the Red-Yellow-Green would make more sense visually. But any sequence
 other than Red-Black-Blue--so as to exclude Black--would be an improvement.

Well the black only appears because the 2nd color is not set by default in the
dialog (attachment 109794) and if a user doesnt set it, LO use black in that
scenario (i would have thought it would have used white and thought to file a
bug for that).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86508

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |f...@libreoffice.org,
   |.freedesktop.org|michael.me...@collabora.com
  Component|ux-advise   |Spreadsheet
 Whiteboard||NeedsDevEval

--- Comment #5 from Adolfo Jayme f...@libreoffice.org ---
Perhaps this can be made into an EasyHack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86508

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@quipo.it
 Ever confirmed|0   |1

--- Comment #2 from tommy27 ba...@quipo.it ---
I agree. status NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86508

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu ---
+1, the Red-Yellow-Green would make more sense visually. But any sequence other
than Red-Black-Blue--so as to exclude Black--would be an improvement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86508

--- Comment #1 from Jay Philips philip...@hotmail.com ---
Created attachment 109790
  -- https://bugs.freedesktop.org/attachment.cgi?id=109790action=edit
predefined color scales in MS Excel

Excel comes with a nice set of 3 entry predefined color scale color themes
which can be seen in the attachment. These include:

Green, Yellow, Red
Red, Yellow, Green
Green, White, Red
Red, White, Green
Light Blue, White, Red
Red, White, Light Blue

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs